Review

Detector:	Jadet
Target:	project ' logblock-logblock-2 ' version 40548aa
Misuse:	misuse ' 15 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance, it is recommended to flush or close the DataOutputStream before invoking the underlying instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for example here. This pull request adds a close method before calling toByteArray().
Fix Description:	(see diff)
Violation Types:	missing/call
In File:	org/logblock/entry/BlobTest.java
In Method:	paintingTest()
Code with Misuse:	class BlobTest { @Test public void paintingTest() throws Exception { ByteArrayOutputStream byteOutput = new ByteArrayOutputStream(); DataOutputStream outStream = new DataOutputStream(byteOutput); PaintingBlob blobOut = BlobEntry.create(1, PaintingBlob.class); blobOut.setArt("artistic"); blobOut.setDirection((byte) 5); blobOut.write(outStream); DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(byteOutput.toByteArray())); PaintingBlob blobIn = BlobEntry.create(1, PaintingBlob.class); blobIn.read(inputStream); Assert.assertEquals(blobOut, blobIn); } }
Code with Pattern(s):	`class FlushStreamBeforeGetBytes { byte[] pattern() throws Exception { ByteArrayOutputStream byteOutput = new ByteArrayOutputStream(); DataOutputStream outStream = new DataOutputStream(byteOutput); PaintingBlob blobOut = BlobEntry.create(1, PaintingBlob.class); blobOut.setArt("artistic"); blobOut.setDirection((byte) 5); blobOut.write(outStream); outStream.close(); return byteOutput.toByteArray(); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Pattern Support	Present Properties
Yes	0	0.98	26.0	DataOutputStream.<init> (OutputStream) : void @ (0) < DataOutputStream.close () : void @ (0) PaintingBlob.write (DataOutput) : void @ (1) < EXC(IOException): DataOutputStream.close () : void @ (0) DataOutputStream.<init> (OutputStream) : void @ (0) < EXC(IOException): DataOutputStream.close () : void @ (0) PaintingBlob.write (DataOutput) : void @ (1) < DataOutputStream.close () : void @ (0)	50	RETVAL: BlobEntry.create (int, Class) : BlobEntry < PaintingBlob.setDirection (byte) : void @ (0) ByteArrayOutputStream.<init> () : void @ (0) < ByteArrayOutputStream.toByteArray () : byte[] @ (0) DataOutputStream.<init> (OutputStream) : void @ (0) < PaintingBlob.write (DataOutput) : void @ (1) PaintingBlob.setDirection (byte) : void @ (0) < PaintingBlob.write (DataOutput) : void @ (0) CAST: PaintingBlob < PaintingBlob.write (DataOutput) : void @ (0) CAST: PaintingBlob < PaintingBlob.setDirection (byte) : void @ (0) RETVAL: BlobEntry.create (int, Class) : BlobEntry < PaintingBlob.setArt (String) : void @ (0) PaintingBlob.setArt (String) : void @ (0) < PaintingBlob.write (DataOutput) : void @ (0) ByteArrayOutputStream.<init> () : void @ (0) < DataOutputStream.<init> (OutputStream) : void @ (1) PaintingBlob.setArt (String) : void @ (0) < PaintingBlob.setDirection (byte) : void @ (0) DataOutputStream.<init> (OutputStream) : void @ (1) < ByteArrayOutputStream.toByteArray () : byte[] @ (0) CAST: PaintingBlob < PaintingBlob.setArt (String) : void @ (0) RETVAL: BlobEntry.create (int, Class) : BlobEntry < PaintingBlob.write (DataOutput) : void @ (0) RETVAL: BlobEntry.create (int, Class) : BlobEntry < CAST: PaintingBlob

Reviewer Name:	sven
Comment: