Review

Detector:	Jadet
Target:	project ' mqtt ' version f438425
Misuse:	misuse ' 389 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance, it is recommended to flush or close the DataOutputStream before invoking the underlying instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for example here. This pull request adds a flush method before calling toByteArray().
Fix Description:	(see diff)
Violation Types:	missing/call
In File:	org/eclipse/paho/client/mqttv3/internal/wire/MqttSubscribe.java
In Method:	getPayload()
Code with Misuse:	`class MqttSubscribe { public byte[] getPayload() throws MqttException { try { ByteArrayOutputStream baos = new ByteArrayOutputStream(); DataOutputStream dos = new DataOutputStream(baos); for (int i=0; i<names.length; i++) { encodeUTF8(dos,names[i]); dos.writeByte(qos[i]); } return baos.toByteArray(); } catch (IOException ex) { throw new MqttException(ex); } } }`
Code with Pattern(s):	`class FlushStreamWithByteObjectBeforeGetBytes { byte[] pattern(byte b) throws IOException { ByteArrayOutputStream baos = new ByteArrayOutputStream(); DataOutputStream dos = new DataOutputStream(baos); dos.writeByte(b); dos.flush(); return baos.toByteArray(); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Pattern Support	Present Properties
?	1	0.98	27.21	DataOutputStream.<init> (OutputStream) : void @ (0) < DataOutputStream.flush () : void @ (0) DataOutputStream.<init> (OutputStream) : void @ (0) < EXC(IOException): DataOutputStream.flush () : void @ (0)	51	ByteArrayOutputStream.<init> () : void @ (0) < ByteArrayOutputStream.toByteArray () : byte[] @ (0) ByteArrayOutputStream.<init> () : void @ (0) < DataOutputStream.<init> (OutputStream) : void @ (1) DataOutputStream.<init> (OutputStream) : void @ (1) < ByteArrayOutputStream.toByteArray () : byte[] @ (0)
?	2	0.98	27.17	DataOutputStream.<init> (OutputStream) : void @ (0) < DataOutputStream.flush () : void @ (0) DataOutputStream.writeByte (int) : void @ (0) < EXC(IOException): DataOutputStream.flush () : void @ (0) DataOutputStream.<init> (OutputStream) : void @ (0) < EXC(IOException): DataOutputStream.flush () : void @ (0) DataOutputStream.writeByte (int) : void @ (0) < DataOutputStream.flush () : void @ (0)	50	DataOutputStream.<init> (OutputStream) : void @ (0) < EXC(IOException): DataOutputStream.writeByte (int) : void @ (0) ByteArrayOutputStream.<init> () : void @ (0) < ByteArrayOutputStream.toByteArray () : byte[] @ (0) ByteArrayOutputStream.<init> () : void @ (0) < DataOutputStream.<init> (OutputStream) : void @ (1) DataOutputStream.<init> (OutputStream) : void @ (0) < DataOutputStream.writeByte (int) : void @ (0) DataOutputStream.<init> (OutputStream) : void @ (1) < ByteArrayOutputStream.toByteArray () : byte[] @ (0)