Review

finding-17

server/ServerInputProcessor.java

processChangeUserRole()

class ServerInputProcessor {
	private void processChangeUserRole() throws ConnectionException {
		Connection conn = DBManager.getConnection();
		String[] userInfo = DatabaseAdmin.getUserInfo(conn, user);
		
		// check if user is SA
		if (userInfo[3].equals("sa")) {
			List<String[]> changeableUsers = DatabaseAdmin.getOtherUsersInGroup(conn, user);
	
			boolean userChangeable = false;
			String toChange = "";
			String role = "";
			String command = "";
	
			while (!userChangeable) {
				command += SocialNetworkAdmin.displayRoleChange(changeableUsers);
				sendWithNonce(command);
	
				toChange = recvWithNonce().toLowerCase();
				if (toChange.equals("cancel")) {
					sendWithNonce(CANCEL);
					return;
				}
				for (String[] u : changeableUsers) {
					if (toChange.equals(u[0])) {
						if (u[1].equals("admin")) {
							role = "member";
						} else {
							role = "admin";
						}
						userChangeable = true;
						break;
					}
				}
				if (!userChangeable) {
					command = "print Cannot change role for " + toChange + ";";
				}
			}
	
			// toChange is changeable
			command = SocialNetworkAdmin.changeRole(conn, toChange, role);
			sendWithNonce(command);
		} else {
			sendWithNonce(INVALID + HELP);
		}
		DBManager.closeConnection(conn);
	}

}