Review

finding-5

org/apache/commons/bcel6/verifier/structurals/InstConstraintVisitor.java

visitFieldInstruction(FieldInstruction)

class InstConstraintVisitor {
    /**
     * Ensures the general preconditions of a FieldInstruction instance.
     */
     @Override
    public void visitFieldInstruction(FieldInstruction o){
         // visitLoadClass(o) has been called before: Every FieldOrMethod
         // implements LoadClass.
         // visitCPInstruction(o) has been called before.
        // A FieldInstruction may be: GETFIELD, GETSTATIC, PUTFIELD, PUTSTATIC
            Constant c = cpg.getConstant(o.getIndex());
            if (!(c instanceof ConstantFieldref)){
                constraintViolated(o,
                    "Index '"+o.getIndex()+"' should refer to a CONSTANT_Fieldref_info structure, but refers to '"+c+"'.");
            }
            // the o.getClassType(cpg) type has passed pass 2; see visitLoadClass(o).
            Type t = o.getType(cpg);
            if (t instanceof ObjectType){
                String name = ((ObjectType)t).getClassName();
                Verifier v = VerifierFactory.getVerifier( name );
                VerificationResult vr = v.doPass2();
                if (vr.getStatus() != VerificationResult.VERIFIED_OK){
                    constraintViolated(o, "Class '"+name+"' is referenced, but cannot be loaded and resolved: '"+vr+"'.");
                }
            }
     }

}