Review

Detector:

Jadet

Target:

project '

chensun

' version

cf23b99

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-6
In File:	database/DatabaseAdmin.java
In Method:	getAdmins(Connection)
Code with Finding:	class DatabaseAdmin { public static List<String> getAdmins(Connection conn) { List<String> admins = new ArrayList<String>(); String query = "SELECT username FROM main.users " + "WHERE role = 'admin' OR role = 'sa'"; Statement stmt = null; ResultSet result = null; try { stmt = conn.createStatement(); result = stmt.executeQuery(query); while (result.next()) { admins.add(result.getString("username")); } } catch (SQLException e) { admins = null; } finally { DBManager.closeResultSet(result); DBManager.closeStatement(stmt); } return admins; } }

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Pattern Support	Present Properties	Violation Types
?	6	0.9	8.45	RETVAL: Connection.prepareStatement (String) : PreparedStatement < DBManager.closePreparedStatement (PreparedStatement) : void @ (1)	28	EXC(SQLException): ResultSet.getString (String) : String @ (0) < DBManager.closeResultSet (ResultSet) : void @ (1) ResultSet.next () : boolean @ (0) < EXC(SQLException): ResultSet.getString (String) : String @ (0) ResultSet.getString (String) : String @ (0) < DBManager.closeResultSet (ResultSet) : void @ (1) ResultSet.next () : boolean @ (0) < DBManager.closeResultSet (ResultSet) : void @ (1) EXC(SQLException): ResultSet.next () : boolean @ (0) < DBManager.closeResultSet (ResultSet) : void @ (1) ResultSet.next () : boolean @ (0) < ResultSet.getString (String) : String @ (0)