Review

Detector:

Tikanga

Target:

project '

asterisk-java

' version

304421c

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-0
In File:	org/asteriskjava/manager/action/OriginateAction.java
In Method:	setCodecs(List)
Code with Finding:	`class OriginateAction { /** * Sets the codecs to use for the call.<p> * Available since Asterisk 1.6. * * @param codecs list of codecs to use for the call. * @since 1.0.0 */ public void setCodecs(List<String> codecs) { if (codecs == null \|\| codecs.isEmpty()) { this.codecs = null; return; } Iterator<String> iter = codecs.iterator(); StringBuffer buffer = new StringBuffer(iter.next()); while (iter.hasNext()) { buffer.append(",").append(iter.next()); } this.codecs = buffer.toString(); } }`

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
?	0	0.92	8.21	AG (RETVAL: List.iterator () : Iterator => AX AF Iterator.hasNext () : boolean @ (0)) AF Iterator.hasNext () : boolean @ (0)	AF Iterator.next () : Object @ (0) AG (RETVAL: List.iterator () : Iterator => AX AF Iterator.next () : Object @ (0)) AG (Iterator.hasNext () : boolean @ (0) => EX EF Iterator.next () : Object @ (0)) AF RETVAL: List.iterator () : Iterator AG (Iterator.next () : Object @ (0) => EX EF Iterator.next () : Object @ (0)) AG (RETVAL: List.iterator () : Iterator => EX EF Iterator.next () : Object @ (0)) AG (Iterator.next () : Object @ (0) => EX EF Iterator.hasNext () : boolean @ (0)) EF Iterator.hasNext () : boolean @ (0) AG (Iterator.hasNext () : boolean @ (0) => EX EF Iterator.hasNext () : boolean @ (0)) EF Iterator.next () : Object @ (0) AG (Iterator.hasNext () : boolean @ (0) => AX AF Iterator.next () : Object @ (0)) EF RETVAL: List.iterator () : Iterator AG (RETVAL: List.iterator () : Iterator => EX EF Iterator.hasNext () : boolean @ (0))	ConfigFileImpl.getCategories () : Map : var #9@Iterator (line 60) Category.rawFormat (StringBuilder) : StringBuilder : var #13@Iterator (line 120) Category.format () : String : var #4@Iterator (line 97)