Review

Detector:

Tikanga

Target:

project '

jigsaw

' version

205

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-11
In File:	org/w3c/www/http/HttpParamList.java
In Method:	parse()
Code with Finding:	class HttpParamList { /** * parse. * @exception HttpParserException if parsing failed. */ protected void parse() throws HttpParserException { ParseState ps = new ParseState(roff, rlen); this.params = new ArrayDictionary(4, 4); ps.prepare(); // Parameters parsing ParseState it = new ParseState(); it.separator = (byte) '='; ps.separator = (byte) ','; while (HttpParser.nextItem(raw, ps) >= 0 ) { // Get the param name: it.prepare(ps); if (HttpParser.nextItem(raw, it) < 0) error("Invalid param list: bad param name."); String key = it.toString(raw, true); // Get the param value: it.prepare(); if ( HttpParser.nextItem(raw, it) < 0) error("Invalid param list: no param value."); it.ioff = it.start; HttpParser.unquote(raw, it); params.put(key, it.toString(raw)); ps.prepare(); } } }

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
No	11	0.96	10.2	AG (ParseState.<init> (int, int) : void @ (0) => AX AF HttpParser.nextItem (byte[], ParseState) : int @ (2)) AF HttpParser.nextItem (byte[], ParseState) : int @ (2)	AG (HttpParser.nextItem (byte[], ParseState) : int @ (2) => AX AF ParseState.prepare () : void @ (0)) AF ParseState.prepare () : void @ (0) EF ParseState.<init> (int, int) : void @ (0) EF ParseState.prepare () : void @ (0) AG (ParseState.<init> (int, int) : void @ (0) => AX AF ParseState.prepare () : void @ (0)) AG (HttpParser.nextItem (byte[], ParseState) : int @ (2) => EX EF ParseState.prepare () : void @ (0)) AF ParseState.<init> (int, int) : void @ (0) AG (ParseState.<init> (int, int) : void @ (0) => EX EF HttpParser.nextItem (byte[], ParseState) : int @ (2)) EF HttpParser.nextItem (byte[], ParseState) : int @ (2) AG (ParseState.<init> (int, int) : void @ (0) => EX EF ParseState.prepare () : void @ (0))	HttpAccept.parse () : void : var #1@ParseState (line 40) HttpAcceptCharset.parse () : void : var #1@ParseState (line 20) HttpAcceptCharsetList.parse () : void : var #2@ParseState (line 15)

Reviewer Name:	sven
Comment: