Review

Detector:

Tikanga

Target:

project '

testng

' version

677302c

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-1
In File:	org/testng/reporters/EmailableReporter2.java
In Method:	groupResults(Set)
Code with Finding:	class EmailableReporter2.TestResult { /** * Groups test results by method and then by class. */ protected List<ClassResult> groupResults(Set<ITestResult> results) { List<ClassResult> classResults = Lists.newArrayList(); if (!results.isEmpty()) { List<MethodResult> resultsPerClass = Lists.newArrayList(); List<ITestResult> resultsPerMethod = Lists.newArrayList(); List<ITestResult> resultsList = Lists.newArrayList(results); Collections.sort(resultsList, RESULT_COMPARATOR); Iterator<ITestResult> resultsIterator = resultsList.iterator(); assert resultsIterator.hasNext(); ITestResult result = resultsIterator.next(); resultsPerMethod.add(result); String previousClassName = result.getTestClass().getName(); String previousMethodName = result.getMethod().getMethodName(); while (resultsIterator.hasNext()) { result = resultsIterator.next(); String className = result.getTestClass().getName(); if (!previousClassName.equals(className)) { // Different class implies different method assert !resultsPerMethod.isEmpty(); resultsPerClass.add(new MethodResult(resultsPerMethod)); resultsPerMethod = Lists.newArrayList(); assert !resultsPerClass.isEmpty(); classResults.add(new ClassResult(previousClassName, resultsPerClass)); resultsPerClass = Lists.newArrayList(); previousClassName = className; previousMethodName = result.getMethod().getMethodName(); } else { String methodName = result.getMethod().getMethodName(); if (!previousMethodName.equals(methodName)) { assert !resultsPerMethod.isEmpty(); resultsPerClass.add(new MethodResult(resultsPerMethod)); resultsPerMethod = Lists.newArrayList(); previousMethodName = methodName; } } resultsPerMethod.add(result); } assert !resultsPerMethod.isEmpty(); resultsPerClass.add(new MethodResult(resultsPerMethod)); assert !resultsPerClass.isEmpty(); classResults.add(new ClassResult(previousClassName, resultsPerClass)); } return classResults; } }

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
?	1	0.99	55.67	AG (RETVAL: List.iterator () : Iterator => AX AF Iterator.hasNext () : boolean @ (0)) AF Iterator.hasNext () : boolean @ (0)	AF Iterator.next () : Object @ (0) AG (RETVAL: List.iterator () : Iterator => AX AF Iterator.next () : Object @ (0)) AG (Iterator.hasNext () : boolean @ (0) => EX EF Iterator.next () : Object @ (0)) AF RETVAL: List.iterator () : Iterator AG (Iterator.next () : Object @ (0) => EX EF Iterator.next () : Object @ (0)) AG (RETVAL: List.iterator () : Iterator => EX EF Iterator.next () : Object @ (0)) AG (Iterator.next () : Object @ (0) => EX EF Iterator.hasNext () : boolean @ (0)) EF Iterator.hasNext () : boolean @ (0) AG (Iterator.hasNext () : boolean @ (0) => EX EF Iterator.hasNext () : boolean @ (0)) EF Iterator.next () : Object @ (0) AG (Iterator.hasNext () : boolean @ (0) => AX AF Iterator.next () : Object @ (0)) EF RETVAL: List.iterator () : Iterator AG (RETVAL: List.iterator () : Iterator => EX EF Iterator.hasNext () : boolean @ (0))	ClassMethodMap.removeAndCheckIfLast (ITestNGMethod, Object) : boolean : var #5@Iterator (line 55) ClassMethodMap.<init> (List, XmlMethodSelector) : void : var #4@Iterator (line 27) Converter.findAllSuites (Collection, Set) : void : var #4@Iterator (line 45)