Review

On line 176, List.get(0) is invoked without prior check of that there is at least one element in the list (the loop that adds elements might be skipped, if an empty list is passed as a parameter).

• missing/condition/value_or_state

com/google/javascript/jscomp/deps/SortedDependencies.java

cycleToString(List)

class SortedDependencies {
  /**
   * @param cycle A cycle in reverse-dependency order.
   */
  private String cycleToString(List<INPUT> cycle) {
    List<String> symbols = Lists.newArrayList();
    for (int i = cycle.size() - 1; i >= 0; i--) {
      symbols.add(cycle.get(i).getProvides().iterator().next());
    }
    symbols.add(symbols.get(0));
    return Joiner.on(" -> ").join(symbols);
  }

}