Review

In line 206 of AsyncAgiEvent, it uses ISO-8859-1 encoding scheme but according to Oracle Java 7 API specification, the World Wide Web Consortium Recommendation states that UTF-8 should be used. Not doing so may introduce incompatibilities.
This pull request adds a fix by using UTF-8 encoding.

• missing/condition/value_or_state

org/asteriskjava/manager/event/AsyncAgiEvent.java

decode(String)

class AsyncAgiEvent {
    /**
     * Returns the raw AGI environment similar to the AGI request for FastAGI.<p>
     * This property is only available for the "Start" sub event.<p>
     * The environment is passed in multiple lines (separated by "\n"). Each line is URL encoded
     * and contains a key and a value. The environment ends with two newline characters ("\n\n").<p>
     * Example:
     * <pre>
     * ...
     * agi_channel%3a%20IAX2%2fpbx0-1
     * agi_language%3a%20de
     * agi_type%3a%20IAX2
     * agi_uniqueid%3a%201201838738.19
     * agi_version%3a%201.6.0-beta1
     * ...
     * </pre>
     *
     * @return the URL encoded AGI environment.
     */
    public String getEnv()
    {
        return env;
    }

}

class AsyncAgiEvent {
    private List<String> decode(String s)
    {
        final List<String> result = new ArrayList<String>();

        if (s == null)
        {
            return result;
        }

        try
        {
            final String decodedString = URLDecoder.decode(s, "ISO-8859-1");
            result.addAll(Arrays.asList(decodedString.split("\n")));
        }
        catch (UnsupportedEncodingException e)
        {
            // won't happen as JDK ships with ISO-8859-1
            throw new RuntimeException("This JDK does not support ISO-8859-1 encoding", e);
        }

        return result;
    }

}