Review

Detector:	MuDetect
Target:	project ' closure ' version 319
Misuse:	misuse ' dmmc-1023 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/deps/SortedDependencies.java
In Method:	cycleToString(List)
Code with Misuse:	`class SortedDependencies { /** * @param cycle A cycle in reverse-dependency order. */ private String cycleToString(List<INPUT> cycle) { List<String> symbols = Lists.newArrayList(); for (int i = cycle.size() - 1; i >= 0; i--) { symbols.add(cycle.get(i).getProvides().iterator().next()); } symbols.add(symbols.get(0)); return Joiner.on(" -> ").join(symbols); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
Yes	16	0.13333333333333333	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(violation support = 1 / 6)	closure/319/build/src/com/google/javascript/jscomp/ControlFlowAnalysis.java#process(Node, Node) closure/319/build/src/com/google/javascript/jscomp/SpecializeModule.java#addDummyVarDeclarationsToInitialModule(JSModule) closure/319/build/src/com/google/javascript/jscomp/JsMessageVisitor.java#extractFromCallNode(Builder, Node) closure/319/build/src/com/google/javascript/jscomp/TightenTypes.java#getAssignments(ConcreteScope) closure/319/build/src/com/google/javascript/jscomp/MustBeReachingVariableDef.java#addToDefIfLocal(String, Node, Node, MustDef)	387
No	1475	0.00015101177891875566	(overlap = 3.00 / 7.00)(pattern support = 12 / 387)(violation support = 1 / 88)	closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap) closure/319/build/src/com/google/javascript/jscomp/graph/Graph.java#pushAnnotations(Deque, Collection) closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode) closure/319/build/src/com/google/javascript/rhino/jstype/PrototypeObjectType.java#toString() closure/319/build/src/com/google/javascript/jscomp/NameAnalyzer.java#getSideEffectNodes(Node)	12

Reviewer Name:	sven
Comment: