Review

Detector:	MuDetect
Target:	project ' closure ' version 319
Misuse:	misuse ' mudetect-17 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check that the iterator has more elements.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/TightenTypes.java
In Method:	getImplicitActionsFromCall(Node, JSType)
Code with Misuse:	class TightenTypes.CreateScope { private Collection<Action> getImplicitActionsFromCall( Node n, JSType recvType) { Node receiver = n.getFirstChild(); if (recvType instanceof UnionType) { List<Action> actions = Lists.newArrayList(); for (JSType alt : ((UnionType) recvType).getAlternates()) { actions.addAll(getImplicitActionsFromCall(n, alt)); } return actions; } else if (!(recvType instanceof FunctionType)) { return Lists.<Action>newArrayList(); } ObjectType objType = ObjectType.cast( getJSType(receiver.getFirstChild()) .restrictByNotNullOrUndefined()); String prop = receiver.getLastChild().getString(); if (objType != null && (objType.isPropertyInExterns(prop)) && ((FunctionType) recvType).getParameters() != null) { List<Action> actions = Lists.newArrayList(); // Look for a function type in the argument list. Iterator<Node> paramIter = ((FunctionType) recvType).getParameters().iterator(); Iterator<Node> argumentIter = n.children().iterator(); argumentIter.next(); // Skip the function name. while (paramIter.hasNext() && argumentIter.hasNext()) { Node arg = argumentIter.next(); Node param = paramIter.next(); if (arg.getJSType() instanceof FunctionType) { actions.addAll(getImplicitActionsFromArgument( arg, ((FunctionType) arg.getJSType()).getTypeOfThis(), param.getJSType())); } } return actions; } return Lists.<Action>newArrayList(); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
Yes	11	0.15714285714285714	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 5)	closure/319/build/src/com/google/javascript/jscomp/ControlFlowAnalysis.java#process(Node, Node) closure/319/build/src/com/google/javascript/jscomp/SpecializeModule.java#addDummyVarDeclarationsToInitialModule(JSModule) closure/319/build/src/com/google/javascript/jscomp/JsMessageVisitor.java#extractFromCallNode(Builder, Node) closure/319/build/src/com/google/javascript/jscomp/TightenTypes.java#getAssignments(ConcreteScope) closure/319/build/src/com/google/javascript/jscomp/MustBeReachingVariableDef.java#addToDefIfLocal(String, Node, Node, MustDef)	387
No	340	0.001937984496124031	(overlap = 6.00 / 8.00)(pattern support = 29 / 387)(violation support = 1 / 29)	closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap) closure/319/build/src/com/google/javascript/jscomp/CommandLineRunner.java#getDefaultExterns() closure/319/build/src/com/google/javascript/jscomp/DefaultPassConfig.java#getMainOptimizationLoop() closure/319/build/src/com/google/javascript/jscomp/graph/LinkedUndirectedGraph.java#getNeighborNodes(N) closure/319/build/src/com/google/javascript/jscomp/AliasKeywords.java#createAliasSpecifications()	29
No	341	0.001937984496124031	(overlap = 6.00 / 8.00)(pattern support = 29 / 387)(violation support = 1 / 29)	closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap) closure/319/build/src/com/google/javascript/jscomp/CommandLineRunner.java#getDefaultExterns() closure/319/build/src/com/google/javascript/jscomp/DefaultPassConfig.java#getMainOptimizationLoop() closure/319/build/src/com/google/javascript/jscomp/graph/LinkedUndirectedGraph.java#getNeighborNodes(N) closure/319/build/src/com/google/javascript/jscomp/AliasKeywords.java#createAliasSpecifications()	29
No	342	0.001937984496124031	(overlap = 6.00 / 8.00)(pattern support = 29 / 387)(violation support = 1 / 29)	closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap) closure/319/build/src/com/google/javascript/jscomp/CommandLineRunner.java#getDefaultExterns() closure/319/build/src/com/google/javascript/jscomp/DefaultPassConfig.java#getMainOptimizationLoop() closure/319/build/src/com/google/javascript/jscomp/graph/LinkedUndirectedGraph.java#getNeighborNodes(N) closure/319/build/src/com/google/javascript/jscomp/AliasKeywords.java#createAliasSpecifications()	29
No	343	0.001937984496124031	(overlap = 6.00 / 8.00)(pattern support = 29 / 387)(violation support = 1 / 29)	closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap) closure/319/build/src/com/google/javascript/jscomp/CommandLineRunner.java#getDefaultExterns() closure/319/build/src/com/google/javascript/jscomp/DefaultPassConfig.java#getMainOptimizationLoop() closure/319/build/src/com/google/javascript/jscomp/graph/LinkedUndirectedGraph.java#getNeighborNodes(N) closure/319/build/src/com/google/javascript/jscomp/AliasKeywords.java#createAliasSpecifications()	29

Reviewer Name:	sven
Comment: