Review

Detector:	MuDetect
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-15 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	StringTokenizer.nextToken() is invoked without prior check of hasMoreTokens(). This usage may be safe from context, since the tokenized value is an RBG color value which has a known number of tokens. However, the usage is unsafe against invalid values and we, therefore, consider it a misuse.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/SimpleBookmark.java
In Method:	iterateOutlines(PdfWriter, PdfIndirectReference, List, boolean)
Code with Misuse:	class SimpleBookmark { @SuppressWarnings("unchecked") public static Object[] iterateOutlines(PdfWriter writer, PdfIndirectReference parent, List<HashMap<String, Object>> kids, boolean namedAsNames) throws IOException { PdfIndirectReference refs[] = new PdfIndirectReference[kids.size()]; for (int k = 0; k < refs.length; ++k) refs[k] = writer.getPdfIndirectReference(); int ptr = 0; int count = 0; for (Iterator<HashMap<String, Object>> it = kids.listIterator(); it.hasNext(); ++ptr) { HashMap<String, Object> map = it.next(); Object lower[] = null; List<HashMap<String, Object>> subKid = (List<HashMap<String, Object>>)map.get("Kids"); if (subKid != null && !subKid.isEmpty()) lower = iterateOutlines(writer, refs[ptr], subKid, namedAsNames); PdfDictionary outline = new PdfDictionary(); ++count; if (lower != null) { outline.put(PdfName.FIRST, (PdfIndirectReference)lower[0]); outline.put(PdfName.LAST, (PdfIndirectReference)lower[1]); int n = ((Integer)lower[2]).intValue(); if ("false".equals(map.get("Open"))) { outline.put(PdfName.COUNT, new PdfNumber(-n)); } else { outline.put(PdfName.COUNT, new PdfNumber(n)); count += n; } } outline.put(PdfName.PARENT, parent); if (ptr > 0) outline.put(PdfName.PREV, refs[ptr - 1]); if (ptr < refs.length - 1) outline.put(PdfName.NEXT, refs[ptr + 1]); outline.put(PdfName.TITLE, new PdfString((String)map.get("Title"), PdfObject.TEXT_UNICODE)); String color = (String)map.get("Color"); if (color != null) { try { PdfArray arr = new PdfArray(); StringTokenizer tk = new StringTokenizer(color); for (int k = 0; k < 3; ++k) { float f = Float.parseFloat(tk.nextToken()); if (f < 0) f = 0; if (f > 1) f = 1; arr.add(new PdfNumber(f)); } outline.put(PdfName.C, arr); } catch(Exception e){} //in case it's malformed } String style = (String)map.get("Style"); if (style != null) { style = style.toLowerCase(); int bits = 0; if (style.indexOf("italic") >= 0) bits \|= 1; if (style.indexOf("bold") >= 0) bits \|= 2; if (bits != 0) outline.put(PdfName.F, new PdfNumber(bits)); } createOutlineAction(outline, map, writer, namedAsNames); writer.addToBody(outline, refs[ptr]); } return new Object[]{refs[0], refs[refs.length - 1], Integer.valueOf(count)}; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
Yes	150	0.025684931506849314	(overlap = 3.00 / 4.00)(pattern support = 10 / 73)(violation support = 1 / 4)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/BaseFont.java#createEncoding() itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#mergeField(String, Item) itext/5091/build/src/main/java/com/itextpdf/text/html/HtmlUtilities.java#parseAttributes(String) itext/5091/build/src/main/java/com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java/com/itextpdf/text/pdf/FdfWriter.java#getField(String)	10
No	490	0.004466944609886837	(overlap = 15.00 / 20.00)(pattern support = 10 / 73)(violation support = 1 / 23)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int) itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int)	10
No	491	0.004466944609886837	(overlap = 15.00 / 20.00)(pattern support = 10 / 73)(violation support = 1 / 23)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int) itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int)	10		The graph contained more than 25 nodes and is likely unreadable. Skipping generation.
No	492	0.004466944609886837	(overlap = 15.00 / 20.00)(pattern support = 10 / 73)(violation support = 1 / 23)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int) itext/5091/build/src/main/java/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int)	10		The graph contained more than 25 nodes and is likely unreadable. Skipping generation.
No	826	0.0023316817254444766	(overlap = 3.00 / 6.00)(pattern support = 16 / 73)(violation support = 1 / 47)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfReader.java#getStreamBytesRaw(PRStream, RandomAccessFileOrArray) itext/5091/build/src/main/java/com/itextpdf/text/pdf/TrueTypeFont.java#getAllNames() itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfCopy.java#addAnnotation(PdfAnnotation) itext/5091/build/src/main/java/com/itextpdf/text/pdf/qrcode/Encoder.java#interleaveWithECBytes(BitVector, int, int, int, BitVector) itext/5091/build/src/main/java/com/itextpdf/text/pdf/TrueTypeFont.java#getNames(int)	16
No	897	0.0023131458783946166	(overlap = 11.00 / 12.00)(pattern support = 28 / 73)(violation support = 1 / 152)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfWriter.java#add(PdfPage, PdfContents) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfAnnotation.java#createSquareCircle(PdfWriter, Rectangle, String, boolean) itext/5091/build/src/main/java/com/itextpdf/text/pdf/internal/PdfXConformanceImp.java#completeInfoDictionary(PdfDictionary) itext/5091/build/src/main/java/com/itextpdf/text/pdf/CJKFont.java#getCIDFont(PdfIndirectReference, IntHashtable) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfCopy.java#addAnnotation(PdfAnnotation)	28		The graph contained more than 25 nodes and is likely unreadable. Skipping generation.
No	1283	0.0001962286718122185	(overlap = 7.00 / 10.00)(pattern support = 15 / 73)(violation support = 1 / 733)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfAction.java#setOCGstate(ArrayList, boolean) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfDocument.java#setXmpMetadata(byte[]) itext/5091/build/src/main/java/com/itextpdf/text/pdf/codec/BmpImage.java#indexedModel(byte, int, int)	15		The graph contained more than 25 nodes and is likely unreadable. Skipping generation.
No	1284	0.0001962286718122185	(overlap = 7.00 / 10.00)(pattern support = 15 / 73)(violation support = 1 / 733)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfAction.java#setOCGstate(ArrayList, boolean) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfDocument.java#setXmpMetadata(byte[]) itext/5091/build/src/main/java/com/itextpdf/text/pdf/codec/BmpImage.java#indexedModel(byte, int, int)	15

Reviewer Name:	hoan
Comment: