Review

Detector:	MuDetect
Target:	project ' itext ' version 5091
Misuse:	misuse ' mudetect-10 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	On line 244, a `PdfObject` is fetched from a `PdfArray`. Since the array may contain a `null` value, the object should be checked before it is used.
Fix Description:
Violation Types:	missing/condition/null_check
In File:	com/itextpdf/text/pdf/SimpleBookmark.java
In Method:	makeBookmarkParam(PdfArray, IntHashtable)
Code with Misuse:	class SimpleBookmark { private static String makeBookmarkParam(PdfArray dest, IntHashtable pages) { StringBuffer s = new StringBuffer(); PdfObject obj = dest.getPdfObject(0); if (obj.isNumber()) s.append(((PdfNumber)obj).intValue() + 1); else s.append(pages.get(getNumber((PdfIndirectReference)obj))); //changed by ujihara 2004-06-13 s.append(' ').append(dest.getPdfObject(1).toString().substring(1)); for (int k = 2; k < dest.size(); ++k) s.append(' ').append(dest.getPdfObject(k).toString()); return s.toString(); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
Yes	10	0.12644889357218125	(overlap = 12.00 / 13.00)(pattern support = 10 / 73)(violation support = 1 / 1)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfSignatureAppearance.java#preClose(HashMap) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfReader.java#readXrefSection() itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#mergeField(String, Item) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfEFStream.java#toPdf(PdfWriter, OutputStream) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfReader.java#decodePredictor(byte, PdfObject)	10
No	1130	0.0008670019074041962	(overlap = 3.00 / 6.00)(pattern support = 10 / 73)(violation support = 1 / 79)	itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfWriter.java#addASEvent(PdfName, PdfName) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfWriter.java#addOCGRadioGroup(ArrayList) itext/5091/build/src/main/java/com/itextpdf/text/pdf/LtvVerification.java#outputDss(PdfDictionary, PdfDictionary, PdfArray, PdfArray, PdfArray) itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#createAcroForms() itext/5091/build/src/main/java/com/itextpdf/text/pdf/PdfDocument.java#addNames(TreeMap, HashMap, HashMap, PdfWriter)	10

Reviewer Name:	hoan
Comment: