Review

Detector:	MuDetectXP
Target:	project ' asterisk-java ' version 41461b4
Misuse:	misuse ' 194 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	`RtcpReceivedEvent.java` calls `java.lang.long.parseLong` without first checking whether the argument parses. This lead to an uncaught `NumberFormatException`: Oracle Java 7 API specification. This pull request adds a check with a more helpful exception message. Kindly let me know if you want me to change the message.
Fix Description:	(see diff)
Violation Types:	missing/exception_handling
In File:	org/asteriskjava/manager/event/RtcpReceivedEvent.java
In Method:	setPt(String)
Code with Misuse:	`class RtcpReceivedEvent { public void setPt(String ptString) { // Format is "PT: %d(%s)" if (ptString == null \|\| ptString.length() == 0) { this.pt = null; return; } if (ptString.indexOf('(') > 0) { this.pt = Long.parseLong(ptString.substring(0, ptString.indexOf('('))); } else { this.pt = Long.parseLong(ptString); } } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	0	0.3	(overlap = 3.00 / 5.00)(pattern support = 12 / 12)(violation support = 1 / 2)	Sankore/Editeur_Sankore---LENUOS-/sources/lenuos/editor/src/com/paraschool/viewer/client/DefaultXMLProjectSerializer.java#getResource(Element) SiteView/com.siteview.mde/com.siteview.mde.core/src/com/siteview/mde/internal/core/converter/MonitorConverter.java#upToDate(File, File, byte) SiteView/com.siteview.mde/com.siteview.mde.ui/src/com/siteview/mde/internal/ui/editor/feature/DataDetailsSection.java#getLong(String) Oogzy/oogzy-commons/src/main/java/com/oogzy/lib/server/util/TextUtils.java#getLong(String) Sankore/Editeur_Sankore---LENUOS-/sources/lenuos/editor/src/com/paraschool/editor/client/view/EditProjectFormView.java#displayError(int, String)	12
?	1	0.3	(overlap = 3.00 / 5.00)(pattern support = 12 / 12)(violation support = 1 / 2)	Sankore/Editeur_Sankore---LENUOS-/sources/lenuos/editor/src/com/paraschool/viewer/client/DefaultXMLProjectSerializer.java#getResource(Element) SiteView/com.siteview.mde/com.siteview.mde.core/src/com/siteview/mde/internal/core/converter/MonitorConverter.java#upToDate(File, File, byte) SiteView/com.siteview.mde/com.siteview.mde.ui/src/com/siteview/mde/internal/ui/editor/feature/DataDetailsSection.java#getLong(String) Oogzy/oogzy-commons/src/main/java/com/oogzy/lib/server/util/TextUtils.java#getLong(String) Sankore/Editeur_Sankore---LENUOS-/sources/lenuos/editor/src/com/paraschool/editor/client/view/EditProjectFormView.java#displayError(int, String)	12