Review

Detector:	MuDetectXP
Target:	project ' chensun ' version cf23b99
Misuse:	misuse ' grouminer-3 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	The `ResultSet` fetched in line 644 is never closed. (This is the same findings as `jadet-4`)
Fix Description:
Violation Types:	missing/call
In File:	database/SocialNetworkDatabasePosts.java
In Method:	getPost(Connection, String, String, String, int)
Code with Misuse:	class SocialNetworkDatabasePosts { /** Gets a post from the designated board and region * with the given post number. * ASSUMES that the board, region, and post are all valid. / public static String getPost(Connection conn, String username, String boardName, String regionName, int postNum) { String getOriginalPost = ""; String getReplies = ""; String postAndReplies = ""; /No joining of results because of redundancy of data returned/ if (boardName.equals("freeforall")) { getOriginalPost = "SELECT FROM freeforall.posts " + "WHERE pid = ?"; getReplies = "SELECT * FROM freeforall.replies " + "WHERE pid = ? ORDER BY dateReplied ASC"; } else { getOriginalPost = "SELECT * FROM " + boardName + ".posts " + "WHERE pid = ? AND rname = ?"; getReplies = "SELECT * FROM " + boardName + ".replies " + "WHERE pid = ? AND rname = ? ORDER BY dateReplied ASC"; } PreparedStatement originalPost = null; ResultSet postResult = null; PreparedStatement replies = null; ResultSet repliesResult = null; boolean sqlex = false; try { originalPost = conn.prepareStatement(getOriginalPost); replies = conn.prepareStatement(getReplies); originalPost.setInt(1, postNum); replies.setInt(1, postNum); if (!boardName.equals("freeforall")) { originalPost.setString(2, regionName); replies.setString(2, regionName); } postResult = originalPost.executeQuery(); if (postResult.next()) { /Only expect one post result/ //Make sure the checksum is correct if (!Arrays.equals( Hash.generateChecksum((SharedKeyCrypto.decrypt(postResult.getString("content"))).getBytes("UTF8")), CryptoUtil.decode(postResult.getString("checksum")))) { postAndReplies += "print ----- Post# " + postNum + "[" + postResult.getString("postedBy") + "]----- " + postResult.getTimestamp("datePosted").toString() + ";print \t" + "Content could not be fetched -- Integrity Failure!" + ";"; } else { postAndReplies += "print ----- Post# " + postNum + "[" + postResult.getString("postedBy") + "]----- " + postResult.getTimestamp("datePosted").toString() + ";print \t" + SharedKeyCrypto.decrypt(postResult.getString("content")) + ";"; } repliesResult = replies.executeQuery(); while (repliesResult.next()) { //Print out all replies //for each reply, make sure the checksum is correct. if(!Arrays.equals( Hash.generateChecksum((SharedKeyCrypto.decrypt(repliesResult.getString("content"))).getBytes("UTF8")), CryptoUtil.decode(repliesResult.getString("checksum")))) { postAndReplies += "print ----- Reply[" + repliesResult.getString("repliedBy") + "] ----- " + repliesResult.getTimestamp("dateReplied").toString() + ";print \t" + "Content could not be fetched -- Integrity Failure!" + ";"; } else { postAndReplies += "print ----- Reply[" + repliesResult.getString("repliedBy") + "] ----- " + repliesResult.getTimestamp("dateReplied").toString() + ";print \t" + SharedKeyCrypto.decrypt(repliesResult.getString("content")) + ";"; } } } // if there's no postResult, the post DNE. } catch (SQLException e) { e.printStackTrace(); sqlex = true; } catch (UnsupportedEncodingException e) { // This should not happen. } if (postAndReplies.equals("") && !sqlex) { return "print Error: Post does not exist. Refresh. If the problem persists, contact an admin."; } else if (sqlex) { return "print Error: Database error while querying post and replies. Contact an admin."; } else return postAndReplies; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
Yes	7	0.13636363636363635	(overlap = 18.00 / 22.00)(pattern support = 5 / 10)(violation support = 1 / 3)	ab0oo/AVRS/src/main/java/net/ab0oo/aprs/avrs/db/jdbc/JdbcAVRSDao.java#saveLatestPosition(AllPositionEntry) davidou123/java_resource/JDBC/prepareStatement_Insert.java#main(String[]) nnmm666/web_programming_A-/./page/LetsTalkMVC/src/DAO/ReplyDAO.java#sendreply(Reply) davidou123/java_resource/./JDBC/prepareStatement_Insert.java#main(String[]) nnmm666/web_programming_A-/page/LetsTalkMVC/src/DAO/KeywordDAO.java#sendkeyword(Keyword)	5		The graph contained more than 40 nodes (59) and is likely unreadable. Skipping generation.
No	8	0.13636363636363635	(overlap = 18.00 / 22.00)(pattern support = 5 / 10)(violation support = 1 / 3)	ab0oo/AVRS/src/main/java/net/ab0oo/aprs/avrs/db/jdbc/JdbcAVRSDao.java#saveLatestPosition(AllPositionEntry) davidou123/java_resource/JDBC/prepareStatement_Insert.java#main(String[]) nnmm666/web_programming_A-/./page/LetsTalkMVC/src/DAO/ReplyDAO.java#sendreply(Reply) davidou123/java_resource/./JDBC/prepareStatement_Insert.java#main(String[]) nnmm666/web_programming_A-/page/LetsTalkMVC/src/DAO/KeywordDAO.java#sendkeyword(Keyword)	5		The graph contained more than 40 nodes (42) and is likely unreadable. Skipping generation.
No	21	0.06	(overlap = 8.00 / 10.00)(pattern support = 6 / 10)(violation support = 1 / 8)	davidou123/java_resource/JDBC/prepareStatement_Insert.java#main(String[]) davidou123/java_resource/./JDBC/prepareStatement_Delete.java#main(String[]) davidou123/java_resource/./JDBC/prepareStatement_Insert.java#main(String[]) boolivar/AccountService/src/bool/server/AccountService.java#initDb() NCIP/cadsr-cgmdr-nci-uk/extensions/indexes/spatial/src/org/exist/indexing/spatial/GMLHSQLIndexWorker.java#search(DBBroker, NodeSet, Geometry, int, Connection)	6
No	22	0.06	(overlap = 8.00 / 10.00)(pattern support = 6 / 10)(violation support = 1 / 8)	davidou123/java_resource/JDBC/prepareStatement_Insert.java#main(String[]) davidou123/java_resource/./JDBC/prepareStatement_Delete.java#main(String[]) davidou123/java_resource/./JDBC/prepareStatement_Insert.java#main(String[]) boolivar/AccountService/src/bool/server/AccountService.java#initDb() NCIP/cadsr-cgmdr-nci-uk/extensions/indexes/spatial/src/org/exist/indexing/spatial/GMLHSQLIndexWorker.java#search(DBBroker, NodeSet, Geometry, int, Connection)	6		The graph contained more than 40 nodes (47) and is likely unreadable. Skipping generation.
No	27	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	28	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	29	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	30	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	31	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	32	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	33	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	34	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	35	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5
No	36	0.030303030303030304	(overlap = 10.00 / 15.00)(pattern support = 5 / 10)(violation support = 1 / 11)	davidou123/java_resource/JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getBankItems(String) sfrink/Veritas/./src/Supervisor.java#main(String[]) davidou123/java_resource/./JDBC/createStatement.java#main(String[]) horsetamer/rhs_release_gecon/./gecon/mod/alpha/misc/DatabaseMethods.java#getPlayerName(int)	5

Reviewer Name:	sarah
Comment: