Review

Detector:	MuDetectXP
Target:	project ' closure ' version 114
Misuse:	misuse ' 1 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	UnionTypeBuilder.build() returns a JSType that can never be null. Branching on a null check therefore results in dead code.
Fix Description:	Check Node.isNoType() instead. (see diff)
Violation Types:	superfluous/condition/null_check
In File:	com/google/javascript/rhino/jstype/UnionType.java
In Method:	meet(JSType)
Code with Misuse:	class UnionType { JSType meet(JSType that) { UnionTypeBuilder builder = new UnionTypeBuilder(registry); for (JSType alternate : alternates) { if (alternate.isSubtype(that)) { builder.addAlternate(alternate); } } if (that instanceof UnionType) { for (JSType otherAlternate : ((UnionType) that).alternates) { if (otherAlternate.isSubtype(this)) { builder.addAlternate(otherAlternate); } } } else if (that.isSubtype(this)) { builder.addAlternate(that); } JSType result = builder.build(); if (result != null) { return result; } else if (this.isObject() && that.isObject()) { return getNativeType(JSTypeNative.NO_OBJECT_TYPE); } else { return getNativeType(JSTypeNative.NO_TYPE); } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
No	0	0.5058823529411764	(overlap = 43.00 / 45.00)(pattern support = 9 / 17)(violation support = 1 / 1)	dound/google-closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#getRestrictedUnion(JSType) nuxleus/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#getRestrictedUnion(JSType) arcadoss/js-invulnerable/src/com/google/javascript/rhino/jstype/UnionType.java#getRestrictedUnion(JSType) olegshnitko/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#getRestrictedUnion(JSType) johan/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#getRestrictedUnion(JSType)	9
No	1	0.39705882352941174	(overlap = 9.00 / 10.00)(pattern support = 15 / 17)(violation support = 1 / 2)	Dandandan/wikiprogramming/jsrepl/tools/closure-compiler/trunk/src/com/google/javascript/rhino/jstype/UnionType.java#restrictByNotNullOrUndefined() ksheedlo/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#restrictByNotNullOrUndefined() johan/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#restrictByNotNullOrUndefined() martinrosstmc/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#restrictByNotNullOrUndefined() weitzj/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#restrictByNotNullOrUndefined()	15
No	2	0.06501547987616098	(overlap = 3.00 / 19.00)(pattern support = 7 / 17)(violation support = 1 / 1)	tart/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#meet(JSType) ksheedlo/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#meet(JSType) nicupavel/google-closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#meet(JSType) knutwalker/google-closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#meet(JSType) martinrosstmc/closure-compiler/src/com/google/javascript/rhino/jstype/UnionType.java#meet(JSType)	7

Reviewer Name:	sarah
Comment: