Review

Uses PBEWithMD5AndDES which is considered unsafe.

• missing/condition/value_or_state

net/minecraft/launcher/authentication/BaseAuthenticationService.java

getCipher(int, String)

class BaseAuthenticationService {
    private static Cipher getCipher(final int mode, final String password) throws Exception {
        final Random random = new Random(43287234L);
        final byte[] salt = new byte[8];
        random.nextBytes(salt);
        final PBEParameterSpec pbeParamSpec = new PBEParameterSpec(salt, 5);

        final SecretKey pbeKey = SecretKeyFactory.getInstance("PBEWithMD5AndDES").generateSecret(new PBEKeySpec(password.toCharArray()));
        final Cipher cipher = Cipher.getInstance("PBEWithMD5AndDES");
        cipher.init(mode, pbeKey, pbeParamSpec);
        return cipher;
    }

}