Review

Iterates over two PathIterators from the same GeneralPath instead of one of the first path and one of the second.

Get second iterator from the second path object instead of both from the same.

• missing/call

org/jfree/chart/util/ShapeUtilities.java

equal(GeneralPath, GeneralPath)

class ShapeUtilities {
    /**
     * Tests two polygons for equality.  If both are <code>null</code> this
     * method returns <code>true</code>.
     *
     * @param p1  path 1 (<code>null</code> permitted).
     * @param p2  path 2 (<code>null</code> permitted).
     *
     * @return A boolean.
     */
    public static boolean equal(GeneralPath p1, GeneralPath p2) {
        if (p1 == null) {
            return (p2 == null);
        }
        if (p2 == null) {
            return false;
        }
        if (p1.getWindingRule() != p2.getWindingRule()) {
            return false;
        }
        PathIterator iterator1 = p1.getPathIterator(null);
        PathIterator iterator2 = p1.getPathIterator(null);
        double[] d1 = new double[6];
        double[] d2 = new double[6];
        boolean done = iterator1.isDone() && iterator2.isDone();
        while (!done) {
            if (iterator1.isDone() != iterator2.isDone()) {
                return false;
            }
            int seg1 = iterator1.currentSegment(d1);
            int seg2 = iterator2.currentSegment(d2);
            if (seg1 != seg2) {
                return false;
            }
            if (!Arrays.equals(d1, d2)) {
                return false;
            }
            iterator1.next();
            iterator2.next();
            done = iterator1.isDone() && iterator2.isDone();
        }
        return true;
    }

}

class GetOnlyOnePathIterator {
  boolean equal(GeneralPath p1, GeneralPath p2) {
    if (p1 == null) {
      return (p2 == null);
    }
    PathIterator iterator1 = p1.getPathIterator(null);
    PathIterator iterator2 = p2.getPathIterator(null);
    double[] d1 = new double[6];
    double[] d2 = new double[6];
    boolean done = iterator1.isDone() && iterator2.isDone();
    while (!done) {
      if (iterator1.isDone() != iterator2.isDone()) {
        return false;
      }
      int seg1 = iterator1.currentSegment(d1);
      int seg2 = iterator2.currentSegment(d2);
      if (seg1 != seg2) {
        return false;
      }
      if (!Arrays.equals(d1, d2)) {
        return false;
      }
      iterator1.next();
      iterator2.next();
      done = iterator1.isDone() && iterator2.isDone();
    }
    return true;
  }
}