Review

Detector:	MuDetect
Target:	project ' thomas-s-b-visualee ' version 410a80f
Misuse:	misuse ' 32 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Examiner.java calls 'scanner.next()' on 'java.util.Scanner scanner' without checking if there are more elements. Because the scanner is built from the JavaSource parameter that can be invalid (e.g., no token after opening parenthesis), this can lead to a runtime exception without a useful error message. This pull request adds an error message and a test.
Fix Description:	(see diff)
Violation Types:	missing/condition/value_or_state
In File:	de/strullerbaumann/visualee/examiner/Examiner.java
In Method:	scanAfterClosedParenthesis(String, Scanner)
Code with Misuse:	class Examiner { // TODO simplify protected static String scanAfterClosedParenthesis(String currentToken, Scanner scanner) { int countParenthesisOpen = countChar(currentToken, '('); int countParenthesisClose = countChar(currentToken, ')'); if (countParenthesisOpen == countParenthesisClose) { return scanner.next(); } Deque<Integer> stack = new ArrayDeque<>(); for (int iCount = 0; iCount < countParenthesisOpen - countParenthesisClose; iCount++) { stack.push(1); } String token = scanner.next(); whilestack: do { for (Examiner examiner : JavaSourceInspector.getInstance().getExaminers()) { if (examiner.getTypeFromToken(token) != null) { break whilestack; } } if (token.indexOf('(') > -1) { int countOpenParenthesis = countChar(token, '('); for (int iCount = 0; iCount < countOpenParenthesis; iCount++) { stack.push(1); } } if (token.indexOf(')') > -1) { int countClosedParenthesis = countChar(token, ')'); for (int iCount = 0; iCount < countClosedParenthesis; iCount++) { stack.pop(); } } if (scanner.hasNext()) { token = scanner.next(); } else { break; } } while (stack.size() > 0); return token; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	0	0.1222222222222222	(pattern support = 11 / 11)(pattern violations = 1 / 6)(overlap = 11.00 / 15.00)	thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/JavaSourceInspector.java#examine() thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/ui/graph/boundary/GraphCreator.java#generateGraphs(File, File, String) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/ui/graph/boundary/GraphCreator.java#buildJSONLinks(DependencyFilter) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/source/boundary/JavaSourceContainer.java#loadJavaFiles(String) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/ui/graph/boundary/GraphConfigurator.java#setGraphConfigs(List)	11
?	27	0.027056277056277056	(pattern support = 10 / 11)(pattern violations = 1 / 28)(overlap = 5.00 / 6.00)	thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/jpa/ExaminerJPA.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerInstance.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/source/entity/JavaSource.java#JavaSource(Path) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerInject.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerEvent.java#examineDetail(JavaSource, Scanner, String, DependencyType)	10
?	28	0.027056277056277056	(pattern support = 10 / 11)(pattern violations = 1 / 28)(overlap = 5.00 / 6.00)	thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/jpa/ExaminerJPA.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerInstance.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/source/entity/JavaSource.java#JavaSource(Path) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerInject.java#examineDetail(JavaSource, Scanner, String, DependencyType) thomas-s-b-visualee/410a80f/build/src/main/java/de/strullerbaumann/visualee/examiner/cdi/ExaminerEvent.java#examineDetail(JavaSource, Scanner, String, DependencyType)	10