Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' argouml ' version 026
Misuse:	misuse ' tikanga11-3 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	If the zargo file to be loaded contains no `.argo` file, this method will throw an exception at line 218.
Fix Description:	Check that the iterator contains a file to fix this.
Violation Types:	missing/condition/value_or_state
In File:	org/argouml/persistence/ZargoFilePersister.java
In Method:	doLoad(File)
Code with Misuse:	class ZargoFilePersister { /* * @see org.argouml.persistence.ProjectFilePersister#doLoad(java.io.File) */ @Override public Project doLoad(File file) throws OpenException, InterruptedException { ProgressMgr progressMgr = new ProgressMgr(); progressMgr.setNumberOfPhases(3 + UML_PHASES_LOAD); ThreadUtils.checkIfInterrupted(); int fileVersion; String releaseVersion; try { String argoEntry = getEntryNames(file, ".argo").iterator().next(); URL argoUrl = makeZipEntryUrl(toURL(file), argoEntry); fileVersion = getPersistenceVersion(argoUrl.openStream()); releaseVersion = getReleaseVersion(argoUrl.openStream()); } catch (MalformedURLException e) { throw new OpenException(e); } catch (IOException e) { throw new OpenException(e); } // TODO: The commented code below was commented out by Bob Tarling // in order to resolve bugs 4845 and 4857. Hopefully we can // determine the cause and reintroduce. //boolean upgradeRequired = !checkVersion(fileVersion, releaseVersion) boolean upgradeRequired = true; LOG.info("Loading zargo file of version " + fileVersion); final Project p; if (upgradeRequired) { File combinedFile = zargoToUml(file, progressMgr); p = super.doLoad(file, combinedFile, progressMgr); } else { p = loadFromZargo(file, progressMgr); } progressMgr.nextPhase(); p.setURI(file.toURI()); return p; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

3211

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	2036	(overlap = 8.00 / 13.00)(pattern violations = 1 / 1179)(violation support = 1 / 10)
O-E2MNPVVS*PU	2597	(overlap = 8.00 / 13.00)(pattern violations = 1 / 1179)(violation support = 1 / 10)*(1 / 31742 (Iterator))
O-E2MN*VS	916	(overlap = 8.00 / 13.00)*(violation support = 1 / 10)
O-E2MNVSPU	1902	(overlap = 8.00 / 13.00)(violation support = 1 / 10)(1 / 31742 (Iterator))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	2023	(pattern violations = 1 / 1179)*(violation support = 1 / 10)
PVVSPU	2643	(pattern violations = 1 / 1179)(violation support = 1 / 10)(1 / 31742 (Iterator))
Rareness	-	filtered
VS	-	filtered
VS*PU	1869	(violation support = 1 / 10)*(1 / 31742 (Iterator))

argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByGoal.java#toDoItemsChanged(ToDoListEvent)
argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByGoal.java#toDoItemsRemoved(ToDoListEvent)
argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByDecision.java#toDoItemsRemoved(ToDoListEvent)
argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByDecision.java#toDoItemsAdded(ToDoListEvent)
argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByGoal.java#toDoItemsAdded(ToDoListEvent)

10320

Strategy	Rank	Desc
	3639	()
Confidence	1148	15 / (15 + 145)
DefectIndicator	3063	(1 / 16100 (String)) * 15 / 88
O-E2MN	1184	(overlap = 7.00 / 8.00)
O-E2MN*PS	1568	(overlap = 7.00 / 8.00)*(pattern support = 15 / 417)
O-E2MNPSPU	1982	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(1 / 16100 (String))
O-E2MNPSPV	885	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(pattern violations = 1 / 145)
O-E2MNPSPV*PU	1475	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(pattern violations = 1 / 145)*(1 / 16100 (String))
O-E2MNPSPV*VS	1884	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(pattern violations = 1 / 145)*(violation support = 1 / 88)
O-E2MNPSPVVSPU	2196	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(pattern violations = 1 / 145)(violation support = 1 / 88)(1 / 16100 (String))
O-E2MNPSVS	2973	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(violation support = 1 / 88)
O-E2MNPSVS*PU	2871	(overlap = 7.00 / 8.00)(pattern support = 15 / 417)(violation support = 1 / 88)*(1 / 16100 (String))
O-E2MN*PU	1475	(overlap = 7.00 / 8.00)*(1 / 16100 (String))
O-E2MN*PV	402	(overlap = 7.00 / 8.00)*(pattern violations = 1 / 145)
O-E2MNPVPU	1188	(overlap = 7.00 / 8.00)(pattern violations = 1 / 145)(1 / 16100 (String))
O-E2MNPVVS	1836	(overlap = 7.00 / 8.00)(pattern violations = 1 / 145)(violation support = 1 / 88)
O-E2MNPVVS*PU	2078	(overlap = 7.00 / 8.00)(pattern violations = 1 / 145)(violation support = 1 / 88)*(1 / 16100 (String))
O-E2MN*VS	3064	(overlap = 7.00 / 8.00)*(violation support = 1 / 88)
O-E2MNVSPU	2859	(overlap = 7.00 / 8.00)(violation support = 1 / 88)(1 / 16100 (String))
PS	7561	(pattern support = 15 / 417)
PS*PU	2304	(pattern support = 15 / 417)*(1 / 16100 (String))
PS*PV	1148	(pattern support = 15 / 417)*(pattern violations = 1 / 145)
PSPVPU	1502	(pattern support = 15 / 417)(pattern violations = 1 / 145)(1 / 16100 (String))
PSPVVS	2185	(pattern support = 15 / 417)(pattern violations = 1 / 145)(violation support = 1 / 88)
PSPVVS*PU	2288	(pattern support = 15 / 417)(pattern violations = 1 / 145)(violation support = 1 / 88)*(1 / 16100 (String))
PS*VS	3417	(pattern support = 15 / 417)*(violation support = 1 / 88)
PSVSPU	3063	(pattern support = 15 / 417)(violation support = 1 / 88)(1 / 16100 (String))
PU	3294	(1 / 16100 (String))
PV	828	(pattern violations = 1 / 145)
PV*PU	1293	(pattern violations = 1 / 145)*(1 / 16100 (String))
PV*VS	2092	(pattern violations = 1 / 145)*(violation support = 1 / 88)
PVVSPU	2216	(pattern violations = 1 / 145)(violation support = 1 / 88)(1 / 16100 (String))
Rareness	3417	1 - (88 / 15)
VS	3671	(violation support = 1 / 88)
VS*PU	3153	(violation support = 1 / 88)*(1 / 16100 (String))

argouml/026/build/src/argouml-app/src/org/argouml/persistence/UmlFilePersister.java#writeProject(Project, OutputStream, ProgressMgr)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/use_case/UseCaseDiagramGraphModel.java#addEdge(Object)
argouml/026/build/src/argouml-app/src/org/argouml/persistence/ZargoFilePersister.java#copyArgo(File, String, PrintWriter)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ClassDiagramGraphModel.java#addEdge(Object)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/ui/FigEdgeAssociationClass.java#getRemoveDelegate()

10363

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	2825	(overlap = 3.00 / 4.00)*(1 / 15645 (Iterable))
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

argouml/026/build/src/argouml-app/src/org/argouml/ocl/ArgoFacade.java#operationMatchesCall(Object, String, Type[])
argouml/026/build/src/argouml-app/src/org/argouml/language/java/generator/GeneratorJava.java#generateConstraintEnrichedDocComment(Object, boolean, String)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/ui/FigNodeModelElement.java#updateStereotypeIcon()
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/ui/TabDiagram.java#selectionChanged(GraphSelectionEvent)
argouml/026/build/src/argouml-app/src/org/argouml/language/java/generator/GeneratorJava.java#generateMethodBody(Object)

11140

Strategy	Rank	Desc
	-	filtered
Confidence	62	417 / (417 + 240)
DefectIndicator	1494	(1 / 31742 (Iterator)) * 417 / 152
O-E2MN	2632	(overlap = 8.00 / 10.00)
O-E2MN*PS	85	(overlap = 8.00 / 10.00)*(pattern support = 417 / 417)
O-E2MNPSPU	616	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(1 / 31742 (Iterator))
O-E2MNPSPV	90	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(pattern violations = 1 / 240)
O-E2MNPSPV*PU	524	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(pattern violations = 1 / 240)*(1 / 31742 (Iterator))
O-E2MNPSPV*VS	630	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(pattern violations = 1 / 240)*(violation support = 1 / 152)
O-E2MNPSPVVSPU	1174	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(pattern violations = 1 / 240)(violation support = 1 / 152)(1 / 31742 (Iterator))
O-E2MNPSVS	500	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(violation support = 1 / 152)
O-E2MNPSVS*PU	1203	(overlap = 8.00 / 10.00)(pattern support = 417 / 417)(violation support = 1 / 152)*(1 / 31742 (Iterator))
O-E2MN*PU	-	filtered
O-E2MN*PV	1852	(overlap = 8.00 / 10.00)*(pattern violations = 1 / 240)
O-E2MNPVPU	2191	(overlap = 8.00 / 10.00)(pattern violations = 1 / 240)(1 / 31742 (Iterator))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	57	(pattern support = 417 / 417)
PS*PU	1111	(pattern support = 417 / 417)*(1 / 31742 (Iterator))
PS*PV	62	(pattern support = 417 / 417)*(pattern violations = 1 / 240)
PSPVPU	955	(pattern support = 417 / 417)(pattern violations = 1 / 240)(1 / 31742 (Iterator))
PSPVVS	671	(pattern support = 417 / 417)(pattern violations = 1 / 240)(violation support = 1 / 152)
PSPVVS*PU	1421	(pattern support = 417 / 417)(pattern violations = 1 / 240)(violation support = 1 / 152)*(1 / 31742 (Iterator))
PS*VS	523	(pattern support = 417 / 417)*(violation support = 1 / 152)
PSVSPU	1494	(pattern support = 417 / 417)(violation support = 1 / 152)(1 / 31742 (Iterator))
PU	-	filtered
PV	2115	(pattern violations = 1 / 240)
PV*PU	3186	(pattern violations = 1 / 240)*(1 / 31742 (Iterator))
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	523	1 - (152 / 417)
VS	-	filtered
VS*PU	-	filtered

argouml/026/build/src/argouml-app/src/org/argouml/ui/explorer/rules/GoProjectToStateMachine.java#getChildren(Object)
argouml/026/build/src/argouml-app/src/org/argouml/ui/explorer/ExplorerTreeModel.java#collectChildren(Object, List, Set)
argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/java/Modeller.java#addInterface(String, short, List, List, String, boolean)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/deployment/ui/FigComponentInstance.java#updateListeners(Object, Object)
argouml/026/build/src/argouml-app/src/org/argouml/uml/cognitive/critics/CrUselessInterface.java#predicate2(Object, Designer)

417

22765

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	827	(violation support = 1 / 10)
VS*PU	-	filtered

argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ui/FigClassifierBox.java#setOperationsVisible(boolean)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ui/FigInterface.java#setOperationsVisible(boolean)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ui/FigEnumeration.java#setEnumLiteralsVisible(boolean)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/ui/FigNodeModelElement.java#updateStereotypeIcon()
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ui/FigClassifierBoxWithAttributes.java#setAttributesVisible(boolean)

25003

Strategy	Rank	Desc
	3642	()
Confidence	164	10 / (10 + 8)
DefectIndicator	131	(1 / 49 (File)) * 10 / 6
O-E2MN	6031	(overlap = 5.00 / 8.00)
O-E2MN*PS	10353	(overlap = 5.00 / 8.00)*(pattern support = 10 / 417)
O-E2MNPSPU	171	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(1 / 49 (File))
O-E2MNPSPV	193	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(pattern violations = 1 / 8)
O-E2MNPSPV*PU	59	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(pattern violations = 1 / 8)*(1 / 49 (File))
O-E2MNPSPV*VS	86	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(pattern violations = 1 / 8)*(violation support = 1 / 6)
O-E2MNPSPVVSPU	45	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(pattern violations = 1 / 8)(violation support = 1 / 6)(1 / 49 (File))
O-E2MNPSVS	825	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(violation support = 1 / 6)
O-E2MNPSVS*PU	132	(overlap = 5.00 / 8.00)(pattern support = 10 / 417)(violation support = 1 / 6)*(1 / 49 (File))
O-E2MN*PU	142	(overlap = 5.00 / 8.00)*(1 / 49 (File))
O-E2MN*PV	19	(overlap = 5.00 / 8.00)*(pattern violations = 1 / 8)
O-E2MNPVPU	25	(overlap = 5.00 / 8.00)(pattern violations = 1 / 8)(1 / 49 (File))
O-E2MNPVVS	38	(overlap = 5.00 / 8.00)(pattern violations = 1 / 8)(violation support = 1 / 6)
O-E2MNPVVS*PU	40	(overlap = 5.00 / 8.00)(pattern violations = 1 / 8)(violation support = 1 / 6)*(1 / 49 (File))
O-E2MN*VS	620	(overlap = 5.00 / 8.00)*(violation support = 1 / 6)
O-E2MNVSPU	95	(overlap = 5.00 / 8.00)(violation support = 1 / 6)(1 / 49 (File))
PS	11166	(pattern support = 10 / 417)
PS*PU	175	(pattern support = 10 / 417)*(1 / 49 (File))
PS*PV	164	(pattern support = 10 / 417)*(pattern violations = 1 / 8)
PSPVPU	46	(pattern support = 10 / 417)(pattern violations = 1 / 8)(1 / 49 (File))
PSPVVS	76	(pattern support = 10 / 417)(pattern violations = 1 / 8)(violation support = 1 / 6)
PSPVVS*PU	44	(pattern support = 10 / 417)(pattern violations = 1 / 8)(violation support = 1 / 6)*(1 / 49 (File))
PS*VS	769	(pattern support = 10 / 417)*(violation support = 1 / 6)
PSVSPU	131	(pattern support = 10 / 417)(violation support = 1 / 6)(1 / 49 (File))
PU	105	(1 / 49 (File))
PV	12	(pattern violations = 1 / 8)
PV*PU	23	(pattern violations = 1 / 8)*(1 / 49 (File))
PV*VS	32	(pattern violations = 1 / 8)*(violation support = 1 / 6)
PVVSPU	39	(pattern violations = 1 / 8)(violation support = 1 / 6)(1 / 49 (File))
Rareness	769	1 - (6 / 10)
VS	537	(violation support = 1 / 6)
VS*PU	95	(violation support = 1 / 6)*(1 / 49 (File))

argouml/026/build/src/argouml-app/src/org/argouml/profile/ZipModelLoader.java#loadModel(ProfileReference)
argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/ImportClassLoader.java#getURLs(String)
argouml/026/build/src/argouml-app/src/org/argouml/persistence/XmiFilePersister.java#doLoad(File)
argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/java/JavaImport.java#updateImportClassloader()
argouml/026/build/src/argouml-app/src/org/argouml/persistence/UmlFilePersister.java#getReleaseVersionFromFile(File)

35100

Strategy	Rank	Desc
	3638	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	2369	(1 / 15645 (Iterable))
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

argouml/026/build/src/argouml-app/src/org/argouml/language/java/generator/GeneratorJava.java#generateImports(Object, String)
argouml/026/build/src/argouml-app/src/org/argouml/uml/ui/SourcePathDialog.java#getSelectedIndexes()
argouml/026/build/src/argouml-app/src/org/argouml/ui/explorer/ExplorerTree.java#valueChanged(TreeSelectionEvent)
argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/ui/TabDiagram.java#selectionChanged(GraphSelectionEvent)
argouml/026/build/src/argouml-app/src/org/argouml/ui/explorer/ExplorerPopup.java#addMenuItemForBothEndsOf(Object)