Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' chensun ' version cf23b99
Misuse:	misuse ' mudetect-1 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	The `PreparedStatement answerStmt` opened in line 194 is never closed.
Fix Description:
Violation Types:	missing/call
In File:	database/DatabaseAdmin.java
In Method:	changePassword(Connection, String, String)
Code with Misuse:	class DatabaseAdmin { public static int changePassword(Connection conn, String username, String pwdStore) { int status = -1; String fetchAnswer = "SELECT secanswer FROM main.users WHERE username = ?"; String query = "UPDATE main.users SET pwhash = ?, checksum = ? WHERE username = ?"; PreparedStatement answerStmt = null; ResultSet rs = null; PreparedStatement pstmt = null; try { answerStmt = conn.prepareStatement(fetchAnswer); answerStmt.setString(1, username); rs = answerStmt.executeQuery(); if (rs.next()) { String secA = SharedKeyCrypto.decrypt(rs.getString("secanswer")); //recalculate the new hash to update this user's entry //create checksum to add as 5th element byte[] userBytes = username.getBytes("UTF8"); byte[] pwBytes = pwdStore.getBytes("UTF8"); byte[] ansBytes = secA.getBytes("UTF8"); byte[] toChecksum = new byte[userBytes.length + pwBytes.length + ansBytes.length]; System.arraycopy(userBytes, 0, toChecksum, 0, userBytes.length); System.arraycopy(pwBytes, 0, toChecksum, userBytes.length, pwBytes.length); System.arraycopy(ansBytes, 0, toChecksum, pwBytes.length + userBytes.length, ansBytes.length); pstmt = conn.prepareStatement(query); pstmt.setString(1, SharedKeyCrypto.encrypt(pwdStore)); pstmt.setString(2, CryptoUtil.encode(Hash.generateChecksum(toChecksum))); pstmt.setString(3, username); status = pstmt.executeUpdate(); } else { //this cannot happen, checked before function is entered } } catch (SQLException e) { status = -1; } catch (UnsupportedEncodingException e) { //cannot happen } finally { DBManager.closeResultSet(rs); DBManager.closeStatement(answerStmt); DBManager.closePreparedStatement(pstmt); } return status; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

Strategy	Rank	Desc
	-	filtered
Confidence	110	11 / (11 + 90)
DefectIndicator	13	(1 / 432 (String)) * 11 / 1
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	15	(overlap = 34.00 / 37.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)*(violation support = 1 / 1)
O-E2MNPSPVVSPU	15	(overlap = 34.00 / 37.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 1)(1 / 432 (String))
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	15	(overlap = 34.00 / 37.00)(pattern violations = 1 / 90)(violation support = 1 / 1)
O-E2MNPVVS*PU	15	(overlap = 34.00 / 37.00)(pattern violations = 1 / 90)(violation support = 1 / 1)*(1 / 432 (String))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	110	(pattern support = 11 / 22)*(pattern violations = 1 / 90)
PSPVPU	110	(pattern support = 11 / 22)(pattern violations = 1 / 90)(1 / 432 (String))
PSPVVS	13	(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 1)
PSPVVS*PU	13	(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 1)*(1 / 432 (String))
PS*VS	2	(pattern support = 11 / 22)*(violation support = 1 / 1)
PSVSPU	13	(pattern support = 11 / 22)(violation support = 1 / 1)(1 / 432 (String))
PU	-	filtered
PV	110	(pattern violations = 1 / 90)
PV*PU	110	(pattern violations = 1 / 90)*(1 / 432 (String))
PV*VS	13	(pattern violations = 1 / 90)*(violation support = 1 / 1)
PVVSPU	13	(pattern violations = 1 / 90)(violation support = 1 / 1)(1 / 432 (String))
Rareness	2	1 - (1 / 11)
VS	0	(violation support = 1 / 1)
VS*PU	13	(violation support = 1 / 1)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseBoards.java#createBoard(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseRegions.java#createRegion(Connection, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createPost(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createReply(Connection, String, String, String, String, int)

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	0	(overlap = 69.00 / 70.00)
O-E2MN*PS	39	(overlap = 69.00 / 70.00)*(pattern support = 11 / 22)
O-E2MNPSPU	46	(overlap = 69.00 / 70.00)(pattern support = 11 / 22)(1 / 432 (String))
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	1	(overlap = 69.00 / 70.00)(pattern support = 11 / 22)(violation support = 1 / 1)
O-E2MNPSVS*PU	13	(overlap = 69.00 / 70.00)(pattern support = 11 / 22)(violation support = 1 / 1)*(1 / 432 (String))
O-E2MN*PU	13	(overlap = 69.00 / 70.00)*(1 / 432 (String))
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	0	(overlap = 69.00 / 70.00)*(violation support = 1 / 1)
O-E2MNVSPU	13	(overlap = 69.00 / 70.00)(violation support = 1 / 1)(1 / 432 (String))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getRegReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getParticipantsOne(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendRequestList(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfBoard(Connection, String)

Strategy	Rank	Desc
	14	()
Confidence	48	10 / (10 + 56)
DefectIndicator	101	(1 / 432 (String)) * 10 / 56
O-E2MN	92	(overlap = 9.00 / 11.00)
O-E2MN*PS	95	(overlap = 9.00 / 11.00)*(pattern support = 10 / 22)
O-E2MNPSPU	96	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(1 / 432 (String))
O-E2MNPSPV	48	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(pattern violations = 1 / 56)
O-E2MNPSPV*PU	48	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(pattern violations = 1 / 56)*(1 / 432 (String))
O-E2MNPSPV*VS	101	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(pattern violations = 1 / 56)*(violation support = 1 / 56)
O-E2MNPSPVVSPU	101	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(pattern violations = 1 / 56)(violation support = 1 / 56)(1 / 432 (String))
O-E2MNPSVS	100	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(violation support = 1 / 56)
O-E2MNPSVS*PU	100	(overlap = 9.00 / 11.00)(pattern support = 10 / 22)(violation support = 1 / 56)*(1 / 432 (String))
O-E2MN*PU	96	(overlap = 9.00 / 11.00)*(1 / 432 (String))
O-E2MN*PV	48	(overlap = 9.00 / 11.00)*(pattern violations = 1 / 56)
O-E2MNPVPU	48	(overlap = 9.00 / 11.00)(pattern violations = 1 / 56)(1 / 432 (String))
O-E2MNPVVS	101	(overlap = 9.00 / 11.00)(pattern violations = 1 / 56)(violation support = 1 / 56)
O-E2MNPVVS*PU	101	(overlap = 9.00 / 11.00)(pattern violations = 1 / 56)(violation support = 1 / 56)*(1 / 432 (String))
O-E2MN*VS	100	(overlap = 9.00 / 11.00)*(violation support = 1 / 56)
O-E2MNVSPU	100	(overlap = 9.00 / 11.00)(violation support = 1 / 56)(1 / 432 (String))
PS	96	(pattern support = 10 / 22)
PS*PU	96	(pattern support = 10 / 22)*(1 / 432 (String))
PS*PV	48	(pattern support = 10 / 22)*(pattern violations = 1 / 56)
PSPVPU	48	(pattern support = 10 / 22)(pattern violations = 1 / 56)(1 / 432 (String))
PSPVVS	101	(pattern support = 10 / 22)(pattern violations = 1 / 56)(violation support = 1 / 56)
PSPVVS*PU	101	(pattern support = 10 / 22)(pattern violations = 1 / 56)(violation support = 1 / 56)*(1 / 432 (String))
PS*VS	101	(pattern support = 10 / 22)*(violation support = 1 / 56)
PSVSPU	101	(pattern support = 10 / 22)(violation support = 1 / 56)(1 / 432 (String))
PU	27	(1 / 432 (String))
PV	48	(pattern violations = 1 / 56)
PV*PU	48	(pattern violations = 1 / 56)*(1 / 432 (String))
PV*VS	101	(pattern violations = 1 / 56)*(violation support = 1 / 56)
PVVSPU	101	(pattern violations = 1 / 56)(violation support = 1 / 56)(1 / 432 (String))
Rareness	101	1 - (56 / 10)
VS	101	(violation support = 1 / 56)
VS*PU	101	(violation support = 1 / 56)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdmins(Connection)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfGroup(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getParticipantsOne(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendRequestList(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfBoard(Connection, String)

139

Strategy	Rank	Desc
	13	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	26	(1 / 432 (String))
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#insertRegRequest(Connection, String, int, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#authorizedFFAPost(Connection, String, int, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#postExists(Connection, String, String, int)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#removeParticipant(Connection, String, String, String)

144

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	48	(pattern support = 11 / 22)
PS*PU	54	(pattern support = 11 / 22)*(1 / 432 (String))
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getRegReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getParticipantsOne(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendRequestList(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfBoard(Connection, String)

171

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	106	(overlap = 36.00 / 37.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)
O-E2MNPSPV*PU	106	(overlap = 36.00 / 37.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)*(1 / 432 (String))
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	106	(overlap = 36.00 / 37.00)*(pattern violations = 1 / 90)
O-E2MNPVPU	106	(overlap = 36.00 / 37.00)(pattern violations = 1 / 90)(1 / 432 (String))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseBoards.java#createBoard(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseRegions.java#createRegion(Connection, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createPost(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createReply(Connection, String, String, String, String, int)