Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' chensun ' version cf23b99
Misuse:	misuse ' mudetect-13 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	The `PreparedStatement pstmt` opened in line 1159 is never closed.
Fix Description:
Violation Types:	missing/call
In File:	database/DatabaseAdmin.java
In Method:	replaceBoardManager(Connection, String)
Code with Misuse:	class DatabaseAdmin { /** * Precondition: user is an admin. If user is an SA, nothing is done and returns -1. * @param conn * @param username * @return */ public static int replaceBoardManager(Connection conn, String username) { int status = -1; Connection tempConn = DBManager.getConnection(); String sa = saOfUsersGroup(tempConn, username); DBManager.closeConnection(tempConn); if (sa == null \|\| sa.equals(username)) { if (DEBUG) { System.err.printf("sa = %s, username = %s\n", sa, username); } return status; } String query = "UPDATE main.boards SET managedby = ? WHERE managedby = ?"; PreparedStatement pstmt = null; try { pstmt = conn.prepareStatement(query); pstmt.setString(1, sa); pstmt.setString(2, username); status = pstmt.executeUpdate(); if (DEBUG) System.err.printf("status = %d\n", status); } catch (SQLException e) { if (DEBUG) { System.err.println("failing cuz SQLException"); e.printStackTrace(); } status = -1; } return status; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

Strategy	Rank	Desc
	135	()
Confidence	138	11 / (11 + 90)
DefectIndicator	34	(1 / 432 (String)) * 11 / 2
O-E2MN	28	(overlap = 34.00 / 35.00)
O-E2MN*PS	67	(overlap = 34.00 / 35.00)*(pattern support = 11 / 22)
O-E2MNPSPU	74	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(1 / 432 (String))
O-E2MNPSPV	128	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)
O-E2MNPSPV*PU	128	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)*(1 / 432 (String))
O-E2MNPSPV*VS	47	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)*(violation support = 1 / 2)
O-E2MNPSPVVSPU	47	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 2)(1 / 432 (String))
O-E2MNPSVS	14	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(violation support = 1 / 2)
O-E2MNPSVS*PU	24	(overlap = 34.00 / 35.00)(pattern support = 11 / 22)(violation support = 1 / 2)*(1 / 432 (String))
O-E2MN*PU	41	(overlap = 34.00 / 35.00)*(1 / 432 (String))
O-E2MN*PV	128	(overlap = 34.00 / 35.00)*(pattern violations = 1 / 90)
O-E2MNPVPU	128	(overlap = 34.00 / 35.00)(pattern violations = 1 / 90)(1 / 432 (String))
O-E2MNPVVS	25	(overlap = 34.00 / 35.00)(pattern violations = 1 / 90)(violation support = 1 / 2)
O-E2MNPVVS*PU	25	(overlap = 34.00 / 35.00)(pattern violations = 1 / 90)(violation support = 1 / 2)*(1 / 432 (String))
O-E2MN*VS	12	(overlap = 34.00 / 35.00)*(violation support = 1 / 2)
O-E2MNVSPU	24	(overlap = 34.00 / 35.00)(violation support = 1 / 2)(1 / 432 (String))
PS	87	(pattern support = 11 / 22)
PS*PU	-	filtered
PS*PV	138	(pattern support = 11 / 22)*(pattern violations = 1 / 90)
PSPVPU	138	(pattern support = 11 / 22)(pattern violations = 1 / 90)(1 / 432 (String))
PSPVVS	64	(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 2)
PSPVVS*PU	64	(pattern support = 11 / 22)(pattern violations = 1 / 90)(violation support = 1 / 2)*(1 / 432 (String))
PS*VS	25	(pattern support = 11 / 22)*(violation support = 1 / 2)
PSVSPU	34	(pattern support = 11 / 22)(violation support = 1 / 2)(1 / 432 (String))
PU	-	filtered
PV	138	(pattern violations = 1 / 90)
PV*PU	138	(pattern violations = 1 / 90)*(1 / 432 (String))
PV*VS	38	(pattern violations = 1 / 90)*(violation support = 1 / 2)
PVVSPU	38	(pattern violations = 1 / 90)(violation support = 1 / 2)(1 / 432 (String))
Rareness	25	1 - (2 / 11)
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseBoards.java#createBoard(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseRegions.java#createRegion(Connection, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createPost(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createReply(Connection, String, String, String, String, int)

195

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	42	(1 / 432 (String)) * 16 / 7
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	43	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(pattern violations = 1 / 21)*(violation support = 1 / 7)
O-E2MNPSPVVSPU	43	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 7)(1 / 432 (String))
O-E2MNPSVS	41	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(violation support = 1 / 7)
O-E2MNPSVS*PU	41	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(violation support = 1 / 7)*(1 / 432 (String))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	32	(overlap = 5.00 / 7.00)(pattern violations = 1 / 21)(violation support = 1 / 7)
O-E2MNPVVS*PU	32	(overlap = 5.00 / 7.00)(pattern violations = 1 / 21)(violation support = 1 / 7)*(1 / 432 (String))
O-E2MN*VS	41	(overlap = 5.00 / 7.00)*(violation support = 1 / 7)
O-E2MNVSPU	41	(overlap = 5.00 / 7.00)(violation support = 1 / 7)(1 / 432 (String))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	22	(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 7)
PSPVVS*PU	22	(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 7)*(1 / 432 (String))
PS*VS	42	(pattern support = 16 / 22)*(violation support = 1 / 7)
PSVSPU	42	(pattern support = 16 / 22)(violation support = 1 / 7)(1 / 432 (String))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	30	(pattern violations = 1 / 21)*(violation support = 1 / 7)
PVVSPU	30	(pattern violations = 1 / 21)(violation support = 1 / 7)(1 / 432 (String))
Rareness	42	1 - (7 / 16)
VS	42	(violation support = 1 / 7)
VS*PU	42	(violation support = 1 / 7)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/server/SocialNetworkAdmin.java#regApprove(Connection, String)
chensun/cf23b99/build/CS5430/src/server/SocialNetworkDBAThread.java#run()
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/client/ClientGUI.java#main(String[])
chensun/cf23b99/build/CS5430/src/client/ClientProcessor.java#processHelp()

197

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	25	(violation support = 1 / 2)
VS*PU	34	(violation support = 1 / 2)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#insertRegRequest(Connection, String, int, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#authorizedFFAPost(Connection, String, int, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#postExists(Connection, String, String, int)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#removeParticipant(Connection, String, String, String)

212

Strategy	Rank	Desc
	136	()
Confidence	34	17 / (17 + 18)
DefectIndicator	-	filtered
O-E2MN	82	(overlap = 5.00 / 6.00)
O-E2MN*PS	28	(overlap = 5.00 / 6.00)*(pattern support = 17 / 22)
O-E2MNPSPU	41	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(1 / 432 (String))
O-E2MNPSPV	34	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(pattern violations = 1 / 18)
O-E2MNPSPV*PU	41	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(pattern violations = 1 / 18)*(1 / 432 (String))
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	86	(overlap = 5.00 / 6.00)*(1 / 432 (String))
O-E2MN*PV	37	(overlap = 5.00 / 6.00)*(pattern violations = 1 / 18)
O-E2MNPVPU	41	(overlap = 5.00 / 6.00)(pattern violations = 1 / 18)(1 / 432 (String))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	28	(pattern support = 17 / 22)
PS*PU	41	(pattern support = 17 / 22)*(1 / 432 (String))
PS*PV	34	(pattern support = 17 / 22)*(pattern violations = 1 / 18)
PSPVPU	41	(pattern support = 17 / 22)(pattern violations = 1 / 18)(1 / 432 (String))
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	140	(1 / 432 (String))
PV	34	(pattern violations = 1 / 18)
PV*PU	41	(pattern violations = 1 / 18)*(1 / 432 (String))
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/server/SocialNetworkAdmin.java#regApprove(Connection, String)
chensun/cf23b99/build/CS5430/src/server/SocialNetworkDBAThread.java#run()
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/client/ClientGUI.java#main(String[])
chensun/cf23b99/build/CS5430/src/client/ClientProcessor.java#processHelp()

252

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	139	(1 / 432 (String))
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseBoards.java#createBoard(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseRegions.java#createRegion(Connection, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createPost(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createReply(Connection, String, String, String, String, int)

253

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	90	(pattern support = 11 / 22)*(1 / 432 (String))
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getRegReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getParticipantsOne(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendRequestList(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfBoard(Connection, String)