Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' chensun ' version cf23b99
Misuse:	misuse ' mudetect-4 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	The `ResultSet postResult` opened in line 42 is never closed.
Fix Description:
Violation Types:	missing/call
In File:	database/SocialNetworkDatabasePosts.java
In Method:	postExists(Connection, String, String, int)
Code with Misuse:	class SocialNetworkDatabasePosts { /** * Verifies whether a post exists in the given board (and region). / public static Boolean postExists(Connection conn, String boardName, String regionName, int postNum) { PreparedStatement pstmt = null; ResultSet postResult = null; String getPost = ""; if (boardName.equals("freeforall")) { getPost = "SELECT FROM freeforall.posts " + "WHERE pid = ?"; } else { getPost = "SELECT * FROM " + boardName + ".posts " + "WHERE pid = ? AND rname = ?"; } Boolean postExists = null; try { pstmt = conn.prepareStatement(getPost); pstmt.setInt(1, postNum); if (!boardName.equals("freeforall")) { pstmt.setString(2, regionName); } postResult = pstmt.executeQuery(); postExists = new Boolean(postResult.next()); } catch (SQLException e) { e.printStackTrace(); System.out.println(e.getSQLState()); } finally { DBManager.closePreparedStatement(pstmt); } return postExists; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

Strategy	Rank	Desc
	122	()
Confidence	-	filtered
DefectIndicator	66	(1 / 432 (String)) * 16 / 11
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	58	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(pattern violations = 1 / 21)*(violation support = 1 / 11)
O-E2MNPSPVVSPU	58	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 11)(1 / 432 (String))
O-E2MNPSVS	70	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(violation support = 1 / 11)
O-E2MNPSVS*PU	70	(overlap = 5.00 / 7.00)(pattern support = 16 / 22)(violation support = 1 / 11)*(1 / 432 (String))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	61	(overlap = 5.00 / 7.00)(pattern violations = 1 / 21)(violation support = 1 / 11)
O-E2MNPVVS*PU	61	(overlap = 5.00 / 7.00)(pattern violations = 1 / 21)(violation support = 1 / 11)*(1 / 432 (String))
O-E2MN*VS	57	(overlap = 5.00 / 7.00)*(violation support = 1 / 11)
O-E2MNVSPU	57	(overlap = 5.00 / 7.00)(violation support = 1 / 11)(1 / 432 (String))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	54	(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 11)
PSPVVS*PU	54	(pattern support = 16 / 22)(pattern violations = 1 / 21)(violation support = 1 / 11)*(1 / 432 (String))
PS*VS	66	(pattern support = 16 / 22)*(violation support = 1 / 11)
PSVSPU	66	(pattern support = 16 / 22)(violation support = 1 / 11)(1 / 432 (String))
PU	128	(1 / 432 (String))
PV	-	filtered
PV*PU	-	filtered
PV*VS	60	(pattern violations = 1 / 21)*(violation support = 1 / 11)
PVVSPU	60	(pattern violations = 1 / 21)(violation support = 1 / 11)(1 / 432 (String))
Rareness	66	1 - (11 / 16)
VS	58	(violation support = 1 / 11)
VS*PU	58	(violation support = 1 / 11)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/server/SocialNetworkAdmin.java#regApprove(Connection, String)
chensun/cf23b99/build/CS5430/src/server/SocialNetworkDBAThread.java#run()
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/client/ClientGUI.java#main(String[])
chensun/cf23b99/build/CS5430/src/client/ClientProcessor.java#processHelp()

127

Strategy	Rank	Desc
	-	filtered
Confidence	30	17 / (17 + 18)
DefectIndicator	-	filtered
O-E2MN	74	(overlap = 5.00 / 6.00)
O-E2MN*PS	24	(overlap = 5.00 / 6.00)*(pattern support = 17 / 22)
O-E2MNPSPU	37	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(1 / 432 (String))
O-E2MNPSPV	30	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(pattern violations = 1 / 18)
O-E2MNPSPV*PU	37	(overlap = 5.00 / 6.00)(pattern support = 17 / 22)(pattern violations = 1 / 18)*(1 / 432 (String))
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	78	(overlap = 5.00 / 6.00)*(1 / 432 (String))
O-E2MN*PV	33	(overlap = 5.00 / 6.00)*(pattern violations = 1 / 18)
O-E2MNPVPU	37	(overlap = 5.00 / 6.00)(pattern violations = 1 / 18)(1 / 432 (String))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	24	(pattern support = 17 / 22)
PS*PU	37	(pattern support = 17 / 22)*(1 / 432 (String))
PS*PV	30	(pattern support = 17 / 22)*(pattern violations = 1 / 18)
PSPVPU	37	(pattern support = 17 / 22)(pattern violations = 1 / 18)(1 / 432 (String))
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	30	(pattern violations = 1 / 18)
PV*PU	37	(pattern violations = 1 / 18)*(1 / 432 (String))
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/server/SocialNetworkAdmin.java#regApprove(Connection, String)
chensun/cf23b99/build/CS5430/src/server/SocialNetworkDBAThread.java#run()
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/client/ClientGUI.java#main(String[])
chensun/cf23b99/build/CS5430/src/client/ClientProcessor.java#processHelp()

194

Strategy	Rank	Desc
	123	()
Confidence	134	11 / (11 + 90)
DefectIndicator	-	filtered
O-E2MN	25	(overlap = 35.00 / 36.00)
O-E2MN*PS	64	(overlap = 35.00 / 36.00)*(pattern support = 11 / 22)
O-E2MNPSPU	71	(overlap = 35.00 / 36.00)(pattern support = 11 / 22)(1 / 432 (String))
O-E2MNPSPV	125	(overlap = 35.00 / 36.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)
O-E2MNPSPV*PU	125	(overlap = 35.00 / 36.00)(pattern support = 11 / 22)(pattern violations = 1 / 90)*(1 / 432 (String))
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	38	(overlap = 35.00 / 36.00)*(1 / 432 (String))
O-E2MN*PV	125	(overlap = 35.00 / 36.00)*(pattern violations = 1 / 90)
O-E2MNPVPU	125	(overlap = 35.00 / 36.00)(pattern violations = 1 / 90)(1 / 432 (String))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	86	(pattern support = 11 / 22)*(1 / 432 (String))
PS*PV	134	(pattern support = 11 / 22)*(pattern violations = 1 / 90)
PSPVPU	134	(pattern support = 11 / 22)(pattern violations = 1 / 90)(1 / 432 (String))
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	127	(1 / 432 (String))
PV	134	(pattern violations = 1 / 90)
PV*PU	134	(pattern violations = 1 / 90)*(1 / 432 (String))
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseBoards.java#createBoard(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseDBA.java#createAcappellaGroup(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabaseRegions.java#createRegion(Connection, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createPost(Connection, String, String, String, String)
chensun/cf23b99/build/CS5430/src/database/SocialNetworkDatabasePosts.java#createReply(Connection, String, String, String, String, int)

225

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	25	(1 / 432 (String)) * 11 / 1
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	19	(overlap = 47.00 / 50.00)(pattern support = 11 / 22)(pattern violations = 1 / 121)*(violation support = 1 / 1)
O-E2MNPSPVVSPU	19	(overlap = 47.00 / 50.00)(pattern support = 11 / 22)(pattern violations = 1 / 121)(violation support = 1 / 1)(1 / 432 (String))
O-E2MNPSVS	5	(overlap = 47.00 / 50.00)(pattern support = 11 / 22)(violation support = 1 / 1)
O-E2MNPSVS*PU	17	(overlap = 47.00 / 50.00)(pattern support = 11 / 22)(violation support = 1 / 1)*(1 / 432 (String))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	19	(overlap = 47.00 / 50.00)(pattern violations = 1 / 121)(violation support = 1 / 1)
O-E2MNPVVS*PU	19	(overlap = 47.00 / 50.00)(pattern violations = 1 / 121)(violation support = 1 / 1)*(1 / 432 (String))
O-E2MN*VS	4	(overlap = 47.00 / 50.00)*(violation support = 1 / 1)
O-E2MNVSPU	17	(overlap = 47.00 / 50.00)(violation support = 1 / 1)(1 / 432 (String))
PS	83	(pattern support = 11 / 22)
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	47	(pattern support = 11 / 22)(pattern violations = 1 / 121)(violation support = 1 / 1)
PSPVVS*PU	47	(pattern support = 11 / 22)(pattern violations = 1 / 121)(violation support = 1 / 1)*(1 / 432 (String))
PS*VS	14	(pattern support = 11 / 22)*(violation support = 1 / 1)
PSVSPU	25	(pattern support = 11 / 22)(violation support = 1 / 1)(1 / 432 (String))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	25	(pattern violations = 1 / 121)*(violation support = 1 / 1)
PVVSPU	25	(pattern violations = 1 / 121)(violation support = 1 / 1)(1 / 432 (String))
Rareness	14	1 - (1 / 11)
VS	14	(violation support = 1 / 1)
VS*PU	25	(violation support = 1 / 1)*(1 / 432 (String))

chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getRegReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendReqCount(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getParticipantsOne(Connection, String, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getFriendRequestList(Connection, String)
chensun/cf23b99/build/CS5430/src/database/DatabaseAdmin.java#getAdminsOfBoard(Connection, String)