Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' closure ' version 319
Misuse:	misuse ' dmmc-1023 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/deps/SortedDependencies.java
In Method:	cycleToString(List)
Code with Misuse:	`class SortedDependencies { /** * @param cycle A cycle in reverse-dependency order. */ private String cycleToString(List<INPUT> cycle) { List<String> symbols = Lists.newArrayList(); for (int i = cycle.size() - 1; i >= 0; i--) { symbols.add(cycle.get(i).getProvides().iterator().next()); } symbols.add(symbols.get(0)); return Joiner.on(" -> ").join(symbols); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

205

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	333	(overlap = 3.00 / 4.00)*(1 / 2142 (Collection))
O-E2MN*PV	1442	(overlap = 3.00 / 4.00)*(pattern violations = 1 / 597)
O-E2MNPVPU	693	(overlap = 3.00 / 4.00)(pattern violations = 1 / 597)(1 / 2142 (Collection))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	1882	(overlap = 3.00 / 4.00)(pattern violations = 1 / 597)(violation support = 1 / 490)*(1 / 2142 (Collection))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	678	(1 / 2142 (Collection))
PV	1813	(pattern violations = 1 / 597)
PV*PU	1031	(pattern violations = 1 / 597)*(1 / 2142 (Collection))
PV*VS	-	filtered
PVVSPU	1882	(pattern violations = 1 / 597)(violation support = 1 / 490)(1 / 2142 (Collection))
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/FunctionInjector.java#inliningLowersCost(JSModule, Node, Collection, Set, boolean, boolean)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode)
closure/319/build/src/com/google/javascript/jscomp/InlineSimpleMethods.java#visit(NodeTraversal, Node, Node, String)
closure/319/build/src/com/google/javascript/jscomp/ConcreteType.java#createForTypes(Collection)
closure/319/build/src/com/google/javascript/jscomp/CallGraph.java#getUniqueFunctionWithName(String)

5493

Strategy	Rank	Desc
	888	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	149	(overlap = 8.00 / 11.00)*(violation support = 1 / 3)
O-E2MNVSPU	168	(overlap = 8.00 / 11.00)(violation support = 1 / 3)(1 / 2142 (Collection))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	122	(violation support = 1 / 3)
VS*PU	155	(violation support = 1 / 3)*(1 / 2142 (Collection))

closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap)
closure/319/build/src/com/google/javascript/jscomp/JSModuleGraph.java#JSModuleGraph(List)
closure/319/build/src/com/google/javascript/jscomp/DisambiguateProperties.java#expandTypesToSkip()
closure/319/build/src/com/google/javascript/rhino/jstype/PrototypeObjectType.java#toString()
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode)

7259

Strategy	Rank	Desc
	-	filtered
Confidence	7	387 / (387 + 30)
DefectIndicator	41	(1 / 2142 (Collection)) * 387 / 6
O-E2MN	1749	(overlap = 8.00 / 10.00)
O-E2MN*PS	8	(overlap = 8.00 / 10.00)*(pattern support = 387 / 387)
O-E2MNPSPU	46	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(1 / 2142 (Collection))
O-E2MNPSPV	8	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)
O-E2MNPSPV*PU	44	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(1 / 2142 (Collection))
O-E2MNPSPV*VS	21	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(violation support = 1 / 6)
O-E2MNPSPVVSPU	31	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 6)(1 / 2142 (Collection))
O-E2MNPSVS	21	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(violation support = 1 / 6)
O-E2MNPSVS*PU	32	(overlap = 8.00 / 10.00)(pattern support = 387 / 387)(violation support = 1 / 6)*(1 / 2142 (Collection))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	54	(overlap = 8.00 / 10.00)(pattern violations = 1 / 30)(violation support = 1 / 6)
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	7	(pattern support = 387 / 387)
PS*PU	45	(pattern support = 387 / 387)*(1 / 2142 (Collection))
PS*PV	7	(pattern support = 387 / 387)*(pattern violations = 1 / 30)
PSPVPU	50	(pattern support = 387 / 387)(pattern violations = 1 / 30)(1 / 2142 (Collection))
PSPVVS	28	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 6)
PSPVVS*PU	36	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 6)*(1 / 2142 (Collection))
PS*VS	26	(pattern support = 387 / 387)*(violation support = 1 / 6)
PSVSPU	41	(pattern support = 387 / 387)(violation support = 1 / 6)(1 / 2142 (Collection))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	61	(pattern violations = 1 / 30)*(violation support = 1 / 6)
PVVSPU	-	filtered
Rareness	26	1 - (6 / 387)
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/InlineFunctions.java#resolveInlineConflictsForFunction(FunctionState)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#setOut(List)
closure/319/build/src/com/google/javascript/jscomp/LinkedFlowScope.java#equals(Object)
closure/319/build/src/com/google/javascript/jscomp/NameReferenceGraphConstruction.java#recordSubclassPrototypePropUse(FunctionType, String, Reference)
closure/319/build/src/com/google/javascript/jscomp/graph/LinkedDirectedGraph.java#getDirectedSuccNodes(DiGraphNode)

387

8551

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	215	(overlap = 3.00 / 4.00)*(1 / 1004 (Iterator))
O-E2MN*PV	18	(overlap = 3.00 / 4.00)*(pattern violations = 1 / 27)
O-E2MNPVPU	181	(overlap = 3.00 / 4.00)(pattern violations = 1 / 27)(1 / 1004 (Iterator))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	125	(overlap = 3.00 / 4.00)(pattern violations = 1 / 27)(violation support = 1 / 11)*(1 / 1004 (Iterator))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	215	(1 / 1004 (Iterator))
PV	41	(pattern violations = 1 / 27)
PV*PU	180	(pattern violations = 1 / 27)*(1 / 1004 (Iterator))
PV*VS	-	filtered
PVVSPU	123	(pattern violations = 1 / 27)(violation support = 1 / 11)(1 / 1004 (Iterator))
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/deps/JsFunctionParser.java#parseLine(String)
closure/319/build/src/com/google/javascript/jscomp/Compiler.java#reportCodeChange()
closure/319/build/src/com/google/javascript/jscomp/TypedScopeCreator.java#resolveTypes()
closure/319/build/src/com/google/javascript/rhino/jstype/UnionType.java#getLeastSupertype(JSType)
closure/319/build/src/com/google/javascript/jscomp/GlobalNamespace.java#canEliminate()

139

8929

Strategy	Rank	Desc
	887	()
Confidence	1811	12 / (12 + 597)
DefectIndicator	804	(1 / 2142 (Collection)) * 12 / 88
O-E2MN	2247	(overlap = 3.00 / 4.00)
O-E2MN*PS	3339	(overlap = 3.00 / 4.00)*(pattern support = 12 / 387)
O-E2MNPSPU	440	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(1 / 2142 (Collection))
O-E2MNPSPV	1473	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(pattern violations = 1 / 597)
O-E2MNPSPV*PU	889	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(pattern violations = 1 / 597)*(1 / 2142 (Collection))
O-E2MNPSPV*VS	1509	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(pattern violations = 1 / 597)*(violation support = 1 / 88)
O-E2MNPSPVVSPU	1055	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(pattern violations = 1 / 597)(violation support = 1 / 88)(1 / 2142 (Collection))
O-E2MNPSVS	1619	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(violation support = 1 / 88)
O-E2MNPSVS*PU	804	(overlap = 3.00 / 4.00)(pattern support = 12 / 387)(violation support = 1 / 88)*(1 / 2142 (Collection))
O-E2MN*PU	332	(overlap = 3.00 / 4.00)*(1 / 2142 (Collection))
O-E2MN*PV	1441	(overlap = 3.00 / 4.00)*(pattern violations = 1 / 597)
O-E2MNPVPU	692	(overlap = 3.00 / 4.00)(pattern violations = 1 / 597)(1 / 2142 (Collection))
O-E2MNPVVS	1508	(overlap = 3.00 / 4.00)(pattern violations = 1 / 597)(violation support = 1 / 88)
O-E2MNPVVS*PU	900	(overlap = 3.00 / 4.00)(pattern violations = 1 / 597)(violation support = 1 / 88)*(1 / 2142 (Collection))
O-E2MN*VS	1432	(overlap = 3.00 / 4.00)*(violation support = 1 / 88)
O-E2MNVSPU	794	(overlap = 3.00 / 4.00)(violation support = 1 / 88)(1 / 2142 (Collection))
PS	4085	(pattern support = 12 / 387)
PS*PU	719	(pattern support = 12 / 387)*(1 / 2142 (Collection))
PS*PV	1811	(pattern support = 12 / 387)*(pattern violations = 1 / 597)
PSPVPU	1229	(pattern support = 12 / 387)(pattern violations = 1 / 597)(1 / 2142 (Collection))
PSPVVS	1572	(pattern support = 12 / 387)(pattern violations = 1 / 597)(violation support = 1 / 88)
PSPVVS*PU	1123	(pattern support = 12 / 387)(pattern violations = 1 / 597)(violation support = 1 / 88)*(1 / 2142 (Collection))
PS*VS	1793	(pattern support = 12 / 387)*(violation support = 1 / 88)
PSVSPU	804	(pattern support = 12 / 387)(violation support = 1 / 88)(1 / 2142 (Collection))
PU	677	(1 / 2142 (Collection))
PV	1812	(pattern violations = 1 / 597)
PV*PU	1030	(pattern violations = 1 / 597)*(1 / 2142 (Collection))
PV*VS	1572	(pattern violations = 1 / 597)*(violation support = 1 / 88)
PVVSPU	904	(pattern violations = 1 / 597)(violation support = 1 / 88)(1 / 2142 (Collection))
Rareness	1793	1 - (88 / 12)
VS	1792	(violation support = 1 / 88)
VS*PU	773	(violation support = 1 / 88)*(1 / 2142 (Collection))

closure/319/build/src/com/google/javascript/jscomp/FunctionInjector.java#inliningLowersCost(JSModule, Node, Collection, Set, boolean, boolean)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode)
closure/319/build/src/com/google/javascript/jscomp/InlineSimpleMethods.java#visit(NodeTraversal, Node, Node, String)
closure/319/build/src/com/google/javascript/jscomp/ConcreteType.java#createForTypes(Collection)
closure/319/build/src/com/google/javascript/jscomp/CallGraph.java#getUniqueFunctionWithName(String)