Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' closure ' version 319
Misuse:	misuse ' tikanga-2 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/JSModuleGraph.java
In Method:	getDeepestCommonDependencyInclusive(Collection)
Code with Misuse:	`class JSModuleGraph { /** Returns the deepest common dependency of the given modules. */ public JSModule getDeepestCommonDependencyInclusive( Collection<JSModule> modules) { Iterator<JSModule> iter = modules.iterator(); JSModule dep = iter.next(); while (iter.hasNext()) { dep = getDeepestCommonDependencyInclusive(dep, iter.next()); } return dep; } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

6747

Strategy	Rank	Desc
	-	filtered
Confidence	10	387 / (387 + 30)
DefectIndicator	32	(1 / 2142 (Collection)) * 387 / 5
O-E2MN	1940	(overlap = 11.00 / 14.00)
O-E2MN*PS	14	(overlap = 11.00 / 14.00)*(pattern support = 387 / 387)
O-E2MNPSPU	52	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(1 / 2142 (Collection))
O-E2MNPSPV	14	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)
O-E2MNPSPV*PU	50	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(1 / 2142 (Collection))
O-E2MNPSPV*VS	15	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(violation support = 1 / 5)
O-E2MNPSPVVSPU	25	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)(1 / 2142 (Collection))
O-E2MNPSVS	15	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 5)
O-E2MNPSVS*PU	22	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 5)*(1 / 2142 (Collection))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	45	(overlap = 11.00 / 14.00)(pattern violations = 1 / 30)(violation support = 1 / 5)
O-E2MNPVVS*PU	134	(overlap = 11.00 / 14.00)(pattern violations = 1 / 30)(violation support = 1 / 5)*(1 / 2142 (Collection))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	10	(pattern support = 387 / 387)
PS*PU	48	(pattern support = 387 / 387)*(1 / 2142 (Collection))
PS*PV	10	(pattern support = 387 / 387)*(pattern violations = 1 / 30)
PSPVPU	53	(pattern support = 387 / 387)(pattern violations = 1 / 30)(1 / 2142 (Collection))
PSPVVS	17	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)
PSPVVS*PU	27	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)*(1 / 2142 (Collection))
PS*VS	17	(pattern support = 387 / 387)*(violation support = 1 / 5)
PSVSPU	32	(pattern support = 387 / 387)(violation support = 1 / 5)(1 / 2142 (Collection))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	49	(pattern violations = 1 / 30)*(violation support = 1 / 5)
PVVSPU	-	filtered
Rareness	17	1 - (5 / 387)
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/InlineFunctions.java#resolveInlineConflictsForFunction(FunctionState)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#setOut(List)
closure/319/build/src/com/google/javascript/jscomp/LinkedFlowScope.java#equals(Object)
closure/319/build/src/com/google/javascript/jscomp/NameReferenceGraphConstruction.java#recordSubclassPrototypePropUse(FunctionType, String, Reference)
closure/319/build/src/com/google/javascript/jscomp/graph/LinkedDirectedGraph.java#getDirectedSuccNodes(DiGraphNode)

387

6913

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	187	(overlap = 11.00 / 15.00)(violation support = 1 / 4)(1 / 2142 (Collection))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	232	(violation support = 1 / 4)*(1 / 2142 (Collection))

closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap)
closure/319/build/src/com/google/javascript/jscomp/JSModuleGraph.java#JSModuleGraph(List)
closure/319/build/src/com/google/javascript/jscomp/DisambiguateProperties.java#expandTypesToSkip()
closure/319/build/src/com/google/javascript/rhino/jstype/PrototypeObjectType.java#toString()
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode)

7281

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	107	(overlap = 11.00 / 16.00)*(violation support = 1 / 2)
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	73	(violation support = 1 / 2)
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/NameAnalyzer.java#getRhsSubexpressions(Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#isSubexpressionMovable(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/JsMessageVisitor.java#extractFromReturnDescendant(Builder, Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#extractExpression(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/TypeCheck.java#visitVar(NodeTraversal, Node)

9865

Strategy	Rank	Desc
	1349	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	226	(overlap = 5.00 / 7.00)*(1 / 1004 (Iterator))
O-E2MN*PV	62	(overlap = 5.00 / 7.00)*(pattern violations = 1 / 27)
O-E2MNPVPU	192	(overlap = 5.00 / 7.00)(pattern violations = 1 / 27)(1 / 1004 (Iterator))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	217	(1 / 1004 (Iterator))
PV	49	(pattern violations = 1 / 27)
PV*PU	182	(pattern violations = 1 / 27)*(1 / 1004 (Iterator))
PV*VS	-	filtered
PVVSPU	125	(pattern violations = 1 / 27)(violation support = 1 / 11)(1 / 1004 (Iterator))
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/deps/JsFunctionParser.java#parseLine(String)
closure/319/build/src/com/google/javascript/jscomp/Compiler.java#reportCodeChange()
closure/319/build/src/com/google/javascript/jscomp/TypedScopeCreator.java#resolveTypes()
closure/319/build/src/com/google/javascript/rhino/jstype/UnionType.java#getLeastSupertype(JSType)
closure/319/build/src/com/google/javascript/jscomp/GlobalNamespace.java#canEliminate()

139