Review

Detector:	MuDetectRankComp_180222_ExcludeInstances
Target:	project ' closure ' version 319
Misuse:	misuse ' tikanga-6 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/TypeCheck.java
In Method:	visitParameterList(NodeTraversal, Node, FunctionType)
Code with Misuse:	class TypeCheck { /** * Visits the parameters of a CALL or a NEW node. */ private void visitParameterList(NodeTraversal t, Node call, FunctionType functionType) { Iterator<Node> arguments = call.children().iterator(); arguments.next(); // skip the function name Iterator<Node> parameters = functionType.getParameters().iterator(); int ordinal = 0; Node parameter = null; Node argument = null; while (arguments.hasNext() && (parameters.hasNext() \|\| parameter != null && parameter.isVarArgs())) { // If there are no parameters left in the list, then the while loop // above implies that this must be a var_args function. if (parameters.hasNext()) { parameter = parameters.next(); } argument = arguments.next(); ordinal++; validator.expectArgumentMatchesParameter(t, argument, getJSType(argument), getJSType(parameter), call, ordinal); } int numArgs = call.getChildCount() - 1; int minArgs = functionType.getMinArguments(); int maxArgs = functionType.getMaxArguments(); if (minArgs > numArgs \|\| maxArgs < numArgs) { report(t, call, WRONG_ARGUMENT_COUNT, validator.getReadableJSTypeName(call.getFirstChild(), false), String.valueOf(numArgs), String.valueOf(minArgs), maxArgs != Integer.MAX_VALUE ? " and no more than " + maxArgs + " argument(s)" : ""); } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit

Rank

Confidence

Confidence String

Pattern Examples

Pattern Support

Pattern Violation

Target Environment Mapping

780

Strategy	Rank	Desc
	4420	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	1676	(overlap = 18.00 / 22.00)
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	140	(overlap = 18.00 / 22.00)*(violation support = 1 / 3)
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	169	(violation support = 1 / 3)
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/NameAnalyzer.java#getRhsSubexpressions(Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#isSubexpressionMovable(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/JsMessageVisitor.java#extractFromReturnDescendant(Builder, Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#extractExpression(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/TypeCheck.java#visitVar(NodeTraversal, Node)

2605

Strategy	Rank	Desc
	-	filtered
Confidence	28	387 / (387 + 30)
DefectIndicator	5	(1 / 2142 (Collection)) * 387 / 1
O-E2MN	56	(overlap = 13.00 / 14.00)
O-E2MN*PS	0	(overlap = 13.00 / 14.00)*(pattern support = 387 / 387)
O-E2MNPSPU	31	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(1 / 2142 (Collection))
O-E2MNPSPV	0	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)
O-E2MNPSPV*PU	34	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(1 / 2142 (Collection))
O-E2MNPSPV*VS	0	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(violation support = 1 / 1)
O-E2MNPSPVVSPU	3	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 1)(1 / 2142 (Collection))
O-E2MNPSVS	0	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 1)
O-E2MNPSVS*PU	3	(overlap = 13.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 1)*(1 / 2142 (Collection))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	6	(overlap = 13.00 / 14.00)(pattern violations = 1 / 30)(violation support = 1 / 1)
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	8	(overlap = 13.00 / 14.00)*(violation support = 1 / 1)
O-E2MNVSPU	78	(overlap = 13.00 / 14.00)(violation support = 1 / 1)(1 / 2142 (Collection))
PS	28	(pattern support = 387 / 387)
PS*PU	66	(pattern support = 387 / 387)*(1 / 2142 (Collection))
PS*PV	28	(pattern support = 387 / 387)*(pattern violations = 1 / 30)
PSPVPU	71	(pattern support = 387 / 387)(pattern violations = 1 / 30)(1 / 2142 (Collection))
PSPVVS	2	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 1)
PSPVVS*PU	7	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 1)*(1 / 2142 (Collection))
PS*VS	2	(pattern support = 387 / 387)*(violation support = 1 / 1)
PSVSPU	5	(pattern support = 387 / 387)(violation support = 1 / 1)(1 / 2142 (Collection))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	8	(pattern violations = 1 / 30)*(violation support = 1 / 1)
PVVSPU	-	filtered
Rareness	2	1 - (1 / 387)
VS	65	(violation support = 1 / 1)
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/InlineFunctions.java#resolveInlineConflictsForFunction(FunctionState)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#setOut(List)
closure/319/build/src/com/google/javascript/jscomp/LinkedFlowScope.java#equals(Object)
closure/319/build/src/com/google/javascript/jscomp/NameReferenceGraphConstruction.java#recordSubclassPrototypePropUse(FunctionType, String, Reference)
closure/319/build/src/com/google/javascript/jscomp/graph/LinkedDirectedGraph.java#getDirectedSuccNodes(DiGraphNode)

387

5528

Strategy	Rank	Desc
	-	filtered
Confidence	29	387 / (387 + 30)
DefectIndicator	38	(1 / 2142 (Collection)) * 387 / 5
O-E2MN	-	filtered
O-E2MN*PS	18	(overlap = 11.00 / 14.00)*(pattern support = 387 / 387)
O-E2MNPSPU	56	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(1 / 2142 (Collection))
O-E2MNPSPV	18	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)
O-E2MNPSPV*PU	54	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(1 / 2142 (Collection))
O-E2MNPSPV*VS	18	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)*(violation support = 1 / 5)
O-E2MNPSPVVSPU	28	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)(1 / 2142 (Collection))
O-E2MNPSVS	18	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 5)
O-E2MNPSVS*PU	25	(overlap = 11.00 / 14.00)(pattern support = 387 / 387)(violation support = 1 / 5)*(1 / 2142 (Collection))
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	48	(overlap = 11.00 / 14.00)(pattern violations = 1 / 30)(violation support = 1 / 5)
O-E2MNPVVS*PU	137	(overlap = 11.00 / 14.00)(pattern violations = 1 / 30)(violation support = 1 / 5)*(1 / 2142 (Collection))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	29	(pattern support = 387 / 387)
PS*PU	67	(pattern support = 387 / 387)*(1 / 2142 (Collection))
PS*PV	29	(pattern support = 387 / 387)*(pattern violations = 1 / 30)
PSPVPU	72	(pattern support = 387 / 387)(pattern violations = 1 / 30)(1 / 2142 (Collection))
PSPVVS	23	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)
PSPVVS*PU	33	(pattern support = 387 / 387)(pattern violations = 1 / 30)(violation support = 1 / 5)*(1 / 2142 (Collection))
PS*VS	23	(pattern support = 387 / 387)*(violation support = 1 / 5)
PSVSPU	38	(pattern support = 387 / 387)(violation support = 1 / 5)(1 / 2142 (Collection))
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	55	(pattern violations = 1 / 30)*(violation support = 1 / 5)
PVVSPU	-	filtered
Rareness	23	1 - (5 / 387)
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/InlineFunctions.java#resolveInlineConflictsForFunction(FunctionState)
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#setOut(List)
closure/319/build/src/com/google/javascript/jscomp/LinkedFlowScope.java#equals(Object)
closure/319/build/src/com/google/javascript/jscomp/NameReferenceGraphConstruction.java#recordSubclassPrototypePropUse(FunctionType, String, Reference)
closure/319/build/src/com/google/javascript/jscomp/graph/LinkedDirectedGraph.java#getDirectedSuccNodes(DiGraphNode)

387

5625

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	182	(overlap = 6.00 / 7.00)*(1 / 1004 (Iterator))
O-E2MN*PV	9	(overlap = 6.00 / 7.00)*(pattern violations = 1 / 27)
O-E2MNPVPU	176	(overlap = 6.00 / 7.00)(pattern violations = 1 / 27)(1 / 1004 (Iterator))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	66	(overlap = 6.00 / 7.00)(pattern violations = 1 / 27)(violation support = 1 / 2)*(1 / 1004 (Iterator))
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	233	(1 / 1004 (Iterator))
PV	83	(pattern violations = 1 / 27)
PV*PU	198	(pattern violations = 1 / 27)*(1 / 1004 (Iterator))
PV*VS	-	filtered
PVVSPU	67	(pattern violations = 1 / 27)(violation support = 1 / 2)(1 / 1004 (Iterator))
Rareness	-	filtered
VS	-	filtered
VS*PU	81	(violation support = 1 / 2)*(1 / 1004 (Iterator))

closure/319/build/src/com/google/javascript/jscomp/deps/JsFunctionParser.java#parseLine(String)
closure/319/build/src/com/google/javascript/jscomp/Compiler.java#reportCodeChange()
closure/319/build/src/com/google/javascript/jscomp/TypedScopeCreator.java#resolveTypes()
closure/319/build/src/com/google/javascript/rhino/jstype/UnionType.java#getLeastSupertype(JSType)
closure/319/build/src/com/google/javascript/jscomp/GlobalNamespace.java#canEliminate()

139

7297

Strategy	Rank	Desc
	4421	()
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/NameAnalyzer.java#getRhsSubexpressions(Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#isSubexpressionMovable(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/JsMessageVisitor.java#extractFromReturnDescendant(Builder, Node)
closure/319/build/src/com/google/javascript/jscomp/ExpressionDecomposer.java#extractExpression(Node, Node)
closure/319/build/src/com/google/javascript/jscomp/TypeCheck.java#visitVar(NodeTraversal, Node)

7935

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	233	(overlap = 5.00 / 7.00)*(1 / 1004 (Iterator))
O-E2MN*PV	84	(overlap = 5.00 / 7.00)*(pattern violations = 1 / 27)
O-E2MNPVPU	199	(overlap = 5.00 / 7.00)(pattern violations = 1 / 27)(1 / 1004 (Iterator))
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	-	filtered
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	234	(1 / 1004 (Iterator))
PV	84	(pattern violations = 1 / 27)
PV*PU	199	(pattern violations = 1 / 27)*(1 / 1004 (Iterator))
PV*VS	-	filtered
PVVSPU	134	(pattern violations = 1 / 27)(violation support = 1 / 11)(1 / 1004 (Iterator))
Rareness	-	filtered
VS	-	filtered
VS*PU	-	filtered

closure/319/build/src/com/google/javascript/jscomp/deps/JsFunctionParser.java#parseLine(String)
closure/319/build/src/com/google/javascript/jscomp/Compiler.java#reportCodeChange()
closure/319/build/src/com/google/javascript/jscomp/TypedScopeCreator.java#resolveTypes()
closure/319/build/src/com/google/javascript/rhino/jstype/UnionType.java#getLeastSupertype(JSType)
closure/319/build/src/com/google/javascript/jscomp/GlobalNamespace.java#canEliminate()

139

9375

Strategy	Rank	Desc
	-	filtered
Confidence	-	filtered
DefectIndicator	-	filtered
O-E2MN	-	filtered
O-E2MN*PS	-	filtered
O-E2MNPSPU	-	filtered
O-E2MNPSPV	-	filtered
O-E2MNPSPV*PU	-	filtered
O-E2MNPSPV*VS	-	filtered
O-E2MNPSPVVSPU	-	filtered
O-E2MNPSVS	-	filtered
O-E2MNPSVS*PU	-	filtered
O-E2MN*PU	-	filtered
O-E2MN*PV	-	filtered
O-E2MNPVPU	-	filtered
O-E2MNPVVS	-	filtered
O-E2MNPVVS*PU	-	filtered
O-E2MN*VS	-	filtered
O-E2MNVSPU	190	(overlap = 11.00 / 15.00)(violation support = 1 / 4)(1 / 2142 (Collection))
PS	-	filtered
PS*PU	-	filtered
PS*PV	-	filtered
PSPVPU	-	filtered
PSPVVS	-	filtered
PSPVVS*PU	-	filtered
PS*VS	-	filtered
PSVSPU	-	filtered
PU	-	filtered
PV	-	filtered
PV*PU	-	filtered
PV*VS	-	filtered
PVVSPU	-	filtered
Rareness	-	filtered
VS	-	filtered
VS*PU	235	(violation support = 1 / 4)*(1 / 2142 (Collection))

closure/319/build/src/com/google/javascript/jscomp/deps/SortedDependencies.java#topologicalStableSort(List, Multimap)
closure/319/build/src/com/google/javascript/jscomp/JSModuleGraph.java#JSModuleGraph(List)
closure/319/build/src/com/google/javascript/jscomp/DisambiguateProperties.java#expandTypesToSkip()
closure/319/build/src/com/google/javascript/rhino/jstype/PrototypeObjectType.java#toString()
closure/319/build/src/com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraphNode)