Review

Detector:	MuDetectXP
Target:	project ' synthetic_jca ' version jsl
Misuse:	misuse ' loop-init '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	The usage iterates over a data stream to encrypt all values fetched from it. During the iteration, the same `Cipher` instance is reused for the encryption tasks---which is fine---, but it is also reinitialized with each iteration. `Cipher` does not support reinitialization and, hence, this may lead to erroneous encryption.
Fix Description:	The `init()` call should happen before the loop.
Violation Types:	superfluous/iteration
In File:	mubench/examples/jca/ReinitializingCipher.java
In Method:	misuse(BufferedReader, Key)
Code with Misuse:	class ReinitializingCipher { List<byte[]> misuse(BufferedReader dataStream, Key key) throws NoSuchPaddingException, NoSuchAlgorithmException, IOException, InvalidKeyException, BadPaddingException, IllegalBlockSizeException { Cipher cipher = Cipher.getInstance("AES/CBC/NoPadding"); String line; List<byte[]> encryptedData = new java.util.ArrayList<byte[]>(); while ((line = dataStream.readLine()) != null) { cipher.init(Cipher.ENCRYPT_MODE, key); encryptedData.add(cipher.doFinal(line.getBytes("utf-8"))); } return encryptedData; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	0	0.5555555555555556	(pattern support = 5 / 7)(pattern violations = 1 / 1)(overlap = 14.00 / 18.00)	_examples/taonico/NicoLivePlayer/latest/checkout/NicoLivePlayer/src/jp/tao/nico/live/NicoCrypt.java#encrypt(String, String) _examples/Commortel/ProjetCryptographie/latest/checkout/ProjetCryptographie/src/tools/CryptoTools.java#encrypt3DES(byte[], String) _examples/suvethak/CloudSecurity/latest/checkout/src/my/clientdetailsui/Decrypt.java#main(String) _examples/luiskcs89/thesiskunagi/latest/checkout/ilarkesto/src/main/java/ilarkesto/base/Crypt.java#decrypt(byte[], byte[]) _examples/luiskcs89/thesiskunagi/latest/checkout/ilarkesto/src/main/java/ilarkesto/base/Crypt.java#encrypt(byte[], byte[])	5
?	4	0.15625	(pattern support = 7 / 7)(pattern violations = 1 / 2)(overlap = 5.00 / 16.00)	_examples/ltguide/AppEngine-MineBackup/latest/checkout/src/ltguide/minebackup/MineBackup.java#sign(String, String, String, String) _examples/slok/mdissphoto/latest/checkout/mdiss-api/src/main/java/org/mdissjava/api/helpers/ApiHelper.java#calculateHMAC(String, String, String, String, String) _examples/Semantria/semantria-sdk/latest/checkout/Java/src/main/java/com/semantria/utils/AuthRequest.java#signRequest(String, String) _examples/michael-andre/Wapplix/latest/checkout/src/main/java/com/wapplix/data/OAuth10Signer.java#getSignature(String, String) _examples/tcz001/SNSCrawlerOSGiFramework/latest/checkout/ScribeOAuthAPIBundle/src/main/java/org/scribe/services/HMACSha1SignatureService.java#doSign(String, String)	7