Review

Detector:	MuDetectXP
Target:	project ' tbuktu-ntru ' version 8126929
Misuse:	misuse ' 473 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	When a DataOutputStream instance wraps an underlying OutputStream instance, it is recommended to flush or close the DataOutputStream before operating on the OutputStream. Although in these cases this is not strictly necessary because the DataOutputStream's close and flush method has no effects. However, it is a good practice to call flush/close explicitly as mentioned for example here. This pull request adds a call to flush.
Fix Description:	(see diff)
Violation Types:	missing/call
In File:	net/sf/ntru/encrypt/EncryptionParameters.java
In Method:	writeTo(OutputStream)
Code with Misuse:	class EncryptionParameters { /** * Writes the parameter set to an output stream * @param os an output stream * @throws IOException */ public void writeTo(OutputStream os) throws IOException { DataOutputStream dos = new DataOutputStream(os); dos.writeInt(N); dos.writeInt(q); dos.writeInt(df); dos.writeInt(df1); dos.writeInt(df2); dos.writeInt(df3); dos.writeInt(db); dos.writeInt(dm0); dos.writeInt(maxM1); dos.writeInt(c); dos.writeInt(minCallsR); dos.writeInt(minCallsMask); dos.writeBoolean(hashSeed); dos.write(oid); dos.writeBoolean(sparse); dos.writeBoolean(fastFp); dos.write(polyType.ordinal()); dos.writeUTF(hashAlg); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	0	0.45454545454545453	(pattern support = 6 / 6)(pattern violations = 1 / 2)(overlap = 10.00 / 11.00)	_examples/weyzohorth/DungeonCrawler/latest/checkout/DungeonCrawler/src/org/newdawn/slick/muffin/WebstartMuffin.java#saveFile(HashMap, String) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/paragjain16/KeyValueDS/latest/checkout/DSProject/src/org/ds/socket/DSocket.java#write(String) _examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/parserR2/Reranker.java#writeModell(OptionsSuper, ParametersFloat, String, Cluster) _examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/parser/Parser.java#writeModell(OptionsSuper, ParametersFloat, String, Cluster)	6
?	8	0.15625	(pattern support = 5 / 6)(pattern violations = 1 / 2)(overlap = 3.00 / 8.00)	_examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/mtag/MFO.java#writeData(DataOutputStream) _examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/tag/MFO.java#writeData(DataOutputStream) _examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/lemmatizer/MFO.java#writeData(DataOutputStream) _examples/mojtaba-khallash/dependency-parsing-toolbox/latest/checkout/Source/mate-tools/src/is2/data/MFC.java#writeData(DataOutputStream) _examples/taylorrobert/ProjectM2O/latest/checkout/lib/slick/src/org/newdawn/slick/muffin/WebstartMuffin.java#saveFile(HashMap, String)	5
?	13	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	14	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	16	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	17	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	20	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	22	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	23	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	24	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	26	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	27	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	29	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5
?	30	0.02893518518518519	(pattern support = 5 / 6)(pattern violations = 1 / 24)(overlap = 10.00 / 12.00)	_examples/camptocamp/secureOWS/latest/checkout/owsproxyserver/src/org/deegree/io/rtree/PersistentPageFile.java#writeNode(Node) _examples/goodow/gwt/latest/checkout/dev/core/src/com/google/gwt/dev/asm/commons/SerialVersionUIDAdder.java#computeSVUID() _examples/OMFGB/packages_apps_Browser/latest/checkout/src/com/android/browser/BrowserBackupAgent.java#buildBookmarkFile(FileOutputStream) _examples/Mithrandir0x/JNRPE-LIB/latest/checkout/src/it/jnrpe/net/CJNRPEProtocolPacket.java#validate() _examples/sddjeremy/mlz/latest/checkout/Client/src/minecraft_server/net/minecraft/src/EntityPlayerMP.java#func_71030_a(IMerchant)	5