Review

Detector:	MuDetect_180212_FixSeqOrder
Target:	project ' testng ' version cd80791
Misuse:	misuse ' 21 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	In Model.java:49, the synchronized map returned by suite.getResults() is iterated over in an unsynchronized manner, but according to the Oracle Java 7 API specification, this is not thread-safe and can lead to non-deterministic behavior. This pull request adds a fix by synchronizing the iteration.
Fix Description:	(see diff)
Violation Types:	missing/condition/synchronization
In File:	org/testng/reporters/jq/Model.java
In Method:	init()
Code with Misuse:	class Model { private void init() { int testCounter = 0; for (ISuite suite : m_suites) { List<ITestResult> passed = Lists.newArrayList(); List<ITestResult> failed = Lists.newArrayList(); List<ITestResult> skipped = Lists.newArrayList(); for (ISuiteResult sr : suite.getResults().values()) { ITestContext context = sr.getTestContext(); m_testTags.put(context.getName(), "test-" + testCounter++); failed.addAll(context.getFailedTests().getAllResults()); skipped.addAll(context.getSkippedTests().getAllResults()); passed.addAll(context.getPassedTests().getAllResults()); IResultMap[] map = new IResultMap[] { context.getFailedTests(), context.getSkippedTests(), context.getPassedTests() }; for (IResultMap m : map) { for (ITestResult tr : m.getAllResults()) { m_testResultMap.put(tr, getTestResultName(tr)); } } } // Process them in the order passed, skipped and failed, so that the failed // icon overrides all the others and the skipped icon overrides passed. // Passed { ResultsByClass rbc = new ResultsByClass(); for (ITestResult tr : passed) { rbc.addResult(tr.getTestClass().getRealClass(), tr); updateGroups(suite, tr); } m_passedResultsByClass.put(suite, rbc); } // Skipped { ResultsByClass rbc = new ResultsByClass(); for (ITestResult tr : skipped) { m_statusBySuiteName.put(suite.getName(), "skipped"); rbc.addResult(tr.getTestClass().getRealClass(), tr); updateGroups(suite, tr); } m_skippedResultsByClass.put(suite, rbc); } // Failed { ResultsByClass rbc = new ResultsByClass(); for (ITestResult tr : failed) { m_statusBySuiteName.put(suite.getName(), "failed"); rbc.addResult(tr.getTestClass().getRealClass(), tr); m_allFailedResults.add(tr); updateGroups(suite, tr); } m_failedResultsByClass.put(suite, rbc); } m_model.putAll(suite, failed); m_model.putAll(suite, skipped); m_model.putAll(suite, passed); } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	227	0.00611608071562305	(pattern support = 21 / 23)(pattern violations = 1 / 95)(overlap = 7.00 / 11.00)	testng/cd80791/build/src/main/java/org/testng/reporters/XMLSuiteResultWriter.java#addTestResults(XMLStringBuffer, Set) testng/cd80791/build/src/main/java/org/testng/reporters/JUnitReportReporter.java#generateReport(List, List, String) testng/cd80791/build/src/main/java/org/testng/Assert.java#assertEquals(Map, Map) testng/cd80791/build/src/main/java/org/testng/xml/XmlSuite.java#getAllParameters() testng/cd80791/build/src/main/java/org/testng/xml/XmlUtils.java#dumpParameters(XMLStringBuffer, Map)	21
?	1749	0.0008181393174380551	(pattern support = 10 / 23)(pattern violations = 1 / 465)(overlap = 7.00 / 8.00)	testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#keepSameInstances(ITestNGMethod, Set) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#createClassBasedParallelWorkers(List) testng/cd80791/build/src/main/java/org/testng/TestNG.java#checkTestNames(List) testng/cd80791/build/src/main/java/org/testng/internal/DynamicGraph.java#getUnfinishedNodes(List) testng/cd80791/build/src/main/java/org/testng/reporters/FailedReporter.java#generateXmlTest(ISuite, XmlTest, ITestContext, Collection, Collection)	10
?	1750	0.0008181393174380551	(pattern support = 10 / 23)(pattern violations = 1 / 465)(overlap = 7.00 / 8.00)	testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#keepSameInstances(ITestNGMethod, Set) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#createClassBasedParallelWorkers(List) testng/cd80791/build/src/main/java/org/testng/TestNG.java#checkTestNames(List) testng/cd80791/build/src/main/java/org/testng/internal/DynamicGraph.java#getUnfinishedNodes(List) testng/cd80791/build/src/main/java/org/testng/reporters/FailedReporter.java#generateXmlTest(ISuite, XmlTest, ITestContext, Collection, Collection)	10
?	1751	0.0008181393174380551	(pattern support = 10 / 23)(pattern violations = 1 / 465)(overlap = 7.00 / 8.00)	testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#keepSameInstances(ITestNGMethod, Set) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#createClassBasedParallelWorkers(List) testng/cd80791/build/src/main/java/org/testng/TestNG.java#checkTestNames(List) testng/cd80791/build/src/main/java/org/testng/internal/DynamicGraph.java#getUnfinishedNodes(List) testng/cd80791/build/src/main/java/org/testng/reporters/FailedReporter.java#generateXmlTest(ISuite, XmlTest, ITestContext, Collection, Collection)	10
?	1752	0.0008181393174380551	(pattern support = 10 / 23)(pattern violations = 1 / 465)(overlap = 7.00 / 8.00)	testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#keepSameInstances(ITestNGMethod, Set) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#createClassBasedParallelWorkers(List) testng/cd80791/build/src/main/java/org/testng/TestNG.java#checkTestNames(List) testng/cd80791/build/src/main/java/org/testng/internal/DynamicGraph.java#getUnfinishedNodes(List) testng/cd80791/build/src/main/java/org/testng/reporters/FailedReporter.java#generateXmlTest(ISuite, XmlTest, ITestContext, Collection, Collection)	10
?	1753	0.0008181393174380551	(pattern support = 10 / 23)(pattern violations = 1 / 465)(overlap = 7.00 / 8.00)	testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#keepSameInstances(ITestNGMethod, Set) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#createClassBasedParallelWorkers(List) testng/cd80791/build/src/main/java/org/testng/TestNG.java#checkTestNames(List) testng/cd80791/build/src/main/java/org/testng/internal/DynamicGraph.java#getUnfinishedNodes(List) testng/cd80791/build/src/main/java/org/testng/reporters/FailedReporter.java#generateXmlTest(ISuite, XmlTest, ITestContext, Collection, Collection)	10
?	2393	0.0002794232703699564	(pattern support = 10 / 23)(pattern violations = 1 / 389)(overlap = 3.00 / 12.00)	testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#primitiveArrayToString(Object) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#getModules(Guice, Injector, Class) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParams(String[]) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParamTypes(String[]) testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#injectParameters(Object[], Method, ITestContext, ITestResult)	10
?	2394	0.0002794232703699564	(pattern support = 10 / 23)(pattern violations = 1 / 389)(overlap = 3.00 / 12.00)	testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#primitiveArrayToString(Object) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#getModules(Guice, Injector, Class) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParams(String[]) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParamTypes(String[]) testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#injectParameters(Object[], Method, ITestContext, ITestResult)	10
?	2395	0.0002794232703699564	(pattern support = 10 / 23)(pattern violations = 1 / 389)(overlap = 3.00 / 12.00)	testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#primitiveArrayToString(Object) testng/cd80791/build/src/main/java/org/testng/TestRunner.java#getModules(Guice, Injector, Class) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParams(String[]) testng/cd80791/build/src/main/java/org/testng/remote/strprotocol/TestResultMessage.java#extractParamTypes(String[]) testng/cd80791/build/src/main/java/org/testng/internal/Invoker.java#injectParameters(Object[], Method, ITestContext, ITestResult)	10