Review

Detector:	MuDetect_180215_ExcludeVeryPrevalentFixed
Target:	project ' argouml ' version 026
Misuse:	misuse ' tikanga11-3 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	If the zargo file to be loaded contains no `.argo` file, this method will throw an exception at line 218.
Fix Description:	Check that the iterator contains a file to fix this.
Violation Types:	missing/condition/value_or_state
In File:	org/argouml/persistence/ZargoFilePersister.java
In Method:	doLoad(File)
Code with Misuse:	class ZargoFilePersister { /* * @see org.argouml.persistence.ProjectFilePersister#doLoad(java.io.File) */ @Override public Project doLoad(File file) throws OpenException, InterruptedException { ProgressMgr progressMgr = new ProgressMgr(); progressMgr.setNumberOfPhases(3 + UML_PHASES_LOAD); ThreadUtils.checkIfInterrupted(); int fileVersion; String releaseVersion; try { String argoEntry = getEntryNames(file, ".argo").iterator().next(); URL argoUrl = makeZipEntryUrl(toURL(file), argoEntry); fileVersion = getPersistenceVersion(argoUrl.openStream()); releaseVersion = getReleaseVersion(argoUrl.openStream()); } catch (MalformedURLException e) { throw new OpenException(e); } catch (IOException e) { throw new OpenException(e); } // TODO: The commented code below was commented out by Bob Tarling // in order to resolve bugs 4845 and 4857. Hopefully we can // determine the cause and reintroduce. //boolean upgradeRequired = !checkVersion(fileVersion, releaseVersion) boolean upgradeRequired = true; LOG.info("Loading zargo file of version " + fileVersion); final Project p; if (upgradeRequired) { File combinedFile = zargoToUml(file, progressMgr); p = super.doLoad(file, combinedFile, progressMgr); } else { p = loadFromZargo(file, progressMgr); } progressMgr.nextPhase(); p.setURI(file.toURI()); return p; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	96	0.00326530612244898	(pattern support = 418 / 418)(pattern violations = 1 / 245)(overlap = 8.00 / 10.00)	argouml/026/build/src/argouml-app/src/org/argouml/uml/diagram/static_structure/ui/FigInterface.java#updateListeners(Object, Object) argouml/026/build/src/argouml-app/src/org/argouml/language/java/generator/AttributeCodePiece.java#AttributeCodePiece(CodePiece, CodePiece, List) argouml/026/build/src/argouml-app/src/org/argouml/application/Main.java#performCommandsInternal(List) argouml/026/build/src/argouml-app/src/org/argouml/cognitive/ui/ToDoByGoal.java#toDoItemsAdded(ToDoListEvent) argouml/026/build/src/argouml-app/src/org/argouml/ui/ProjectBrowser.java#getTabProps()	418
?	304	0.0014619883040935672	(pattern support = 11 / 418)(pattern violations = 1 / 9)(overlap = 3.00 / 6.00)	argouml/026/build/src/argouml-app/src/org/argouml/profile/init/ProfileLoader.java#huntForProfilesInDir(String) argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/ImportClassLoader.java#removeFile(File) argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/ImportClassLoader.java#getURLs(String) argouml/026/build/src/argouml-app/src/org/argouml/persistence/XmiFilePersister.java#doLoad(File) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ZipFilePersister.java#doLoad(File)	11
?	467	0.00044856459330143536	(pattern support = 10 / 418)(pattern violations = 1 / 32)(overlap = 3.00 / 5.00)	argouml/026/build/src/argouml-app/src/org/argouml/persistence/DiagramMemberFilePersister.java#load(Project, URL) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ProfileConfigurationFilePersister.java#load(Project, URL) argouml/026/build/src/argouml-app/src/org/argouml/persistence/XmiFilePersister.java#doLoad(File) argouml/026/build/src/argouml-app/src/org/argouml/persistence/UmlFilePersister.java#getReleaseVersionFromFile(File) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ZargoFilePersister.java#doLoad(File)	10
?	658	0.0003383113430960321	(pattern support = 16 / 418)(pattern violations = 1 / 99)(overlap = 7.00 / 8.00)	argouml/026/build/src/argouml-app/src/org/argouml/persistence/ZargoFilePersister.java#readerToWriter(Reader, Writer) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ZargoFilePersister.java#doSave(Project, File) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ModelMemberFilePersister.java#registerDiagramsInternal(Project, Collection, boolean) argouml/026/build/src/argouml-app/src/org/argouml/persistence/ModelMemberFilePersister.java#readModels(InputSource) argouml/026/build/src/argouml-app/src/org/argouml/uml/reveng/java/Modeller.java#addClassifier(Object, String, short, String, List)	16