Review

Detector:

Tikanga

Target:

project '

closure

' version

319

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-9
In File:	com/google/javascript/jscomp/ClosureCodingConvention.java
In Method:	identifyTypeDefAssign(Node)
Code with Finding:	`class ClosureCodingConvention { @Override public String identifyTypeDefAssign(Node n) { Node firstChild = n.getFirstChild(); int type = n.getType(); if (type == Token.ASSIGN) { if (TYPEDEF_NAME.equals(n.getLastChild().getQualifiedName())) { return firstChild.getQualifiedName(); } } else if (type == Token.VAR && firstChild.hasChildren()) { if (TYPEDEF_NAME.equals( firstChild.getFirstChild().getQualifiedName())) { return firstChild.getString(); } } return null; } }`

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
?	9	0.97	27.87	AG (Node.getType () : int @ (0) => AX AF Node.getFirstChild () : Node @ (0)) AG (Node.getType () : int @ (0) => EX EF Node.getFirstChild () : Node @ (0))	EF Node.getType () : int @ (0) AG (Node.getFirstChild () : Node @ (0) => AX AF Node.getLastChild () : Node @ (0)) EF Node.getLastChild () : Node @ (0) AF Node.getType () : int @ (0) AG (Node.getType () : int @ (0) => EX EF Node.getLastChild () : Node @ (0)) EF Node.getFirstChild () : Node @ (0) AG (Node.getFirstChild () : Node @ (0) => EX EF Node.getLastChild () : Node @ (0)) AG (Node.getType () : int @ (0) => AX AF Node.getLastChild () : Node @ (0)) AF Node.getFirstChild () : Node @ (0) AF Node.getLastChild () : Node @ (0)	ClosureReverseAbstractInterpreter.getPreciserScopeKnowingConditionOutcome (Node, FlowScope, boolean) : FlowScope : param #1@Node (line 202) ClosureReverseAbstractInterpreter.getPreciserScopeKnowingConditionOutcome (Node, FlowScope, boolean) : FlowScope : var #2@Node (line 203) ClosureCodeRemoval$FindAbstractMethods.visit (NodeTraversal, Node, Node) : void : param #2@Node (line 143)