Review

Detector:

Tikanga

Target:

project '

itext

' version

5091

Tags:

Potential Misuse

Anomaly identified by the detector. Please review whether this anomaly corresponds to a misuse.

Finding:	finding-17
In File:	com/itextpdf/text/pdf/PdfReader.java
In Method:	eliminateSharedStreams()
Code with Finding:	class PdfReader { /** Eliminates shared streams if they exist. */ public void eliminateSharedStreams() { if (!sharedStreams) return; sharedStreams = false; if (pageRefs.size() == 1) return; ArrayList<PRIndirectReference> newRefs = new ArrayList<PRIndirectReference>(); ArrayList<PRStream> newStreams = new ArrayList<PRStream>(); IntHashtable visited = new IntHashtable(); for (int k = 1; k <= pageRefs.size(); ++k) { PdfDictionary page = pageRefs.getPageN(k); if (page == null) continue; PdfObject contents = getPdfObject(page.get(PdfName.CONTENTS)); if (contents == null) continue; if (contents.isStream()) { PRIndirectReference ref = (PRIndirectReference)page.get(PdfName.CONTENTS); if (visited.containsKey(ref.getNumber())) { // need to duplicate newRefs.add(ref); newStreams.add(new PRStream((PRStream)contents, null)); } else visited.put(ref.getNumber(), 1); } else if (contents.isArray()) { PdfArray array = (PdfArray)contents; for (int j = 0; j < array.size(); ++j) { PRIndirectReference ref = (PRIndirectReference)array.getPdfObject(j); if (visited.containsKey(ref.getNumber())) { // need to duplicate newRefs.add(ref); newStreams.add(new PRStream((PRStream)getPdfObject(ref), null)); } else visited.put(ref.getNumber(), 1); } } } if (newStreams.isEmpty()) return; for (int k = 0; k < newStreams.size(); ++k) { xrefObj.add(newStreams.get(k)); PRIndirectReference ref = newRefs.get(k); ref.setNumber(xrefObj.size() - 1, 0); } } }

Metadata

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects	Violation Types
?	17	0.95	18.65	AG (ArrayList.size () : int @ (0) => AX AF ArrayList.get (int) : Object @ (0)) EF ArrayList.size () : int @ (0) AG (ArrayList.add (Object) : boolean @ (0) => EX EF ArrayList.size () : int @ (0)) AG (ArrayList.add (Object) : boolean @ (0) => AX AF ArrayList.size () : int @ (0)) AF ArrayList.size () : int @ (0) AG (ArrayList.size () : int @ (0) => EX EF ArrayList.get (int) : Object @ (0))	AF ArrayList.get (int) : Object @ (0) EF ArrayList.get (int) : Object @ (0) AG (ArrayList.get (int) : Object @ (0) => EX EF ArrayList.get (int) : Object @ (0)) EF ArrayList.add (Object) : boolean @ (0) AG (ArrayList.add (Object) : boolean @ (0) => AX AF ArrayList.get (int) : Object @ (0)) AG (ArrayList.add (Object) : boolean @ (0) => EX EF ArrayList.get (int) : Object @ (0))	AcroFields.getSignatureNames () : ArrayList : var #6@ArrayList (line 2138) AcroFields.splitDAelements (String) : Object[] : var #2@ArrayList (line 510) HTMLWorker.processRow () : void : var #2@ArrayList (line 601)