Review

Detector:	Tikanga
Target:	project ' itext ' version 5091
Misuse:	misuse ' jadet-9 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	PdfArray.getPdfObject() is invoked without checking that the array contains sufficiently many objects. Is also jadet-10.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/fonts/cmaps/AbstractCMap.java
In Method:	addRange(PdfString, PdfString, PdfObject)
Code with Misuse:	class AbstractCMap { void addRange(PdfString from, PdfString to, PdfObject code) { byte[] a1 = decodeStringToByte(from); byte[] a2 = decodeStringToByte(to); if (a1.length != a2.length \|\| a1.length == 0) throw new IllegalArgumentException("Invalid map."); byte[] sout = null; if (code instanceof PdfString) sout = decodeStringToByte((PdfString)code); int start = a1[a1.length - 1] & 0xff; int end = a2[a2.length - 1] & 0xff; for (int k = start; k <= end; ++k) { a1[a1.length - 1] = (byte)k; PdfString s = new PdfString(a1); s.setHexWriting(true); if (code instanceof PdfArray) { addChar(s, ((PdfArray)code).getPdfObject(k - start)); } else if (code instanceof PdfNumber) { int nn = ((PdfNumber)code).intValue() + k - start; addChar(s, new PdfNumber(nn)); } else if (code instanceof PdfString) { PdfString s1 = new PdfString(sout); s1.setHexWriting(true); ++sout[sout.length - 1]; addChar(s, s1); } } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects
Yes	25	0.96	13.02	EF PdfArray.size () : int @ (0) AG (PdfArray.size () : int @ (0) => AX AF PdfArray.getPdfObject (int) : PdfObject @ (0)) AG (CAST: PdfArray => EX EF PdfArray.size () : int @ (0)) AG (PdfArray.size () : int @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0))	AF CAST: PdfArray AF PdfArray.getPdfObject (int) : PdfObject @ (0) AG (CAST: PdfArray => AX AF PdfArray.getPdfObject (int) : PdfObject @ (0)) AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0)) EF CAST: PdfArray EF PdfArray.getPdfObject (int) : PdfObject @ (0) AG (CAST: PdfArray => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0))	DocumentFont.readWidths (PdfArray) : IntHashtable : var #5@PdfObject (line 174) PdfNameTree.iterateItems (PdfDictionary, HashMap) : void : var #6@PdfObject (line 143) PdfNameTree.iterateItems (PdfDictionary, HashMap) : void : var #3@PdfObject (line 136)
No	38	0.97	9.32	EF PdfArray.size () : int @ (0) AG (PdfArray.size () : int @ (0) => AX AF PdfArray.getPdfObject (int) : PdfObject @ (0)) AG (PdfArray.size () : int @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0))	AF PdfArray.getPdfObject (int) : PdfObject @ (0) AG (PdfArray.getPdfObject (int) : PdfObject @ (0) => EX EF PdfArray.getPdfObject (int) : PdfObject @ (0)) EF PdfArray.getPdfObject (int) : PdfObject @ (0)	AcroFields.removeRefFromArray (PdfArray, PdfObject) : int : param #1@PdfArray (line 1665) DocumentFont.doType1TT () : void : var #26@PdfArray (line 315) AcroFields.getAppearance (PdfDictionary, String[], String) : PdfAppearance : var #18@PdfArray (line 738)

Reviewer Name:	sven
Comment: