Review

Detector:	Tikanga
Target:	project ' httpclient ' version 452
Misuse:	misuse ' 4 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Misses to pass Locale to constructor of SimpleDateFormat.
Fix Description:	(see diff)
Violation Types:	missing/call superfluous/call
In File:	org/apache/commons/httpclient/util/DateUtil.java
In Method:	formatDate(Date, String)
Code with Misuse:	class DateUtil { /** * Formats the given date according to the specified pattern. The pattern * must conform to that used by the {@link SimpleDateFormat simple date * format} class. * * @param date The date to format. * @param pattern The pattern to use for formatting the date. * @return A formatted date string. * * @throws IllegalArgumentException If the given date pattern is invalid. * * @see SimpleDateFormat */ public static String formatDate(Date date, String pattern) { if (date == null) throw new IllegalArgumentException("date is null"); if (pattern == null) throw new IllegalArgumentException("pattern is null"); SimpleDateFormat formatter = new SimpleDateFormat(pattern); formatter.setTimeZone(GMT); return formatter.format(date); } }
Code with Pattern(s):	`class SetLocale { void pattern(String pattern, Date date, TimeZone GMT) { SimpleDateFormat formatter = new SimpleDateFormat(pattern, Locale.US); formatter.setTimeZone(GMT); formatter.format(date); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Defect Indicator	Missing Properties	Present Properties	Supporting Objects
Yes	0	0.98	1.0	EF SimpleDateFormat. (String, Locale) : void @ (0);AF SimpleDateFormat. (String, Locale) : void @ (0);AG (SimpleDateFormat. (String, Locale) : void @ (0) => AX AF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0));AG (SimpleDateFormat. (String, Locale) : void @ (0) => EX EF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0))	EF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0);AF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0)	SetLocale0.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0);SetLocale1.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0);SetLocale10.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0)
Yes	1	0.98	1.0	EF SimpleDateFormat. (String, Locale) : void @ (0);AG (SimpleDateFormat. (String, Locale) : void @ (0) => EX EF SimpleDateFormat.format (Date) : String @ (0));AF SimpleDateFormat. (String, Locale) : void @ (0);AG (SimpleDateFormat. (String, Locale) : void @ (0) => AX AF SimpleDateFormat.format (Date) : String @ (0));AG (SimpleDateFormat. (String, Locale) : void @ (0) => AX AF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0));AG (SimpleDateFormat. (String, Locale) : void @ (0) => EX EF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0))	AG (SimpleDateFormat.setTimeZone (TimeZone) : void @ (0) => AX AF SimpleDateFormat.format (Date) : String @ (0));AF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0);EF SimpleDateFormat.setTimeZone (TimeZone) : void @ (0);EF SimpleDateFormat.format (Date) : String @ (0);AF SimpleDateFormat.format (Date) : String @ (0);AG (SimpleDateFormat.setTimeZone (TimeZone) : void @ (0) => EX EF SimpleDateFormat.format (Date) : String @ (0))	SetLocale0.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0);SetLocale1.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0);SetLocale10.pattern (String, Date, TimeZone) : void : var #1@SimpleDateFormat (line 0)

Reviewer Name:	sven
Comment:	It says that the constructor with the Locale is missing.