Review

Map.get() may return null.

• missing/condition/null_check

org/apache/jackrabbit/webdav/jcr/JcrDavException.java

JcrDavException(RepositoryException)

class JcrDavException {
    /**
     * Create a new <code>JcrDavException</code>.
     *
     * @param cause The original cause of this <code>DavException</code>. Note, that
     * in contrast to {@link Throwable#Throwable(Throwable)}, {@link Throwable#Throwable(String, Throwable)} and
     * {@link Throwable#initCause(Throwable)} the cause must not be <code>null</code>.
     * @param errorCode Status code for the response.
     * @throws NullPointerException if the given exception is <code>null</code>.
     * @see DavException#DavException(int, String)
     * @see DavException#DavException(int)
     */
    public JcrDavException(Throwable cause, int errorCode) {
        super(errorCode, cause.getMessage(), cause, null);
        exceptionClass = cause.getClass();
        if (log.isDebugEnabled()) {
            log.debug("Handling exception with error code " + errorCode, cause);
        }
    }

}

class JcrDavException {
    /**
     * Same as {@link JcrDavException#JcrDavException(Throwable, int)} where the
     * error code is retrieved from an internal mapping.
     *
     * @param cause Cause of this DavException
     * @throws NullPointerException if the given exception is <code>null</code>.
     * @see JcrDavException#JcrDavException(Throwable, int)
     */
    public JcrDavException(RepositoryException cause) {
        this(cause, ((Integer)codeMap.get(cause.getClass())).intValue());
    }

}

class CheckMapGetNotNull {
  void pattern(HashMap codeMap, Class exceptionClass) {
    Integer code = (Integer) codeMap.get(exceptionClass);
    if (code != null) {
      code.intValue();
    }
  }
}