Review

Detector:	MuDetect
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-357 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfWriter.java
In Method:	writeCrossReferenceTable(OutputStream, PdfIndirectReference, PdfIndirectReference, PdfIndirectReference, PdfObject, long)
Code with Misuse:	class PdfWriter.PdfBody { void writeCrossReferenceTable(final OutputStream os, final PdfIndirectReference root, final PdfIndirectReference info, final PdfIndirectReference encryption, final PdfObject fileID, final long prevxref) throws IOException { int refNumber = 0; if (writer.isFullCompression()) { flushObjStm(); refNumber = getIndirectReferenceNumber(); xrefs.add(new PdfCrossReference(refNumber, position)); } PdfCrossReference entry = xrefs.first(); int first = entry.getRefnum(); int len = 0; ArrayList<Integer> sections = new ArrayList<Integer>(); for (PdfCrossReference pdfCrossReference : xrefs) { entry = pdfCrossReference; if (first + len == entry.getRefnum()) ++len; else { sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); first = entry.getRefnum(); len = 1; } } sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); if (writer.isFullCompression()) { int mid = 5; long mask = 0xff00000000L; for (; mid > 1; --mid) { if ((mask & position) != 0) break; mask >>>= 8; } ByteBuffer buf = new ByteBuffer(); for (Object element : xrefs) { entry = (PdfCrossReference) element; entry.toPdf(mid, buf); } PdfStream xr = new PdfStream(buf.toByteArray()); buf = null; xr.flateCompress(writer.getCompressionLevel()); xr.put(PdfName.SIZE, new PdfNumber(size())); xr.put(PdfName.ROOT, root); if (info != null) { xr.put(PdfName.INFO, info); } if (encryption != null) xr.put(PdfName.ENCRYPT, encryption); if (fileID != null) xr.put(PdfName.ID, fileID); xr.put(PdfName.W, new PdfArray(new int[]{1, mid, 2})); xr.put(PdfName.TYPE, PdfName.XREF); PdfArray idx = new PdfArray(); for (int k = 0; k < sections.size(); ++k) idx.add(new PdfNumber(sections.get(k).intValue())); xr.put(PdfName.INDEX, idx); if (prevxref > 0) xr.put(PdfName.PREV, new PdfNumber(prevxref)); PdfEncryption enc = writer.crypto; writer.crypto = null; PdfIndirectObject indirect = new PdfIndirectObject(refNumber, xr, writer); indirect.writeTo(writer.getOs()); writer.crypto = enc; } else { os.write(getISOBytes("xref\n")); Iterator<PdfCrossReference> i = xrefs.iterator(); for (int k = 0; k < sections.size(); k += 2) { first = sections.get(k).intValue(); len = sections.get(k + 1).intValue(); os.write(getISOBytes(String.valueOf(first))); os.write(getISOBytes(" ")); os.write(getISOBytes(String.valueOf(len))); os.write('\n'); while (len-- > 0) { entry = i.next(); entry.toPdf(os); } } } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
No	1309	4.0994359176177E-5	(pattern violations = 1 / 121)(violation support = 1 / 84)(pattern support = 15 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/TSAClientBouncyCastle.java#getTSAResponse(byte[]) itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary) itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decode(String, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getPageContent(int, RandomAccessFileOrArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	15
No	1310	4.0994359176177E-5	(pattern violations = 1 / 121)(violation support = 1 / 84)(pattern support = 15 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/TSAClientBouncyCastle.java#getTSAResponse(byte[]) itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary) itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decode(String, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getPageContent(int, RandomAccessFileOrArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	15
No	1311	4.0994359176177E-5	(pattern violations = 1 / 121)(violation support = 1 / 84)(pattern support = 15 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/TSAClientBouncyCastle.java#getTSAResponse(byte[]) itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary) itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decode(String, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getPageContent(int, RandomAccessFileOrArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	15
No	1312	4.0994359176177E-5	(pattern violations = 1 / 121)(violation support = 1 / 84)(pattern support = 15 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/TSAClientBouncyCastle.java#getTSAResponse(byte[]) itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary) itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decode(String, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getPageContent(int, RandomAccessFileOrArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	15
No	1313	4.0994359176177E-5	(pattern violations = 1 / 121)(violation support = 1 / 84)(pattern support = 15 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/TSAClientBouncyCastle.java#getTSAResponse(byte[]) itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary) itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decode(String, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getPageContent(int, RandomAccessFileOrArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	15
No	1362	3.6479121067765E-5	(pattern violations = 1 / 863)(violation support = 1 / 15)(pattern support = 17 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/codec/BmpImage.java#indexedModel(byte, int, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle) itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
No	1799	5.6218939036183E-6	(pattern violations = 1 / 270)(violation support = 1 / 183)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/LtvVerification.java#outputDss(PdfDictionary, PdfDictionary, PdfArray, PdfArray, PdfArray) itext/5091/original-src/com/itextpdf/text/pdf/PdfDocument.java#addNames(TreeMap, HashMap, HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#createAcroForms() itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#getOCGOrder(PdfArray, PdfLayer) itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#fillOCProperties(boolean)	10
No	2012	3.0058626344823E-6	(pattern violations = 1 / 604)(violation support = 1 / 153)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int) itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
No	2073	2.2004640338555E-6	(pattern violations = 1 / 604)(violation support = 1 / 209)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int) itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
No	2074	2.2004640338555E-6	(pattern violations = 1 / 604)(violation support = 1 / 209)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int) itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
No	2216	1.7482006901485E-6	(pattern violations = 1 / 863)(violation support = 1 / 313)(pattern support = 17 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/codec/BmpImage.java#indexedModel(byte, int, int) itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle) itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
Yes	4	0.050925925925926	(pattern violations = 1 / 4)(violation support = 1 / 3)(pattern support = 22 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addNamedDestinations(Map, int) itext/5091/original-src/com/itextpdf/text/pdf/SimpleNamedDestination.java#getNamedDestination(PdfReader, boolean) itext/5091/original-src/com/itextpdf/text/pdf/FdfWriter.java#setFields(FdfReader) itext/5091/original-src/com/itextpdf/text/pdf/PdfDocument.java#addNames(TreeMap, HashMap, HashMap, PdfWriter) itext/5091/original-src/com/itextpdf/text/pdf/DocumentFont.java#doType1TT()	22

Reviewer Name:	sven
Comment: