Review

Detector:	MuDetect
Target:	project ' itext ' version 5091
Misuse:	misuse ' jadet-5 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	PdfArray.getPdfObject() is invoked without checking that the array contains sufficiently many objects.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfStructureTreeRoot.java
In Method:	nodeProcess(PdfDictionary, PdfIndirectReference)
Code with Misuse:	class PdfStructureTreeRoot { private void nodeProcess(PdfDictionary struc, PdfIndirectReference reference) throws IOException { PdfObject obj = struc.get(PdfName.K); if (obj != null && obj.isArray() && !(((PdfArray)obj).getPdfObject(0)).isNumber()) { PdfArray ar = (PdfArray)obj; for (int k = 0; k < ar.size(); ++k) { PdfStructureElement e = (PdfStructureElement)ar.getAsDict(k); ar.set(k, e.getReference()); nodeProcess(e, e.getReference()); } } if (reference != null) writer.addToBody(struc, reference); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
No	157	0.00098502758077226	(pattern violations = 1 / 94)(violation support = 1 / 3)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#mergeField(String, Item) itext/5091/original-src/com/itextpdf/text/pdf/PdfStream.java#toPdf(PdfWriter, OutputStream) itext/5091/original-src/com/itextpdf/text/pdf/PdfEFStream.java#toPdf(PdfWriter, OutputStream) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#readXrefSection() itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#decodePredictor(byte, PdfObject)	10
Yes	524	0.00016896458502298	(pattern violations = 1 / 137)(violation support = 1 / 12)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#makeRemoteNamedDestinationsLocal() itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#flatFields() itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#addOrder(PdfLayer, PdfArray, Map) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#consolidateNamedDestinations() itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#iteratePages(PRIndirectReference)	10
No	549	0.00013517166801838	(pattern violations = 1 / 137)(violation support = 1 / 15)(pattern support = 10 / 36)	itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#makeRemoteNamedDestinationsLocal() itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#flatFields() itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#addOrder(PdfLayer, PdfArray, Map) itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#consolidateNamedDestinations() itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#iteratePages(PRIndirectReference)	10

Reviewer Name:	hoan
Comment: