Review

Detector:	MuDetect
Target:	project ' jfreechart ' version 164
Misuse:	misuse ' 4a '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	StatisticalCategoryDataset.getStDevValue() may return null.
Fix Description:	Check for null. (see diff)
Violation Types:	missing/condition/null_check
In File:	org/jfree/chart/renderer/category/StatisticalBarRenderer.java
In Method:	drawHorizontalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, StatisticalCategoryDataset, int, int)
Code with Misuse:	class StatisticalBarRenderer { /** * Draws an item for a plot with a horizontal orientation. * * @param g2 the graphics device. * @param state the renderer state. * @param dataArea the data area. * @param plot the plot. * @param domainAxis the domain axis. * @param rangeAxis the range axis. * @param dataset the data. * @param row the row index (zero-based). * @param column the column index (zero-based). / protected void drawHorizontalItem(Graphics2D g2, CategoryItemRendererState state, Rectangle2D dataArea, CategoryPlot plot, CategoryAxis domainAxis, ValueAxis rangeAxis, StatisticalCategoryDataset dataset, int row, int column) { RectangleEdge xAxisLocation = plot.getDomainAxisEdge(); // BAR Y double rectY = domainAxis.getCategoryStart(column, getColumnCount(), dataArea, xAxisLocation); int seriesCount = getRowCount(); int categoryCount = getColumnCount(); if (seriesCount > 1) { double seriesGap = dataArea.getHeight() getItemMargin() / (categoryCount * (seriesCount - 1)); rectY = rectY + row * (state.getBarWidth() + seriesGap); } else { rectY = rectY + row * state.getBarWidth(); } // BAR X Number meanValue = dataset.getMeanValue(row, column); double value = meanValue.doubleValue(); double base = 0.0; double lclip = getLowerClip(); double uclip = getUpperClip(); if (uclip <= 0.0) { // cases 1, 2, 3 and 4 if (value >= uclip) { return; // bar is not visible } base = uclip; if (value <= lclip) { value = lclip; } } else if (lclip <= 0.0) { // cases 5, 6, 7 and 8 if (value >= uclip) { value = uclip; } else { if (value <= lclip) { value = lclip; } } } else { // cases 9, 10, 11 and 12 if (value <= lclip) { return; // bar is not visible } base = getLowerClip(); if (value >= uclip) { value = uclip; } } RectangleEdge yAxisLocation = plot.getRangeAxisEdge(); double transY1 = rangeAxis.valueToJava2D(base, dataArea, yAxisLocation); double transY2 = rangeAxis.valueToJava2D(value, dataArea, yAxisLocation); double rectX = Math.min(transY2, transY1); double rectHeight = state.getBarWidth(); double rectWidth = Math.abs(transY2 - transY1); Rectangle2D bar = new Rectangle2D.Double(rectX, rectY, rectWidth, rectHeight); Paint seriesPaint = getItemPaint(row, column); g2.setPaint(seriesPaint); g2.fill(bar); if (isDrawBarOutline() && state.getBarWidth() > 3) { g2.setStroke(getItemStroke(row, column)); g2.setPaint(getItemOutlinePaint(row, column)); g2.draw(bar); } // standard deviation lines double valueDelta = dataset.getStdDevValue(row, column).doubleValue(); double highVal = rangeAxis.valueToJava2D(meanValue.doubleValue() + valueDelta, dataArea, yAxisLocation); double lowVal = rangeAxis.valueToJava2D(meanValue.doubleValue() - valueDelta, dataArea, yAxisLocation); if (this.errorIndicatorStroke != null) { g2.setStroke(this.errorIndicatorStroke); } else { g2.setStroke(getItemOutlineStroke(row, column)); } if (this.errorIndicatorPaint != null) { g2.setPaint(this.errorIndicatorPaint); } else { g2.setPaint(getItemOutlinePaint(row, column)); } Line2D line = null; line = new Line2D.Double(lowVal, rectY + rectHeight / 2.0d, highVal, rectY + rectHeight / 2.0d); g2.draw(line); line = new Line2D.Double(highVal, rectY + rectHeight * 0.25, highVal, rectY + rectHeight * 0.75); g2.draw(line); line = new Line2D.Double(lowVal, rectY + rectHeight * 0.25, lowVal, rectY + rectHeight * 0.75); g2.draw(line); CategoryItemLabelGenerator generator = getItemLabelGenerator(row, column); if (generator != null && isItemLabelVisible(row, column)) { drawItemLabel(g2, dataset, row, column, plot, generator, bar, (value < 0.0)); } // add an item entity, if this information is being collected EntityCollection entities = state.getEntityCollection(); if (entities != null) { addItemEntity(entities, dataset, row, column, bar); } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
No	1194	1.6380821334382E-6	(pattern violations = 1 / 570)(violation support = 1 / 170)(pattern support = 10 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/xy/AbstractXYItemRenderer.java#drawDomainMarker(Graphics2D, XYPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/xy/AbstractXYItemRenderer.java#drawRangeMarker(Graphics2D, XYPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/category/AbstractCategoryItemRenderer.java#drawRangeMarker(Graphics2D, CategoryPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/category/AbstractCategoryItemRenderer.java#drawDomainMarker(Graphics2D, CategoryPlot, CategoryAxis, CategoryMarker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/annotations/CategoryPointerAnnotation.java#draw(Graphics2D, CategoryPlot, Rectangle2D, CategoryAxis, ValueAxis)	10
No	1230	1.3074864188117E-6	(pattern violations = 1 / 369)(violation support = 1 / 329)(pattern support = 10 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/xy/AbstractXYItemRenderer.java#drawDomainMarker(Graphics2D, XYPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/xy/AbstractXYItemRenderer.java#drawRangeMarker(Graphics2D, XYPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/category/AbstractCategoryItemRenderer.java#drawRangeMarker(Graphics2D, CategoryPlot, ValueAxis, Marker, Rectangle2D);jfreechart/164/original-src/org/jfree/chart/renderer/category/StatisticalLineAndShapeRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/xy/XYStepRenderer.java#drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int)	10
No	230	0.0001793561115595	(pattern violations = 1 / 885)(violation support = 1 / 1)(pattern support = 10 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/category/StatisticalBarRenderer.java#drawVerticalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, StatisticalCategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/IntervalBarRenderer.java#drawInterval(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, IntervalCategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/StatisticalBarRenderer.java#drawHorizontalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, StatisticalCategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/WaterfallBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/GanttRenderer.java#drawTask(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, GanttCategoryDataset, int, int)	10
No	510	3.1307723615416E-5	(pattern violations = 1 / 507)(violation support = 1 / 12)(pattern support = 12 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/xy/StackedXYBarRenderer.java#drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int);jfreechart/164/original-src/org/jfree/chart/renderer/xy/XYBarRenderer.java#drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/StackedBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/WaterfallBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/LayeredBarRenderer.java#drawHorizontalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int)	12
No	587	2.6835191670357E-5	(pattern violations = 1 / 507)(violation support = 1 / 14)(pattern support = 12 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/xy/StackedXYBarRenderer.java#drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int);jfreechart/164/original-src/org/jfree/chart/renderer/xy/XYBarRenderer.java#drawItem(Graphics2D, XYItemRendererState, Rectangle2D, PlotRenderingInfo, XYPlot, ValueAxis, ValueAxis, XYDataset, int, int, CrosshairState, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/StackedBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/WaterfallBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/LayeredBarRenderer.java#drawHorizontalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int)	12
No	886	4.8680277672304E-6	(pattern violations = 1 / 536)(violation support = 1 / 73)(pattern support = 12 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/category/StackedBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/GanttRenderer.java#drawTasks(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, GanttCategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/BarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/LayeredBarRenderer.java#drawVerticalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/GanttRenderer.java#drawTask(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, GanttCategoryDataset, int, int)	12
No	887	4.8680277672304E-6	(pattern violations = 1 / 536)(violation support = 1 / 73)(pattern support = 12 / 63)	jfreechart/164/original-src/org/jfree/chart/renderer/category/StackedBarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/GanttRenderer.java#drawTasks(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, GanttCategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/BarRenderer.java#drawItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/LayeredBarRenderer.java#drawVerticalItem(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, CategoryDataset, int, int);jfreechart/164/original-src/org/jfree/chart/renderer/category/GanttRenderer.java#drawTask(Graphics2D, CategoryItemRendererState, Rectangle2D, CategoryPlot, CategoryAxis, ValueAxis, GanttCategoryDataset, int, int)	12

Reviewer Name:	sven
Comment:	No pattern contas getStdDevValue().