Review

Detector:	MuDetect_RankByDistance
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-15 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	StringTokenizer.nextToken() is invoked without prior check of hasMoreTokens(). This usage may be safe from context, since the tokenized value is an RBG color value which has a known number of tokens. However, the usage is unsafe against invalid values and we, therefore, consider it a misuse.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/SimpleBookmark.java
In Method:	iterateOutlines(PdfWriter, PdfIndirectReference, List, boolean)
Code with Misuse:	class SimpleBookmark { @SuppressWarnings("unchecked") public static Object[] iterateOutlines(PdfWriter writer, PdfIndirectReference parent, List<HashMap<String, Object>> kids, boolean namedAsNames) throws IOException { PdfIndirectReference refs[] = new PdfIndirectReference[kids.size()]; for (int k = 0; k < refs.length; ++k) refs[k] = writer.getPdfIndirectReference(); int ptr = 0; int count = 0; for (Iterator<HashMap<String, Object>> it = kids.listIterator(); it.hasNext(); ++ptr) { HashMap<String, Object> map = it.next(); Object lower[] = null; List<HashMap<String, Object>> subKid = (List<HashMap<String, Object>>)map.get("Kids"); if (subKid != null && !subKid.isEmpty()) lower = iterateOutlines(writer, refs[ptr], subKid, namedAsNames); PdfDictionary outline = new PdfDictionary(); ++count; if (lower != null) { outline.put(PdfName.FIRST, (PdfIndirectReference)lower[0]); outline.put(PdfName.LAST, (PdfIndirectReference)lower[1]); int n = ((Integer)lower[2]).intValue(); if ("false".equals(map.get("Open"))) { outline.put(PdfName.COUNT, new PdfNumber(-n)); } else { outline.put(PdfName.COUNT, new PdfNumber(n)); count += n; } } outline.put(PdfName.PARENT, parent); if (ptr > 0) outline.put(PdfName.PREV, refs[ptr - 1]); if (ptr < refs.length - 1) outline.put(PdfName.NEXT, refs[ptr + 1]); outline.put(PdfName.TITLE, new PdfString((String)map.get("Title"), PdfObject.TEXT_UNICODE)); String color = (String)map.get("Color"); if (color != null) { try { PdfArray arr = new PdfArray(); StringTokenizer tk = new StringTokenizer(color); for (int k = 0; k < 3; ++k) { float f = Float.parseFloat(tk.nextToken()); if (f < 0) f = 0; if (f > 1) f = 1; arr.add(new PdfNumber(f)); } outline.put(PdfName.C, arr); } catch(Exception e){} //in case it's malformed } String style = (String)map.get("Style"); if (style != null) { style = style.toLowerCase(); int bits = 0; if (style.indexOf("italic") >= 0) bits \|= 1; if (style.indexOf("bold") >= 0) bits \|= 2; if (bits != 0) outline.put(PdfName.F, new PdfNumber(bits)); } createOutlineAction(outline, map, writer, namedAsNames); writer.addToBody(outline, refs[ptr]); } return new Object[]{refs[0], refs[refs.length - 1], Integer.valueOf(count)}; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	1028	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1029	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1030	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1031	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1032	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1033	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1034	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1035	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1036	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1037	0.83333333333333	overlap = 5.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setField(String, String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#setMKBackgroundColor(BaseColor);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#close(Map);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#moveRectangle(PdfDictionary, PdfReader, int, PdfName, String)	10
?	1998	0.6	overlap = 3.00 / 5.00	itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#getFullFontName(String, String, byte);itext/5091/original-src/com/itextpdf/text/FontFactoryImp.java#register(String, String);itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#createFont(String, String, boolean, boolean, byte, byte, boolean, boolean);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#Type1Font(String, String, boolean, byte, byte, boolean);itext/5091/original-src/com/itextpdf/awt/DefaultFontMapper.java#insertFile(File)	18
?	2304	0.5	overlap = 1.00 / 2.00	itext/5091/original-src/com/itextpdf/text/pdf/PdfDestination.java#PdfDestination(String);itext/5091/original-src/com/itextpdf/text/pdf/FdfWriter.java#removeField(String);itext/5091/original-src/com/itextpdf/text/html/HtmlUtilities.java#parseAttributes(String);itext/5091/original-src/com/itextpdf/text/html/simpleparser/ElementFactory.java#setParagraphLeading(Paragraph, String);itext/5091/original-src/com/itextpdf/text/pdf/FdfWriter.java#getField(String)	10
?	2305	0.5	overlap = 3.00 / 6.00	itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getStreamBytesRaw(PRStream, RandomAccessFileOrArray);itext/5091/original-src/com/itextpdf/text/pdf/qrcode/Encoder.java#interleaveWithECBytes(BitVector, int, int, int, BitVector);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#decodeBytes(byte[], PdfDictionary, Map);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#selectPages(List);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFont.java#getAllNames()	16
?	240	0.88888888888889	overlap = 8.00 / 9.00	itext/5091/original-src/com/itextpdf/text/pdf/LtvVerification.java#outputDss(PdfDictionary, PdfDictionary, PdfArray, PdfArray, PdfArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfDocument.java#addNames(TreeMap, HashMap, HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#createAcroForms();itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#readXRefStream(long);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#fillOCProperties(boolean)	10
?	363	0.85714285714286	overlap = 12.00 / 14.00	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeString(String);itext/5091/original-src/com/itextpdf/text/pdf/SimpleBookmark.java#eliminatePages(List, int);itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#getDeclaredEncoding(String);itext/5091/original-src/com/itextpdf/awt/geom/misc/Messages.java#format(String, Object[]);itext/5091/original-src/com/itextpdf/text/pdf/Barcode128.java#getHumanReadableUCCEAN(String)	15
?	364	0.85714285714286	overlap = 12.00 / 14.00	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeString(String);itext/5091/original-src/com/itextpdf/text/pdf/SimpleBookmark.java#eliminatePages(List, int);itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#getDeclaredEncoding(String);itext/5091/original-src/com/itextpdf/awt/geom/misc/Messages.java#format(String, Object[]);itext/5091/original-src/com/itextpdf/text/pdf/Barcode128.java#getHumanReadableUCCEAN(String)	15