Review

Detector:	MuDetect_RankByViolationSupport
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-15 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	StringTokenizer.nextToken() is invoked without prior check of hasMoreTokens(). This usage may be safe from context, since the tokenized value is an RBG color value which has a known number of tokens. However, the usage is unsafe against invalid values and we, therefore, consider it a misuse.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/SimpleBookmark.java
In Method:	iterateOutlines(PdfWriter, PdfIndirectReference, List, boolean)
Code with Misuse:	class SimpleBookmark { @SuppressWarnings("unchecked") public static Object[] iterateOutlines(PdfWriter writer, PdfIndirectReference parent, List<HashMap<String, Object>> kids, boolean namedAsNames) throws IOException { PdfIndirectReference refs[] = new PdfIndirectReference[kids.size()]; for (int k = 0; k < refs.length; ++k) refs[k] = writer.getPdfIndirectReference(); int ptr = 0; int count = 0; for (Iterator<HashMap<String, Object>> it = kids.listIterator(); it.hasNext(); ++ptr) { HashMap<String, Object> map = it.next(); Object lower[] = null; List<HashMap<String, Object>> subKid = (List<HashMap<String, Object>>)map.get("Kids"); if (subKid != null && !subKid.isEmpty()) lower = iterateOutlines(writer, refs[ptr], subKid, namedAsNames); PdfDictionary outline = new PdfDictionary(); ++count; if (lower != null) { outline.put(PdfName.FIRST, (PdfIndirectReference)lower[0]); outline.put(PdfName.LAST, (PdfIndirectReference)lower[1]); int n = ((Integer)lower[2]).intValue(); if ("false".equals(map.get("Open"))) { outline.put(PdfName.COUNT, new PdfNumber(-n)); } else { outline.put(PdfName.COUNT, new PdfNumber(n)); count += n; } } outline.put(PdfName.PARENT, parent); if (ptr > 0) outline.put(PdfName.PREV, refs[ptr - 1]); if (ptr < refs.length - 1) outline.put(PdfName.NEXT, refs[ptr + 1]); outline.put(PdfName.TITLE, new PdfString((String)map.get("Title"), PdfObject.TEXT_UNICODE)); String color = (String)map.get("Color"); if (color != null) { try { PdfArray arr = new PdfArray(); StringTokenizer tk = new StringTokenizer(color); for (int k = 0; k < 3; ++k) { float f = Float.parseFloat(tk.nextToken()); if (f < 0) f = 0; if (f > 1) f = 1; arr.add(new PdfNumber(f)); } outline.put(PdfName.C, arr); } catch(Exception e){} //in case it's malformed } String style = (String)map.get("Style"); if (style != null) { style = style.toLowerCase(); int bits = 0; if (style.indexOf("italic") >= 0) bits \|= 1; if (style.indexOf("bold") >= 0) bits \|= 2; if (bits != 0) outline.put(PdfName.F, new PdfNumber(bits)); } createOutlineAction(outline, map, writer, namedAsNames); writer.addToBody(outline, refs[ptr]); } return new Object[]{refs[0], refs[refs.length - 1], Integer.valueOf(count)}; } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	1009	0.027777777777778	violation support = 1 / 36	itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#getFullFontName(String, String, byte);itext/5091/original-src/com/itextpdf/text/FontFactoryImp.java#register(String, String);itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#getAllFontNames(String, String, byte);itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#createFont(String, String, boolean, boolean, byte, byte, boolean, boolean);itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#getAllNameEntries(String, String, byte)	18
?	1065	0.025641025641026	violation support = 1 / 39	itext/5091/original-src/com/itextpdf/text/pdf/FdfWriter.java#removeField(String);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getStreamBytesRaw(PRStream, RandomAccessFileOrArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#decodeBytes(byte[], PdfDictionary, Map);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFont.java#getNames(int);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFont.java#getAllNames()	16
?	1947	0.0065359477124183	violation support = 1 / 153	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
?	1988	0.0054644808743169	violation support = 1 / 183	itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addASEvent(PdfName, PdfName);itext/5091/original-src/com/itextpdf/text/pdf/LtvVerification.java#outputDss(PdfDictionary, PdfDictionary, PdfArray, PdfArray, PdfArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addOCGRadioGroup(ArrayList);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#getOCGOrder(PdfArray, PdfLayer);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#readXRefStream(long)	10
?	2064	0.0047846889952153	violation support = 1 / 209	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
?	2065	0.0047846889952153	violation support = 1 / 209	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
?	2260	0.0024213075060533	violation support = 1 / 413	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
?	2351	0.0013755158184319	violation support = 1 / 727	itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfSignatureAppearance.java#addDocMDP(PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#createLine(PdfWriter, Rectangle, String, float, float, float, float);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	13
?	2352	0.0013755158184319	violation support = 1 / 727	itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfSignatureAppearance.java#addDocMDP(PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#createLine(PdfWriter, Rectangle, String, float, float, float, float);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	13
?	2353	0.0013755158184319	violation support = 1 / 727	itext/5091/original-src/com/itextpdf/text/pdf/PdfAction.java#setOCGstate(ArrayList, boolean);itext/5091/original-src/com/itextpdf/text/pdf/PdfSignatureAppearance.java#addDocMDP(PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/TextField.java#writeMultipleValues(PdfFormField, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addDirectImageSimple(Image, PdfIndirectReference);itext/5091/original-src/com/itextpdf/text/pdf/PdfAnnotation.java#createInk(PdfWriter, Rectangle, String, float)	10
?	424	0.11111111111111	violation support = 1 / 9	itext/5091/original-src/com/itextpdf/text/pdf/PdfDestination.java#PdfDestination(String);itext/5091/original-src/com/itextpdf/text/pdf/BaseFont.java#createEncoding();itext/5091/original-src/com/itextpdf/text/pdf/FdfWriter.java#removeField(String);itext/5091/original-src/com/itextpdf/text/html/HtmlUtilities.java#parseAttributes(String);itext/5091/original-src/com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter)	10
?	978	0.028571428571429	violation support = 1 / 35	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeString(String);itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#getDeclaredEncoding(String);itext/5091/original-src/com/itextpdf/awt/geom/misc/Messages.java#format(String, Object[]);itext/5091/original-src/com/itextpdf/text/html/simpleparser/ElementFactory.java#getHyphenation(ChainedProperties);itext/5091/original-src/com/itextpdf/text/pdf/Barcode128.java#setCode(String)	15
?	979	0.028571428571429	violation support = 1 / 35	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeString(String);itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#getDeclaredEncoding(String);itext/5091/original-src/com/itextpdf/awt/geom/misc/Messages.java#format(String, Object[]);itext/5091/original-src/com/itextpdf/text/html/simpleparser/ElementFactory.java#getHyphenation(ChainedProperties);itext/5091/original-src/com/itextpdf/text/pdf/Barcode128.java#setCode(String)	15