Review

Detector:	MuDetect_RankByViolationSupport
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-357 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfWriter.java
In Method:	writeCrossReferenceTable(OutputStream, PdfIndirectReference, PdfIndirectReference, PdfIndirectReference, PdfObject, long)
Code with Misuse:	class PdfWriter.PdfBody { void writeCrossReferenceTable(final OutputStream os, final PdfIndirectReference root, final PdfIndirectReference info, final PdfIndirectReference encryption, final PdfObject fileID, final long prevxref) throws IOException { int refNumber = 0; if (writer.isFullCompression()) { flushObjStm(); refNumber = getIndirectReferenceNumber(); xrefs.add(new PdfCrossReference(refNumber, position)); } PdfCrossReference entry = xrefs.first(); int first = entry.getRefnum(); int len = 0; ArrayList<Integer> sections = new ArrayList<Integer>(); for (PdfCrossReference pdfCrossReference : xrefs) { entry = pdfCrossReference; if (first + len == entry.getRefnum()) ++len; else { sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); first = entry.getRefnum(); len = 1; } } sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); if (writer.isFullCompression()) { int mid = 5; long mask = 0xff00000000L; for (; mid > 1; --mid) { if ((mask & position) != 0) break; mask >>>= 8; } ByteBuffer buf = new ByteBuffer(); for (Object element : xrefs) { entry = (PdfCrossReference) element; entry.toPdf(mid, buf); } PdfStream xr = new PdfStream(buf.toByteArray()); buf = null; xr.flateCompress(writer.getCompressionLevel()); xr.put(PdfName.SIZE, new PdfNumber(size())); xr.put(PdfName.ROOT, root); if (info != null) { xr.put(PdfName.INFO, info); } if (encryption != null) xr.put(PdfName.ENCRYPT, encryption); if (fileID != null) xr.put(PdfName.ID, fileID); xr.put(PdfName.W, new PdfArray(new int[]{1, mid, 2})); xr.put(PdfName.TYPE, PdfName.XREF); PdfArray idx = new PdfArray(); for (int k = 0; k < sections.size(); ++k) idx.add(new PdfNumber(sections.get(k).intValue())); xr.put(PdfName.INDEX, idx); if (prevxref > 0) xr.put(PdfName.PREV, new PdfNumber(prevxref)); PdfEncryption enc = writer.crypto; writer.crypto = null; PdfIndirectObject indirect = new PdfIndirectObject(refNumber, xr, writer); indirect.writeTo(writer.getOs()); writer.crypto = enc; } else { os.write(getISOBytes("xref\n")); Iterator<PdfCrossReference> i = xrefs.iterator(); for (int k = 0; k < sections.size(); k += 2) { first = sections.get(k).intValue(); len = sections.get(k + 1).intValue(); os.write(getISOBytes(String.valueOf(first))); os.write(getISOBytes(" ")); os.write(getISOBytes(String.valueOf(len))); os.write('\n'); while (len-- > 0) { entry = i.next(); entry.toPdf(os); } } } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	1586	0.012658227848101	violation support = 1 / 79	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#parse(SimpleXMLDocHandler, InputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/wmf/MetaDo.java#wrapBMP(Image);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	11
?	1587	0.012658227848101	violation support = 1 / 79	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#parse(SimpleXMLDocHandler, InputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/wmf/MetaDo.java#wrapBMP(Image);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	11
?	1588	0.012658227848101	violation support = 1 / 79	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#parse(SimpleXMLDocHandler, InputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/wmf/MetaDo.java#wrapBMP(Image);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	11
?	1589	0.012658227848101	violation support = 1 / 79	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#parse(SimpleXMLDocHandler, InputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/wmf/MetaDo.java#wrapBMP(Image);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	11
?	1590	0.012658227848101	violation support = 1 / 79	itext/5091/original-src/com/itextpdf/text/xml/simpleparser/SimpleXMLParser.java#parse(SimpleXMLDocHandler, InputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/wmf/MetaDo.java#wrapBMP(Image);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/PdfSigGenericPKCS.java#setSignInfo(PrivateKey, Certificate[], CRL[]);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#ASCIIHexDecode(byte)	11
?	194	0.33333333333333	violation support = 1 / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfCopy.java#copyArray(PdfArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfLister.java#listPage(PdfImportedPage);itext/5091/original-src/com/itextpdf/text/pdf/parser/PdfContentStreamProcessor.java#invoke(PdfContentStreamProcessor, PdfLiteral, ArrayList);itext/5091/original-src/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#propagate(PdfObject, PdfIndirectReference, boolean);itext/5091/original-src/com/itextpdf/text/pdf/parser/ContentByteUtils.java#getContentBytesFromContentObject(PdfObject)	13
?	1959	0.0065359477124183	violation support = 1 / 153	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
?	1997	0.0054644808743169	violation support = 1 / 183	itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addASEvent(PdfName, PdfName);itext/5091/original-src/com/itextpdf/text/pdf/LtvVerification.java#outputDss(PdfDictionary, PdfDictionary, PdfArray, PdfArray, PdfArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#addOCGRadioGroup(ArrayList);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#getOCGOrder(PdfArray, PdfLayer);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#readXRefStream(long)	10
?	2072	0.0047846889952153	violation support = 1 / 209	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	10
?	2214	0.0031948881789137	violation support = 1 / 313	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
?	2215	0.0031948881789137	violation support = 1 / 313	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
?	2216	0.0031948881789137	violation support = 1 / 313	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17
?	592	0.066666666666667	violation support = 1 / 15	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/codec/PngImage.java#getColorspace();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#insertPage(int, Rectangle);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte)	17