Review

Iterator.next() is invoked without prior check of hasNext().

• missing/condition/value_or_state

org/apache/lucene/util/AttributeSource.java

computeCurrentState()

class AttributeSource {
  private void computeCurrentState() {
    currentState = new State();
    State c = currentState;
    Iterator it = attributeImpls.values().iterator();
    c.attribute = (AttributeImpl) it.next();
    while (it.hasNext()) {
      c.next = new State();
      c = c.next;
      c.attribute = (AttributeImpl) it.next();
    }        
  }

}