Review

Iterator.next() is invoked without prior check of hasNext().

• missing/condition/value_or_state

com/google/javascript/jscomp/deps/SortedDependencies.java

cycleToString(List)

class SortedDependencies {
  /**
   * @param cycle A cycle in reverse-dependency order.
   */
  private String cycleToString(List<INPUT> cycle) {
    List<String> symbols = Lists.newArrayList();
    for (int i = cycle.size() - 1; i >= 0; i--) {
      symbols.add(cycle.get(i).getProvides().iterator().next());
    }
    symbols.add(symbols.get(0));
    return Joiner.on(" -> ").join(symbols);
  }

}