Review

Detector:	MuDetect_170412_Ranking
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-357 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext().
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfWriter.java
In Method:	writeCrossReferenceTable(OutputStream, PdfIndirectReference, PdfIndirectReference, PdfIndirectReference, PdfObject, long)
Code with Misuse:	class PdfWriter.PdfBody { void writeCrossReferenceTable(final OutputStream os, final PdfIndirectReference root, final PdfIndirectReference info, final PdfIndirectReference encryption, final PdfObject fileID, final long prevxref) throws IOException { int refNumber = 0; if (writer.isFullCompression()) { flushObjStm(); refNumber = getIndirectReferenceNumber(); xrefs.add(new PdfCrossReference(refNumber, position)); } PdfCrossReference entry = xrefs.first(); int first = entry.getRefnum(); int len = 0; ArrayList<Integer> sections = new ArrayList<Integer>(); for (PdfCrossReference pdfCrossReference : xrefs) { entry = pdfCrossReference; if (first + len == entry.getRefnum()) ++len; else { sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); first = entry.getRefnum(); len = 1; } } sections.add(Integer.valueOf(first)); sections.add(Integer.valueOf(len)); if (writer.isFullCompression()) { int mid = 5; long mask = 0xff00000000L; for (; mid > 1; --mid) { if ((mask & position) != 0) break; mask >>>= 8; } ByteBuffer buf = new ByteBuffer(); for (Object element : xrefs) { entry = (PdfCrossReference) element; entry.toPdf(mid, buf); } PdfStream xr = new PdfStream(buf.toByteArray()); buf = null; xr.flateCompress(writer.getCompressionLevel()); xr.put(PdfName.SIZE, new PdfNumber(size())); xr.put(PdfName.ROOT, root); if (info != null) { xr.put(PdfName.INFO, info); } if (encryption != null) xr.put(PdfName.ENCRYPT, encryption); if (fileID != null) xr.put(PdfName.ID, fileID); xr.put(PdfName.W, new PdfArray(new int[]{1, mid, 2})); xr.put(PdfName.TYPE, PdfName.XREF); PdfArray idx = new PdfArray(); for (int k = 0; k < sections.size(); ++k) idx.add(new PdfNumber(sections.get(k).intValue())); xr.put(PdfName.INDEX, idx); if (prevxref > 0) xr.put(PdfName.PREV, new PdfNumber(prevxref)); PdfEncryption enc = writer.crypto; writer.crypto = null; PdfIndirectObject indirect = new PdfIndirectObject(refNumber, xr, writer); indirect.writeTo(writer.getOs()); writer.crypto = enc; } else { os.write(getISOBytes("xref\n")); Iterator<PdfCrossReference> i = xrefs.iterator(); for (int k = 0; k < sections.size(); k += 2) { first = sections.get(k).intValue(); len = sections.get(k + 1).intValue(); os.write(getISOBytes(String.valueOf(first))); os.write(getISOBytes(" ")); os.write(getISOBytes(String.valueOf(len))); os.write('\n'); while (len-- > 0) { entry = i.next(); entry.toPdf(os); } } } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support
?	1117	0.39275232	((pattern support = 11 / 40)(((pattern violations = 1 / 758)(violation support = 1 / 11)) / 2)(overlap = 18 / 21)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfNameTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfNumberTree.java#writeTree(HashMap, PdfWriter);itext/5091/original-src/com/itextpdf/text/pdf/PdfFunction.java#type3(PdfWriter, float, float, PdfFunction, float, float);itext/5091/original-src/com/itextpdf/text/pdf/Type1Font.java#getFontBaseType(PdfIndirectReference, int, int, byte);itext/5091/original-src/com/itextpdf/text/pdf/PdfCopyFieldsImp.java#branchForm(HashMap, PdfIndirectReference, String)	11
?	1298	0.37099567	((pattern support = 20 / 40)(((pattern violations = 1 / 77)(violation support = 1 / 77)) / 2)(overlap = 3 / 5)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfStream.java#toPdf(PdfWriter, OutputStream);itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#writeCrossReferenceTable(OutputStream, PdfIndirectReference, PdfIndirectReference, PdfIndirectReference, PdfObject, long);itext/5091/original-src/com/itextpdf/text/pdf/OutputStreamCounter.java#write(byte[]);itext/5091/original-src/com/itextpdf/text/pdf/codec/Base64.java#decodeToFile(String, String)	20
?	1325	0.36660433	((pattern support = 12 / 40)(((pattern violations = 1 / 78)(violation support = 1 / 32)) / 2)(overlap = 7 / 9)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#removeUnusedNode(PdfObject, boolean);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#decodeGenericDictionary(PdfDictionary, BaseField);itext/5091/original-src/com/itextpdf/text/pdf/XfaForm.java#processDatasetsInternal(Node);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFont.java#addRangeUni(HashMap, boolean, boolean)	12
?	1335	0.36660433	((pattern support = 12 / 40)(((pattern violations = 1 / 78)(violation support = 1 / 32)) / 2)(overlap = 7 / 9)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#removeUnusedNode(PdfObject, boolean);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#decodeGenericDictionary(PdfDictionary, BaseField);itext/5091/original-src/com/itextpdf/text/pdf/XfaForm.java#processDatasetsInternal(Node);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFont.java#addRangeUni(HashMap, boolean, boolean)	12
?	172	0.547318	((pattern support = 12 / 40)(((pattern violations = 1 / 58)(violation support = 1 / 1)) / 2)(overlap = 15 / 18)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/TextField.java#getListAppearance();itext/5091/original-src/com/itextpdf/text/pdf/CFFFontSubset.java#BuildFDArrayUsed(int);itext/5091/original-src/com/itextpdf/text/pdf/TrueTypeFontSubSet.java#createNewGlyphTables();itext/5091/original-src/com/itextpdf/text/pdf/CFFFontSubset.java#BuildSubrUsed(int, int, int, int[], HashMap, ArrayList);itext/5091/original-src/com/itextpdf/text/pdf/PdfWriter.java#writeCrossReferenceTable(OutputStream, PdfIndirectReference, PdfIndirectReference, PdfIndirectReference, PdfObject, long)	12
?	2166	0.2678642	((pattern support = 12 / 40)(((pattern violations = 1 / 285)(violation support = 1 / 16)) / 2)(overlap = 8 / 17)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfContentByte.java#bezierArc(float, float, float, float, float, float);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#addComments(FdfReader);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#getFieldPositions(String);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#getAppearance(PdfDictionary, String, String);itext/5091/original-src/com/itextpdf/text/pdf/BaseField.java#getHardBreaks(String)	12
?	2356	0.23564088	((pattern support = 12 / 40)(((pattern violations = 1 / 631)(violation support = 1 / 29)) / 2)(overlap = 7 / 18)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#createFakeFontSubsets();itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#flatFields();itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#shuffleSubsetNames();itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#fill()	12
?	2374	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2390	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2467	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2495	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2644	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2671	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	2697	0.23505737	((pattern support = 11 / 40)(((pattern violations = 1 / 638)(violation support = 1 / 612)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, int, int);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#setFieldProperty(String, String, Object, int)	11
?	3272	0.15583043	((pattern support = 12 / 40)(((pattern violations = 1 / 182)(violation support = 1 / 73)) / 2)(overlap = 3 / 19)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfEncryption.java#decryptByteArray(byte[]);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/RandomAccessFileOrArray.java#InputStreamToArray(InputStream);itext/5091/original-src/com/itextpdf/text/pdf/CJKFont.java#convertToBytes(String);itext/5091/original-src/com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#getData(boolean)	12
?	3283	0.15583043	((pattern support = 12 / 40)(((pattern violations = 1 / 182)(violation support = 1 / 73)) / 2)(overlap = 3 / 19)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfEncryption.java#decryptByteArray(byte[]);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/RandomAccessFileOrArray.java#InputStreamToArray(InputStream);itext/5091/original-src/com/itextpdf/text/pdf/CJKFont.java#convertToBytes(String);itext/5091/original-src/com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#getData(boolean)	12
?	3297	0.15583043	((pattern support = 12 / 40)(((pattern violations = 1 / 182)(violation support = 1 / 73)) / 2)(overlap = 3 / 19)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfEncryption.java#decryptByteArray(byte[]);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/RandomAccessFileOrArray.java#InputStreamToArray(InputStream);itext/5091/original-src/com/itextpdf/text/pdf/CJKFont.java#convertToBytes(String);itext/5091/original-src/com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#getData(boolean)	12
?	3306	0.15583043	((pattern support = 12 / 40)(((pattern violations = 1 / 182)(violation support = 1 / 73)) / 2)(overlap = 3 / 19)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfEncryption.java#decryptByteArray(byte[]);itext/5091/original-src/com/itextpdf/text/pdf/FilterHandlers.java#decode(byte[], PdfName, PdfObject, PdfDictionary);itext/5091/original-src/com/itextpdf/text/pdf/RandomAccessFileOrArray.java#InputStreamToArray(InputStream);itext/5091/original-src/com/itextpdf/text/pdf/CJKFont.java#convertToBytes(String);itext/5091/original-src/com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#getData(boolean)	12
?	504	0.45098042	((pattern support = 40 / 40)(((pattern violations = 1 / 51)(violation support = 1 / 51)) / 2)(overlap = 1 / 3)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/events/PdfPCellEventForwarder.java#addCellEvent(PdfPCellEvent);itext/5091/original-src/com/itextpdf/text/pdf/VerticalText.java#addText(Chunk);itext/5091/original-src/com/itextpdf/text/pdf/PdfOutline.java#addKid(PdfOutline);itext/5091/original-src/com/itextpdf/text/pdf/fonts/cmaps/CMapByteCid.java#CMapByteCid();itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#addMerged(PdfDictionary)	40
?	778	0.43224636	((pattern support = 11 / 40)(((pattern violations = 1 / 23)(violation support = 1 / 1)) / 2)(overlap = 6 / 12)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/codec/JBIG2SegmentReader.java#read();itext/5091/original-src/com/itextpdf/text/pdf/BaseField.java#moveFields(PdfDictionary, PdfDictionary);itext/5091/original-src/com/itextpdf/text/MarkedSection.java#process(ElementListener);itext/5091/original-src/com/itextpdf/awt/geom/misc/RenderingHints.java#putAll(Map);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getNamedDestinationFromStrings()	11