Review

Detector:	MuDetect_170412_Ranking
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-937 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Iterator.next() is invoked without prior check of hasNext(). Is also tikanga-12.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/PdfPKCS7.java
In Method:	PdfPKCS7(byte[], byte[], String)
Code with Misuse:	class PdfPKCS7 { /** * Verifies a signature using the sub-filter adbe.x509.rsa_sha1. * @param contentsKey the /Contents key * @param certsKey the /Cert key * @param provider the provider or <code>null</code> for the default provider */ @SuppressWarnings("unchecked") public PdfPKCS7(byte[] contentsKey, byte[] certsKey, String provider) { try { this.provider = provider; X509CertParser cr = new X509CertParser(); cr.engineInit(new ByteArrayInputStream(certsKey)); certs = cr.engineReadAll(); signCerts = certs; signCert = (X509Certificate)certs.iterator().next(); crls = new ArrayList<CRL>(); ASN1InputStream in = new ASN1InputStream(new ByteArrayInputStream(contentsKey)); digest = ((DEROctetString)in.readObject()).getOctets(); if (provider == null) sig = Signature.getInstance("SHA1withRSA"); else sig = Signature.getInstance("SHA1withRSA", provider); sig.initVerify(signCert.getPublicKey()); } catch (Exception e) { throw new ExceptionConverter(e); } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	3009	0.22517568	((pattern support = 11 / 40)(((pattern violations = 1 / 23)(violation support = 1 / 11)) / 2)(overlap = 5 / 15)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfPKCS7.java#PdfPKCS7(byte[], byte[], String);itext/5091/original-src/com/itextpdf/text/pdf/PdfPublicKeySecurityHandler.java#createDERForRecipient(byte[], X509Certificate);itext/5091/original-src/com/itextpdf/text/pdf/PdfPKCS7.java#getExtensionValue(X509Certificate, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfPKCS7.java#PdfPKCS7(byte[], boolean, String);itext/5091/original-src/com/itextpdf/text/pdf/PdfPublicKeySecurityHandler.java#computeRecipientInfo(X509Certificate, byte[])	11
?	3427	0.12359401	((pattern support = 12 / 40)(((pattern violations = 1 / 285)(violation support = 1 / 49)) / 2)(overlap = 1 / 17)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/PdfContentByte.java#bezierArc(float, float, float, float, float, float);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#addComments(FdfReader);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#getFieldPositions(String);itext/5091/original-src/com/itextpdf/text/pdf/AcroFields.java#getAppearance(PdfDictionary, String, String);itext/5091/original-src/com/itextpdf/text/pdf/BaseField.java#getHardBreaks(String)	12
?	858	0.41507939	((pattern support = 16 / 40)(((pattern violations = 1 / 3)(violation support = 1 / 2)) / 2)(overlap = 3 / 7)) / 3	itext/5091/original-src/com/itextpdf/text/pdf/parser/PdfContentStreamProcessor.java#invoke(PdfContentStreamProcessor, PdfLiteral, ArrayList);itext/5091/original-src/com/itextpdf/text/pdf/SimpleBookmark.java#shiftPageNumbers(List, int, int);itext/5091/original-src/com/itextpdf/text/pdf/PdfLister.java#listArray(PdfArray);itext/5091/original-src/com/itextpdf/text/pdf/PdfReader.java#getSinglePage(int);itext/5091/original-src/com/itextpdf/text/pdf/PdfStamperImp.java#readOCProperties()	16