Review

Calls Closeable.close() outside of finally block, which might fail to close the resource in case of an exception.

Call close() in finally block.

• missing/exception_handling

mubench/examples/survey/Close.java

missingFinally(File)

class Close {
	public void missingFinally(File file) throws IOException {
		Writer writer = new PrintWriter(new FileOutputStream(file));
		writer.write("foo");
    writer.close();
	}

}

public class TryFinallyClose {
	public void pattern(OutputStream out, String value) throws IOException {
		Writer writer = null;
		try {
			writer = new PrintWriter(out);
			writer.write(value);
		} finally {
			if (writer != null) {
				writer.close();
			}
		}
	}
}