Review

Detector:	MuDetectOPAL_180320
Target:	project ' itext ' version 5091
Misuse:	misuse ' dmmc-18 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	On line 265, `StringTokenizer.nextToken()` is invoked without prior check of `hasMoreTokens()`. This usage may be safe from context, since the tokenized value is an RBG color value which has a known number of tokens. However, the usage is unsafe against invalid values and we, therefore, consider it a misuse. (Same finding as `mudetectxp-7`)
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/html/WebColors.java
In Method:	getRGBColor(String)
Code with Misuse:	class WebColors { /** * Gives you a BaseColor based on a name. * * @param name * a name such as black, violet, cornflowerblue or #RGB or #RRGGBB * or RGB or RRGGBB or rgb(R,G,B) * @return the corresponding BaseColor object. Never returns null. * @throws IllegalArgumentException * if the String isn't a know representation of a color. / public static BaseColor getRGBColor(String name) throws IllegalArgumentException { int[] c = { 0, 0, 0, 255 }; name = name.toLowerCase(); boolean colorStrWithoutHash = missingHashColorFormat(name); if (name.startsWith("#") \|\| colorStrWithoutHash) { if (!colorStrWithoutHash) { name = name.substring(1); // lop off the # to unify hex parsing. } if (name.length() == 3) { String s = name.substring(0, 1); c[0] = Integer.parseInt(s+s, 16); String s2 = name.substring(1, 2); c[1] = Integer.parseInt(s2+s2, 16); String s3 = name.substring(2); c[2] = Integer.parseInt(s3+s3, 16); return new BaseColor(c[0], c[1], c[2], c[3]); } if (name.length() == 6) { c[0] = Integer.parseInt(name.substring(0, 2), 16); c[1] = Integer.parseInt(name.substring(2, 4), 16); c[2] = Integer.parseInt(name.substring(4), 16); return new BaseColor(c[0], c[1], c[2], c[3]); } throw new IllegalArgumentException(MessageLocalization.getComposedMessage("unknown.color.format.must.be.rgb.or.rrggbb")); } else if (name.startsWith("rgb(")) { StringTokenizer tok = new StringTokenizer(name, "rgb(), \t\r\n\f"); for (int k = 0; k < 3; ++k) { String v = tok.nextToken(); if (v.endsWith("%")) c[k] = Integer.parseInt(v.substring(0, v.length() - 1)) 255 / 100; else c[k] = Integer.parseInt(v); if (c[k] < 0) c[k] = 0; else if (c[k] > 255) c[k] = 255; } return new BaseColor(c[0], c[1], c[2], c[3]); } if (!NAMES.containsKey(name)) // TODO localize this error message. throw new IllegalArgumentException("Color '" + name + "' not found."); c = NAMES.get(name); return new BaseColor(c[0], c[1], c[2], c[3]); } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation
?	300	0.0125	(pattern support = 10 / 24)(pattern violations = 1 / 30)(overlap = 9.00 / 10.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawRadioField(float, float, float, float, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawTextField(float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawButton(float, float, float, float, String, BaseFont, float)	10
?	301	0.0125	(pattern support = 10 / 24)(pattern violations = 1 / 30)(overlap = 9.00 / 10.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawRadioField(float, float, float, float, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawTextField(float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawButton(float, float, float, float, String, BaseFont, float)	10
?	302	0.0125	(pattern support = 10 / 24)(pattern violations = 1 / 30)(overlap = 9.00 / 10.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawRadioField(float, float, float, float, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawTextField(float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawButton(float, float, float, float, String, BaseFont, float)	10
?	303	0.0125	(pattern support = 10 / 24)(pattern violations = 1 / 30)(overlap = 9.00 / 10.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawRadioField(float, float, float, float, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawTextField(float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfContentByte.java#drawButton(float, float, float, float, String, BaseFont, float)	10
?	307	0.011904761904761904	(pattern support = 10 / 24)(pattern violations = 1 / 21)(overlap = 3.00 / 5.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/GlyphList.java#<clinit>() itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/ElementFactory.java#setParagraphLeading(Paragraph, String)	10
?	3204	0.0012545620437956204	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 9.00 / 12.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	3490	0.0009293052176263855	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 5.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	4320	0.0006541867954911433	(pattern support = 13 / 24)(pattern violations = 1 / 644)(overlap = 7.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfChunk.java#trimLastSpace() itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/CellWrapper.java#<init>(String, ChainedProperties) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllNameEntries(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllFontNames(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/TableWrapper.java#createTable()	13
?	4321	0.0006541867954911433	(pattern support = 13 / 24)(pattern violations = 1 / 644)(overlap = 7.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfChunk.java#trimLastSpace() itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/CellWrapper.java#<init>(String, ChainedProperties) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllNameEntries(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllFontNames(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/TableWrapper.java#createTable()	13
?	4322	0.0006541867954911433	(pattern support = 13 / 24)(pattern violations = 1 / 644)(overlap = 7.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfChunk.java#trimLastSpace() itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/CellWrapper.java#<init>(String, ChainedProperties) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllNameEntries(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BaseFont.java#getAllFontNames(String, String, byte[]) itext/5091/build/src/main/java//com/itextpdf/text/html/simpleparser/TableWrapper.java#createTable()	13
?	4463	0.0006272810218978102	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	4464	0.0006272810218978102	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	4465	0.0006272810218978102	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	4466	0.0006272810218978102	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	4467	0.0006272810218978102	(pattern support = 11 / 24)(pattern violations = 1 / 274)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsNames(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#createDestinationArray(String, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/XMLUtil.java#unescapeXML(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/SimpleNamedDestination.java#outputNamedDestinationAsStrings(HashMap, PdfWriter) itext/5091/build/src/main/java//com/itextpdf/text/xml/simpleparser/EntitiesToUnicode.java#decodeEntity(String)	11
?	6493	0.0004274360515594737	(pattern support = 16 / 24)(pattern violations = 1 / 805)(overlap = 16.00 / 31.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfAction.java#setOCGstate(ArrayList, boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/Barcode39.java#placeBarcode(PdfContentByte, BaseColor, BaseColor) itext/5091/build/src/main/java//com/itextpdf/text/pdf/AcroFields.java#setListOption(String, String[], String[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/Barcode128.java#setCode(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/ICC_Profile.java#getInstance(byte[])	16
?	7144	0.00033670033670033677	(pattern support = 14 / 24)(pattern violations = 1 / 1386)(overlap = 12.00 / 15.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addPattern(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser.java#addClass(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/parser/LocationTextExtractionStrategy.java#getResultantText() itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addClass(String)	14
?	7145	0.00033670033670033677	(pattern support = 14 / 24)(pattern violations = 1 / 1386)(overlap = 12.00 / 15.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addPattern(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser.java#addClass(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/parser/LocationTextExtractionStrategy.java#getResultantText() itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addClass(String)	14
?	7146	0.00033670033670033677	(pattern support = 14 / 24)(pattern violations = 1 / 1386)(overlap = 12.00 / 15.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addPattern(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser.java#addClass(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/parser/LocationTextExtractionStrategy.java#getResultantText() itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addClass(String)	14
?	7147	0.00033670033670033677	(pattern support = 14 / 24)(pattern violations = 1 / 1386)(overlap = 12.00 / 15.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addPattern(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser.java#addClass(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/parser/LocationTextExtractionStrategy.java#getResultantText() itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addClass(String)	14
?	7148	0.00033670033670033677	(pattern support = 14 / 24)(pattern violations = 1 / 1386)(overlap = 12.00 / 15.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addPattern(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/Base64.java#encodeFileToFile(String, String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser.java#addClass(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/parser/LocationTextExtractionStrategy.java#getResultantText() itext/5091/build/src/main/java//com/itextpdf/text/pdf/hyphenation/SimplePatternParser#addClass(String)	14
?	8432	0.00020193861066235866	(pattern support = 10 / 24)(pattern violations = 1 / 619)(overlap = 3.00 / 10.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/BarcodeCodabar.java#placeBarcode(PdfContentByte, BaseColor, BaseColor) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BarcodeCodabar#getBarsCodabar(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BarcodeCodabar.java#getBarcodeSize() itext/5091/build/src/main/java//com/itextpdf/text/pdf/BarcodeCodabar.java#calculateChecksum(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/BarcodeCodabar.java#createAwtImage(Color, Color)	10
?	18193	0.000005422099610476364	(pattern support = 10 / 24)(pattern violations = 1 / 4990)(overlap = 5.00 / 77.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#processType0(PdfDictionary) itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int)	10	The graph contained more than 40 nodes (75) and is likely unreadable. Skipping generation.