Review

Detector:	MuDetectOPAL_180324
Target:	project ' itext ' version 5091
Misuse:	misuse ' jadet-9 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	PdfArray.getPdfObject() is invoked without checking that the array contains sufficiently many objects. Is also jadet-10.
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/itextpdf/text/pdf/fonts/cmaps/AbstractCMap.java
In Method:	addRange(PdfString, PdfString, PdfObject)
Code with Misuse:	class AbstractCMap { void addRange(PdfString from, PdfString to, PdfObject code) { byte[] a1 = decodeStringToByte(from); byte[] a2 = decodeStringToByte(to); if (a1.length != a2.length \|\| a1.length == 0) throw new IllegalArgumentException("Invalid map."); byte[] sout = null; if (code instanceof PdfString) sout = decodeStringToByte((PdfString)code); int start = a1[a1.length - 1] & 0xff; int end = a2[a2.length - 1] & 0xff; for (int k = start; k <= end; ++k) { a1[a1.length - 1] = (byte)k; PdfString s = new PdfString(a1); s.setHexWriting(true); if (code instanceof PdfArray) { addChar(s, ((PdfArray)code).getPdfObject(k - start)); } else if (code instanceof PdfNumber) { int nn = ((PdfNumber)code).intValue() + k - start; addChar(s, new PdfNumber(nn)); } else if (code instanceof PdfString) { PdfString s1 = new PdfString(sout); s1.setHexWriting(true); ++sout[sout.length - 1]; addChar(s, s1); } } } }

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	2869	0.0011508951406649618	(pattern support = 12 / 34)(pattern violations = 1 / 115)(overlap = 3.00 / 8.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfStamperImp.java#close(Map) itext/5091/build/src/main/java//com/itextpdf/text/pdf/AcroFields.java#getAppearance(PdfDictionary, String[], String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/AcroFields.java#getField(String) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfStamperImp#flatFreeTextFields() itext/5091/build/src/main/java//com/itextpdf/text/pdf/AcroFields.java#getFieldType(String)	12
?	5526	0.0003045596936999652	(pattern support = 14 / 34)(pattern violations = 1 / 338)(overlap = 5.00 / 20.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfAcroForm.java#addMultiLineTextField(String, String, BaseFont, float, float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/TextField.java#getChoiceField(boolean) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfAcroForm.java#addSingleLineTextField(String, String, BaseFont, float, float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfAcroForm.java#addSelectList(String, String[], String, BaseFont, float, float, float, float, float) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfAcroForm.java#addComboBox(String, String[], String, boolean, BaseFont, float, float, float, float, float)	14
?	6560	0.00025138260432378077	(pattern support = 10 / 34)(pattern violations = 1 / 910)(overlap = 7.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfString.java#toPdf(PdfWriter, OutputStream) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfStamperImp.java#close(Map) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfEncryption.java#createInfoId(byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfWriter.java#close() itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfEncryption.java#getFileID()	10
?	6561	0.00025138260432378077	(pattern support = 10 / 34)(pattern violations = 1 / 910)(overlap = 7.00 / 9.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfString.java#toPdf(PdfWriter, OutputStream) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfStamperImp.java#close(Map) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfEncryption.java#createInfoId(byte[]) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfWriter.java#close() itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfEncryption.java#getFileID()	10
?	7777	0.0002007006276455992	(pattern support = 12 / 34)(pattern violations = 1 / 372)(overlap = 11.00 / 52.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read1Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage.java#getImage() itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read8Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read4Bit(int)	12	The graph contained more than 40 nodes (47) and is likely unreadable. Skipping generation.
?	7778	0.0002007006276455992	(pattern support = 12 / 34)(pattern violations = 1 / 372)(overlap = 11.00 / 52.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read1Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage.java#getImage() itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read8Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read4Bit(int)	12	The graph contained more than 40 nodes (47) and is likely unreadable. Skipping generation.
?	7779	0.0002007006276455992	(pattern support = 12 / 34)(pattern violations = 1 / 372)(overlap = 11.00 / 52.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read1Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage.java#getImage() itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read8Bit(int) itext/5091/build/src/main/java//com/itextpdf/text/pdf/codec/BmpImage#read4Bit(int)	12	The graph contained more than 40 nodes (47) and is likely unreadable. Skipping generation.
?	9565	0.00005570355880039101	(pattern support = 15 / 34)(pattern violations = 1 / 5419)(overlap = 13.00 / 19.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/internal/PdfVersionImp.java#<clinit>() itext/5091/build/src/main/java//com/itextpdf/text/pdf/internal/PdfVersionImp.java#getVersionAsByteArray(char) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfWriter.java#toPdf(PdfWriter, OutputStream) itext/5091/build/src/main/java//com/itextpdf/text/pdf/PdfIndirectObject.java#<clinit>() itext/5091/build/src/main/java//com/itextpdf/text/DocWriter.java#write(String)	15
?	16137	0.000007567585417400494	(pattern support = 10 / 34)(pattern violations = 1 / 5344)(overlap = 11.00 / 80.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#processType0(PdfDictionary) itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int)	10	The graph contained more than 40 nodes (75) and is likely unreadable. Skipping generation.
?	16138	0.000007567585417400494	(pattern support = 10 / 34)(pattern violations = 1 / 5344)(overlap = 11.00 / 80.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#processType0(PdfDictionary) itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int)	10	The graph contained more than 40 nodes (75) and is likely unreadable. Skipping generation.
?	16139	0.000007567585417400494	(pattern support = 10 / 34)(pattern violations = 1 / 5344)(overlap = 11.00 / 80.00)	itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#processType0(PdfDictionary) itext/5091/build/src/main/java//com/itextpdf/text/pdf/DocumentFont.java#fillMetrics(byte[], IntHashtable, int)	10	The graph contained more than 40 nodes (75) and is likely unreadable. Skipping generation.