Review

Detector:	MuDetectOPAL_180330
Target:	project ' closure ' version 319
Misuse:	misuse ' mudetectxp-13 '
Tags:

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	On line 176, `List.get(0)` is invoked without prior check of that there is at least one element in the list (the loop that adds elements might be skipped, if an empty list is passed as a parameter).
Fix Description:
Violation Types:	missing/condition/value_or_state
In File:	com/google/javascript/jscomp/deps/SortedDependencies.java
In Method:	cycleToString(List)
Code with Misuse:	`class SortedDependencies { /** * @param cycle A cycle in reverse-dependency order. */ private String cycleToString(List<INPUT> cycle) { List<String> symbols = Lists.newArrayList(); for (int i = cycle.size() - 1; i >= 0; i--) { symbols.add(cycle.get(i).getProvides().iterator().next()); } symbols.add(symbols.get(0)); return Joiner.on(" -> ").join(symbols); } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping
?	1348	0.004314994606256742	(pattern support = 24 / 27)(pattern violations = 1 / 103)(overlap = 7.00 / 14.00)	closure/319/build/src//com/google/javascript/jscomp/PureFunctionIdentifier.java#propagateSideEffects() closure/319/build/src//com/google/javascript/jscomp/ProcessDefines.java#visit(NodeTraversal, Node, Node) closure/319/build/src//com/google/javascript/jscomp/DisambiguateProperties.java#renameProperties() closure/319/build/src//com/google/javascript/rhino/JSDocInfo.java#getTypeNodes() closure/319/build/src//com/google/javascript/jscomp/AliasExternals.java#aliasProperties(Node, Node)	24
?	2216	0.0027937420178799485	(pattern support = 10 / 27)(pattern violations = 1 / 116)(overlap = 7.00 / 8.00)	closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#firstReferenceIsAssigningDeclaration() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#isNeverAssigned() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#getOneAndOnlyAssignment() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback$ReferenceCollection.java#isInitializingAssignmentAt(int) closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback$ReferenceCollection.java#isInitializingDeclarationAt(int)	10
?	2217	0.0027937420178799485	(pattern support = 10 / 27)(pattern violations = 1 / 116)(overlap = 7.00 / 8.00)	closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#firstReferenceIsAssigningDeclaration() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#isNeverAssigned() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback.java#getOneAndOnlyAssignment() closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback$ReferenceCollection.java#isInitializingAssignmentAt(int) closure/319/build/src//com/google/javascript/jscomp/ReferenceCollectingCallback$ReferenceCollection.java#isInitializingDeclarationAt(int)	10
?	9164	0.00042553191489361696	(pattern support = 18 / 27)(pattern violations = 1 / 470)(overlap = 3.00 / 10.00)	closure/319/build/src//com/google/javascript/jscomp/NameAnalyzer.java#getSideEffectNodes(Node) closure/319/build/src//com/google/javascript/jscomp/JSModuleGraph.java#<init>(List) closure/319/build/src//com/google/javascript/jscomp/AstChangeProxy.java#replaceWith(Node, Node, List) closure/319/build/src//com/google/javascript/jscomp/AbstractCommandLineRunner.java#createInputs(List, boolean) closure/319/build/src//com/google/javascript/jscomp/DataFlowAnalysis.java#joinInputs(DiGraph$DiGraphNode)	18
?	9609	0.0002939447383891828	(pattern support = 14 / 27)(pattern violations = 1 / 294)(overlap = 1.00 / 6.00)	closure/319/build/src//com/google/javascript/jscomp/StrictModeCheck.java#process(Node, Node) closure/319/build/src//com/google/javascript/jscomp/AliasExternals.java#addMutatorFunction(String, Node) closure/319/build/src//com/google/javascript/jscomp/AstChangeProxy.java#replaceWith(Node, Node, Node) closure/319/build/src//com/google/javascript/jscomp/NameAnalyzer.java#getRhsSubexpressions(Node) closure/319/build/src//com/google/javascript/jscomp/AliasKeywords.java#access$400(String)	14
?	20183	0.00001945129660574874	(pattern support = 11 / 27)(pattern violations = 1 / 1775)(overlap = 5.00 / 59.00)	closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#mismatch(String, Node, String, JSType, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanCast(NodeTraversal, Node, JSType, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanAssignToPropertyOf(NodeTraversal, Node, JSType, JSType, Node, String) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanOverride(NodeTraversal, Node, JSType, JSType, String, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#registerMismatch(JSType, JSType)	11	The graph contained more than 40 nodes (57) and is likely unreadable. Skipping generation.
?	20184	0.00001945129660574874	(pattern support = 11 / 27)(pattern violations = 1 / 1775)(overlap = 5.00 / 59.00)	closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#mismatch(String, Node, String, JSType, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanCast(NodeTraversal, Node, JSType, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanAssignToPropertyOf(NodeTraversal, Node, JSType, JSType, Node, String) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#expectCanOverride(NodeTraversal, Node, JSType, JSType, String, JSType) closure/319/build/src//com/google/javascript/jscomp/TypeValidator.java#registerMismatch(JSType, JSType)	11	The graph contained more than 40 nodes (57) and is likely unreadable. Skipping generation.